<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119136/">https://git.reviewboard.kde.org/r/119136/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Adam Pigg</p>
<br />
<p>On July 28th, 2014, 11:52 p.m. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated July 28, 2014, 11:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix issue with resolving version of plugins (at least) on Linux</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use C function instead of int member.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
By the way simplify code using wrapper class.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">tested every type of plugin affected</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/common/KoReportPluginInterface.h <span style="color: grey">(32629af)</span></li>
<li>libs/koreport/common/KoReportPluginManager.cpp <span style="color: grey">(246027c)</span></li>
<li>plugins/kexi/spreadsheet/spreadsheetmigrate.cpp <span style="color: grey">(03b728c)</span></li>
<li>kexi/plugins/queries/CMakeLists.txt <span style="color: grey">(31355a9)</span></li>
<li>kexi/plugins/queries/kexiquerydesignerguieditor.cpp <span style="color: grey">(3b31b91)</span></li>
<li>kexi/plugins/queries/kexiquerypart.cpp <span style="color: grey">(ded8537)</span></li>
<li>kexi/plugins/relations/CMakeLists.txt <span style="color: grey">(e5a888a)</span></li>
<li>kexi/plugins/relations/kexirelationhandler.desktop <span style="color: grey">(5a7765e)</span></li>
<li>kexi/plugins/relations/kexirelationpartimpl.cpp <span style="color: grey">(901038a)</span></li>
<li>kexi/plugins/reports/CMakeLists.txt <span style="color: grey">(51dd75c)</span></li>
<li>kexi/plugins/reports/kexireports.cpp <span style="color: grey">(67b4189)</span></li>
<li>kexi/plugins/scripting/kexiscripting/CMakeLists.txt <span style="color: grey">(f3f07d9)</span></li>
<li>kexi/plugins/scripting/kexiscripting/kexiscriptpart.cpp <span style="color: grey">(158b5ac)</span></li>
<li>kexi/plugins/tables/CMakeLists.txt <span style="color: grey">(4aeb380)</span></li>
<li>kexi/plugins/tables/kexitablepart.cpp <span style="color: grey">(36c5922)</span></li>
<li>kexi/tests/altertable/altertable.cpp <span style="color: grey">(4a73af8)</span></li>
<li>kexi/widget/kexidbconnectionwidget.cpp <span style="color: grey">(8555702)</span></li>
<li>kexi/widget/navigator/KexiProjectModel.cpp <span style="color: grey">(d5ec550)</span></li>
<li>kexi/widget/navigator/KexiProjectNavigator.cpp <span style="color: grey">(7e665ac)</span></li>
<li>libs/db/CMakeLists.txt <span style="color: grey">(419a06a)</span></li>
<li>libs/db/driver.h <span style="color: grey">(ed2469f)</span></li>
<li>libs/db/driver_p.h <span style="color: grey">(62a23db)</span></li>
<li>libs/db/drivermanager.cpp <span style="color: grey">(ddca64e)</span></li>
<li>libs/db/drivers/sqlite/sqlitedriver.cpp <span style="color: grey">(f28ec7f)</span></li>
<li>libs/koreport/CMakeLists.txt <span style="color: grey">(26d299c)</span></li>
<li>kexi/plugins/forms/widgets/webbrowser/kformdesigner_webbrowser.desktop <span style="color: grey">(960616c)</span></li>
<li>kexi/plugins/importexport/csv/CMakeLists.txt <span style="color: grey">(9324ef1)</span></li>
<li>kexi/plugins/importexport/csv/kexicsv_importexporthandler.desktop <span style="color: grey">(909e8fc)</span></li>
<li>kexi/plugins/importexport/csv/kexicsv_importexportpart.cpp <span style="color: grey">(7a6e8a8)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvimportdialog.cpp <span style="color: grey">(426368a)</span></li>
<li>kexi/plugins/migration/CMakeLists.txt <span style="color: grey">(f123d10)</span></li>
<li>kexi/plugins/migration/keximigrationhandler.desktop <span style="color: grey">(96364d1)</span></li>
<li>kexi/plugins/migration/keximigrationpart.cpp <span style="color: grey">(21b0d88)</span></li>
<li>kexi/plugins/forms/widgets/mapbrowser/CMakeLists.txt <span style="color: grey">(21ee0b4)</span></li>
<li>kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactory.cpp <span style="color: grey">(5d9ecb9)</span></li>
<li>kexi/plugins/forms/widgets/mapbrowser/kformdesigner_mapbrowser.desktop <span style="color: grey">(9e076b5)</span></li>
<li>kexi/plugins/forms/widgets/webbrowser/CMakeLists.txt <span style="color: grey">(eb5c633)</span></li>
<li>kexi/plugins/forms/widgets/webbrowser/WebBrowserFactory.cpp <span style="color: grey">(fa768cc)</span></li>
<li>kexi/plugins/forms/kformdesigner_kexidbfactory.desktop <span style="color: grey">(77c1190)</span></li>
<li>kexi/migration/sybase/sybasemigrate.cpp <span style="color: grey">(4967726)</span></li>
<li>kexi/migration/txt/txtmigrate.h <span style="color: grey">(8f87a8a)</span></li>
<li>kexi/migration/txt/txtmigrate.cpp <span style="color: grey">(1cf3805)</span></li>
<li>kexi/migration/xbase/xbasemigrate.h <span style="color: grey">(18ec111)</span></li>
<li>kexi/migration/xbase/xbasemigrate.cpp <span style="color: grey">(403ea86)</span></li>
<li>kexi/plugins/autoforms/CMakeLists.txt <span style="color: grey">(a4e9f84)</span></li>
<li>kexi/plugins/autoforms/KexiAutoForms.cpp <span style="color: grey">(874e081)</span></li>
<li>kexi/plugins/forms/CMakeLists.txt <span style="color: grey">(0503396)</span></li>
<li>kexi/plugins/forms/kexidbfactory.cpp <span style="color: grey">(b320afd)</span></li>
<li>kexi/plugins/forms/kexiforms.cpp <span style="color: grey">(24be71e)</span></li>
<li>kexi/main/startup/KexiRecentProjectsModel.cpp <span style="color: grey">(303b5eb)</span></li>
<li>kexi/main/startup/KexiStartup.h <span style="color: grey">(0c7dd13)</span></li>
<li>kexi/main/startup/KexiStartup.cpp <span style="color: grey">(6daf5b1)</span></li>
<li>kexi/migration/importtablewizard.cpp <span style="color: grey">(48fa2b0)</span></li>
<li>kexi/migration/keximigrate.h <span style="color: grey">(606d58b)</span></li>
<li>kexi/migration/keximigrate_p.h <span style="color: grey">(6977232)</span></li>
<li>kexi/migration/mdb/src/keximdb/mdbmigrate.h <span style="color: grey">(320c3e0)</span></li>
<li>kexi/migration/mdb/src/keximdb/mdbmigrate.cpp <span style="color: grey">(af8e432)</span></li>
<li>kexi/migration/migratemanager.cpp <span style="color: grey">(0a52a73)</span></li>
<li>kexi/migration/mysql/mysqlmigrate.h <span style="color: grey">(0a0bd2b)</span></li>
<li>kexi/migration/mysql/mysqlmigrate.cpp <span style="color: grey">(d511d15)</span></li>
<li>kexi/migration/pqxx/pqxxmigrate.h <span style="color: grey">(1870cd2)</span></li>
<li>kexi/migration/pqxx/pqxxmigrate.cpp <span style="color: grey">(ecd9873)</span></li>
<li>kexi/migration/sybase/sybasemigrate.h <span style="color: grey">(5bdbb87)</span></li>
<li>kexi/kexidb/drivers/oracle/oracledriver.cpp <span style="color: grey">(64d1efc)</span></li>
<li>kexi/kexidb/drivers/pqxx/pqxxdriver.cpp <span style="color: grey">(2f1ea2b)</span></li>
<li>kexi/kexidb/drivers/sybase/sybasedriver.cpp <span style="color: grey">(e2c9d52)</span></li>
<li>kexi/kexidb/drivers/xbase/xbasedriver.cpp <span style="color: grey">(f3f5f49)</span></li>
<li>kexi/main/KexiMainWindow.cpp <span style="color: grey">(89e9386)</span></li>
<li>kexi/main/KexiUserFeedbackAgent.cpp <span style="color: grey">(b07407e)</span></li>
<li>kexi/formeditor/widgetfactory.desktop <span style="color: grey">(1fb3724)</span></li>
<li>kexi/formeditor/widgetfactory.h <span style="color: grey">(2a8fb7f)</span></li>
<li>kexi/formeditor/widgetlibrary.cpp <span style="color: grey">(883d678)</span></li>
<li>kexi/kexidb/drivers/mysql/mysqldriver.cpp <span style="color: grey">(b243685)</span></li>
<li>kexi/kexidb/drivers/odbc/kodbcdriver.cpp <span style="color: grey">(4be9645)</span></li>
<li>kexi/formeditor/factories/containerfactory.cpp <span style="color: grey">(20ade31)</span></li>
<li>kexi/formeditor/factories/kformdesigner_containers.desktop <span style="color: grey">(f89cb40)</span></li>
<li>kexi/formeditor/factories/kformdesigner_stdwidgets.desktop <span style="color: grey">(746428f)</span></li>
<li>kexi/formeditor/factories/stdwidgetfactory.cpp <span style="color: grey">(45347ae)</span></li>
<li>kexi/formeditor/kexiactionselectiondialog.cpp <span style="color: grey">(c31c70c)</span></li>
<li>kexi/formeditor/kexiformeventhandler.cpp <span style="color: grey">(29e5bfb)</span></li>
<li>kexi/core/kexipartmanager.cpp <span style="color: grey">(0aae8df)</span></li>
<li>kexi/core/kexiprojectset.cpp <span style="color: grey">(4008152)</span></li>
<li>kexi/core/kexistaticpart.cpp <span style="color: grey">(cf276cd)</span></li>
<li>kexi/data/CMakeLists.txt <span style="color: grey">(53569f2)</span></li>
<li>kexi/data/kexihandler.desktop <span style="color: grey">(c0bfef1)</span></li>
<li>kexi/formeditor/factories/CMakeLists.txt <span style="color: grey">(5db434a)</span></li>
<li>kexi/core/kexipartbase.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/core/kexipartbase.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/core/kexipartinfo.h <span style="color: grey">(2742818)</span></li>
<li>kexi/core/kexipartinfo.cpp <span style="color: grey">(f9f1fa7)</span></li>
<li>kexi/core/kexipartmanager.h <span style="color: grey">(caa7e49)</span></li>
<li>kexi/core/CMakeLists.txt <span style="color: grey">(6ba58f1)</span></li>
<li>kexi/core/KexiMainWindowIface.h <span style="color: grey">(8a26de1)</span></li>
<li>kexi/core/kexi.h <span style="color: grey">(92c83b8)</span></li>
<li>kexi/core/kexi.cpp <span style="color: grey">(4e1d5fa)</span></li>
<li>kexi/core/kexihandler.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/core/kexiinternalpart.h <span style="color: grey">(7757b37)</span></li>
<li>kexi/core/kexiinternalpart.cpp <span style="color: grey">(9e9100c)</span></li>
<li>kexi/core/kexipart.h <span style="color: grey">(172fd0e)</span></li>
<li>kexi/core/kexipart.cpp <span style="color: grey">(e1759ce)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119136/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>