<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119222/">https://git.reviewboard.kde.org/r/119222/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 15th, 2014, 12:08 a.m. CEST, <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Much cooler! Thanks.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Noticed: <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- when double clicking it's supereasy to accidentally move the item by a few pixels; on displays with even more density it will be even more noticeable<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- this time crashes on inserting a new Field item:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Thread 1 (Thread 0x7fea16cf0780 (LWP 8479)):<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
[KCrash Handler]</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">4 0x00007fe9ec6dc6b8 in KoReportItemBase::entityName (this=0x0) at /home/jarek/dev/src/calligra-master2/libs/koreport/common/KoReportItemBase.cpp:107</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">5 0x00007fe9ec7278ff in KoReportDesigner::isEntityNameUnique (this=0x1ac43f0, n=..., ignore=0x0) at /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/KoReportDesigner.cpp:1118</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">6 0x00007fe9ec727771 in KoReportDesigner::suggestEntityName (this=0x1ac43f0, n=...) at /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/KoReportDesigner.cpp:1100</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">7 0x00007fe9ec731e63 in KoReportDesignerItemLabel::KoReportDesignerItemLabel (this=0x21c0040, d=0x1ac43f0, scene=0x1d4c4f0, pos=...) at /home/jarek/dev/src/calligra-master2/libs/koreport/items/label/KoReportDesignerItemLabel.cpp:62</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">8 0x00007fe9ec7341c5 in KoReportLabelPlugin::createDesignerInstance (this=0x173e810, designer=0x1ac43f0, scene=0x1d4c4f0, pos=...) at /home/jarek/dev/src/calligra-master2/libs/koreport/items/label/KoReportLabelPlugin.cpp:52</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">9 0x00007fe9ec7267c8 in KoReportDesigner::sectionMouseReleaseEvent (this=0x1ac43f0, v=0x1ac56d0, e=0x7fffb81f1d30) at /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/KoReportDesigner.cpp:866</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">10 0x00007fe9ec72002f in ReportSceneView::mouseReleaseEvent (this=0x1ac56d0, e=0x7fffb81f1d30) at /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/reportsceneview.cpp:64</h1>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">the edited text isn't aligned well (horizontally/vertically)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">bg/fg color not copied to the edited text</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">clicking on any area of the label during editing still does not change cursor's position; instead just ends the editing mode</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">when in editing mode, if I switch to other report and switch back, the editing mode is apparently still present but the cursor is invisible; it's also impossible to enter text; the only solution is to click on any report's area </li>
</ul>
</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Later Todos:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- escape key shall exit from the edit mode, F2 shall enter it</p></pre>
</blockquote>
<p>On July 20th, 2014, 11:54 a.m. CEST, <b>Adam Pigg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixed fg/bg color<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Fixed item positioning<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Fixed crashes</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OK, but did you submit the patch #4?</p></pre>
<br />
<p>- Jarosław</p>
<br />
<p>On July 14th, 2014, 9:11 p.m. CEST, Adam Pigg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated July 14, 2014, 9:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=336825">336825</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Usage:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Insert label<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Double click to enter inline-edit mode<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
-Label text is selected and can be overwritten<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Click away from item to exit edit mode<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
-Item text is updated with editor text</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Inserted label on new report and checked usage</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Loaded existing report and ensured labels are editiable</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/CMakeLists.txt <span style="color: grey">(26d299c54189f5b402348baa1821f7641a1afd74)</span></li>
<li>libs/koreport/items/check/KoReportDesignerItemCheck.cpp <span style="color: grey">(5bebc6c4e10f2243919a0b2668ea3a8ff02ce954)</span></li>
<li>libs/koreport/items/field/KoReportDesignerItemField.cpp <span style="color: grey">(0dc9325a1c04dda83bdc7c2a3e4eae5eb500c52f)</span></li>
<li>libs/koreport/items/image/KoReportDesignerItemImage.cpp <span style="color: grey">(87e46a1ca3ad6dc0a025eeac90dac12e12029691)</span></li>
<li>libs/koreport/items/label/BoundedTextItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/items/label/BoundedTextItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/items/label/KoReportDesignerItemLabel.h <span style="color: grey">(b2aa78f4bb444fecffc4d01b09901e97204350ee)</span></li>
<li>libs/koreport/items/label/KoReportDesignerItemLabel.cpp <span style="color: grey">(8974a807b122649a6c6daf61f34c678cb5ec9961)</span></li>
<li>libs/koreport/items/text/KoReportDesignerItemText.cpp <span style="color: grey">(51e12d3020104fec4cb8cc473d5499e085dfbf2c)</span></li>
<li>libs/koreport/renderer/KoReportPrintRenderer.cpp <span style="color: grey">(4018c3b2febbc0dfce9fc528f3f168fa0bc62cbb)</span></li>
<li>libs/koreport/renderer/KoReportScreenRenderer.cpp <span style="color: grey">(d47ce494b957c225ffaf264fe85ea9208165affb)</span></li>
<li>libs/koreport/renderer/odtframe/KoOdtFrameReportCheckBox.cpp <span style="color: grey">(719e890c53896c9d4a12ad0793f5d9e84e45943f)</span></li>
<li>libs/koreport/wrtembed/KoReportDesigner.cpp <span style="color: grey">(63152a7d7efb0917534a869df436292616ef0284)</span></li>
<li>libs/koreport/wrtembed/reportscene.cpp <span style="color: grey">(2e9c54d29c135c041db75d2a843ea5bd8318e1c1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119222/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>