<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118532/">https://git.reviewboard.kde.org/r/118532/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Camilla Boemann, Inge Wallin, and Dan Leinir Turthra Jensen.</div>
<div>By Denis Kuplyakov.</div>
<p style="color: grey;"><i>Updated Июль 22, 2014, 3:13 п.п.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This adds proper section handling to code. It concentrates on managing to not break section structure during editing of text.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Patch fixes many things:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
1) Insertion of text into sections<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
2) Deletion of text with sections<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
3) Cut, paste of text with sections<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
4) Applying style doesn't remove section info<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
5) WORDS product set added for fast building of Words and Author<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
6) Sections visual indication (need improvements)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Future TODOS:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
1) improving section indication (DONE)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
2) ability to insert section (DONE)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
3) adding unittests (DONE)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
4) change icon for "New section" functionality (DONE)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
5) we should read "Undo New section" in edit, after inserting new one (DONE)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
6) fix indication of sections for multipage documents (DONE)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have tested all functionality with emphasis on deletion. It has the most complicated code and need very good testing.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
You can use LibreOffice Writer to create document with sections and then test editing it in words. And I will attach one I've used.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoCanvasResourceManager.h <span style="color: grey">(2ad1c6f)</span></li>
<li>libs/flake/KoShapeLoadingContext.h <span style="color: grey">(1e7d196)</span></li>
<li>libs/flake/KoShapeLoadingContext.cpp <span style="color: grey">(65c9cbe)</span></li>
<li>libs/flake/KoShapePaintingContext.h <span style="color: grey">(a7d15fd)</span></li>
<li>libs/flake/KoShapePaintingContext.cpp <span style="color: grey">(28ce859)</span></li>
<li>libs/kotext/CMakeLists.txt <span style="color: grey">(44fa937)</span></li>
<li>libs/kotext/KoSection.h <span style="color: grey">(ac3fdd8)</span></li>
<li>libs/kotext/KoSection.cpp <span style="color: grey">(72e504f)</span></li>
<li>libs/kotext/KoSectionEnd.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoSectionEnd.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoSectionManager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoSectionManager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoSectionUtils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoSectionUtils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoTextDocument.h <span style="color: grey">(b11100c)</span></li>
<li>libs/kotext/KoTextDocument.cpp <span style="color: grey">(08d1295)</span></li>
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(1a47d2e)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(3d5e1ff)</span></li>
<li>libs/kotext/KoTextEditor_format.cpp <span style="color: grey">(663f6cf)</span></li>
<li>libs/kotext/KoTextPaste.cpp <span style="color: grey">(3c8e4fc)</span></li>
<li>libs/kotext/commands/ChangeListCommand.h <span style="color: grey">(bc49578)</span></li>
<li>libs/kotext/commands/DeleteCommand.h <span style="color: grey">(bb02be0)</span></li>
<li>libs/kotext/commands/DeleteCommand.cpp <span style="color: grey">(db5ff53)</span></li>
<li>libs/kotext/commands/NewSectionCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/NewSectionCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/RenameSectionCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/RenameSectionCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.h <span style="color: grey">(9e1c321)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(369b8c1)</span></li>
<li>libs/kotext/opendocument/KoTextWriter_p.cpp <span style="color: grey">(4449f44)</span></li>
<li>libs/kotext/tests/TestKoTextEditor.h <span style="color: grey">(a2c2c09)</span></li>
<li>libs/kotext/tests/TestKoTextEditor.cpp <span style="color: grey">(9daa2e6)</span></li>
<li>libs/kundo2/kundo2magicstring.h <span style="color: grey">(a911141)</span></li>
<li>libs/kundo2/kundo2stack.h <span style="color: grey">(7b2bdda)</span></li>
<li>libs/odf/KoOdfPaste.cpp <span style="color: grey">(e0db35e)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.h <span style="color: grey">(6c44aa3)</span></li>
<li>libs/textlayout/KoTextLayoutArea.h <span style="color: grey">(8ec51a6)</span></li>
<li>libs/textlayout/KoTextLayoutArea_paint.cpp <span style="color: grey">(3164a77)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(0e29ebb)</span></li>
<li>plugins/textshape/TextShape.cpp <span style="color: grey">(23eac60)</span></li>
<li>plugins/textshape/TextTool.h <span style="color: grey">(3409292)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(913bca0)</span></li>
<li>plugins/textshape/dialogs/SectionFormatDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SectionFormatDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SectionFormatDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleInsertWidget.cpp <span style="color: grey">(c2f083f)</span></li>
<li>plugins/textshape/dialogs/SimpleInsertWidget.ui <span style="color: grey">(4b9c639)</span></li>
<li>words/part/CMakeLists.txt <span style="color: grey">(870d674)</span></li>
<li>words/part/KWApplicationConfig.h <span style="color: grey">(87f1016)</span></li>
<li>words/part/KWApplicationConfig.cpp <span style="color: grey">(1df6557)</span></li>
<li>words/part/KWDocument.h <span style="color: grey">(4bc53e1)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(46b5e41)</span></li>
<li>words/part/KWFactory.cpp <span style="color: grey">(9894f40)</span></li>
<li>words/part/KWOdfLoader.cpp <span style="color: grey">(4f82faa)</span></li>
<li>words/part/KWView.h <span style="color: grey">(50ee760)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(1ec4f7b)</span></li>
<li>words/part/author/CAuFactory.cpp <span style="color: grey">(6813963)</span></li>
<li>words/part/author/CoverSelectionDialog.h <span style="color: grey">(9f2b0dd)</span></li>
<li>words/part/dockers/KWDebugDocker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWDebugDocker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWDebugDockerFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWDebugDockerFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWDebugWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWDebugWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/words.rc <span style="color: grey">(c3a9822)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118532/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/04/f87d4ce2-3ab9-48a4-a880-4caa586790fc__Test-orig.odt">File for testing</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>