<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119222/">https://git.reviewboard.kde.org/r/119222/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 10th, 2014, 10:25 p.m. UTC, <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks nicely functional already! <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Things to consider: <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- after showing the label is not resized to the size of parent - see http://wstaw.org/m/2014/07/10/plasma-desktoppn2275.png<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- dashed frame is not needed then (see the same screenshot)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- the font is not copied<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- clicking on any area of the label during editing does not change cursor, maybe z-order isn't proper?<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- would be nicve if F2 shortcut also entered into the edit mode<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- when I use the property editor to enter the caption, after clicking outside the caption text is reset to the original value; now the only way to enter the text is to use the inline editor<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- inserting a new label (or copy-pasting) crashes, exactly 6 times result of dynamic_cast<KoReportItemBase*> does not seem to be compared with 0:</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">4 0x00007f05e3473440 in KoReportItemBase::entityName (this=0x0) at /home/jarek/dev/src/calligra-master2/libs/koreport/common/KoReportItemBase.cpp:107</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">5 0x00007f05e34beb89 in KoReportDesigner::isEntityNameUnique (this=0x2f1bae0, n=..., ignore=0x0) at /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/KoReportDesigner.cpp:1161</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">6 0x00007f05e34be535 in KoReportDesigner::suggestEntityName (this=0x2f1bae0, n=...) at /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/KoReportDesigner.cpp:1100</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">7 0x00007f05e34c8b89 in KoReportDesignerItemLabel::KoReportDesignerItemLabel (this=0x3076230, d=0x2f1bae0, scene=0x2f3bb90, pos=...) at /home/jarek/dev/src/calligra-master2/libs/koreport/items/label/KoReportDesignerItemLabel.cpp:56</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">8 0x00007f05e34cae89 in KoReportLabelPlugin::createDesignerInstance (this=0x2214440, designer=0x2f1bae0, scene=0x2f3bb90, pos=...) at /home/jarek/dev/src/calligra-master2/libs/koreport/items/label/KoReportLabelPlugin.cpp:52</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">9 0x00007f05e34bd58c in KoReportDesigner::sectionMouseReleaseEvent (this=0x2f1bae0, v=0x2f37170, e=0x7fffc569b8f0) at /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/KoReportDesigner.cpp:866</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">10 0x00007f05e34b6df3 in ReportSceneView::mouseReleaseEvent (this=0x2f37170, e=0x7fffc569b8f0) at /home/jarek/dev/src/calligra-master2/libs/koreport/wrtembed/reportsceneview.cpp:64</h1></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ive fixed the crash</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixed the text not being updatable in the property editor</p></pre>
<br />
<p>- Adam</p>
<br />
<p>On July 10th, 2014, 9:22 p.m. UTC, Adam Pigg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated July 10, 2014, 9:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=336825">336825</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Usage:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Insert label<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Double click to enter inline-edit mode<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
-Label text is selected and can be overwritten<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Click away from item to exit edit mode<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
-Item text is updated with editor text</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Inserted label on new report and checked usage</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Loaded existing report and ensured labels are editiable</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/items/label/KoReportDesignerItemLabel.h <span style="color: grey">(b2aa78f4bb444fecffc4d01b09901e97204350ee)</span></li>
<li>libs/koreport/items/label/KoReportDesignerItemLabel.cpp <span style="color: grey">(8974a807b122649a6c6daf61f34c678cb5ec9961)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119222/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>