<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/111734/">https://git.reviewboard.kde.org/r/111734/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 6th, 2014, 2:18 p.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi. Given the reservation and no other supporters, could this review request please either be supported by somebody else or be closed for now, given the inactivity?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I still think it is good to land this patch. It is different from runtest.sh in that it allows you to catch changes in the ppt to odp conversion even if you were not looking for them specifically.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
The test compares the whole file and not just a few xpath expressions. The upside is the coverage. The downside is that is it less specific, but that is fine. For specific tests we have runtests.sh.</p></pre>
<br />
<p>- Jos</p>
<br />
<p>On July 26th, 2013, 8:41 p.m. UTC, Jos van den Oever wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jos van den Oever.</div>
<p style="color: grey;"><i>Updated July 26, 2013, 8:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To test ppt conversion the simplest approach is to take a ppt file, convert it to odp and check that the output is exactly the same.
This test does that for a simple two slide presentation with a diagram.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran the test multiple times and it passes every time. It is repeatable.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/stage/powerpoint/CMakeLists.txt <span style="color: grey">(b434bef)</span></li>
<li>filters/stage/powerpoint/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/powerpoint/tests/TestPPT.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/powerpoint/tests/TestPPT.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/powerpoint/tests/data/diagram.ppt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/powerpoint/tests/data/diagram_odp/META-INF/manifest.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/powerpoint/tests/data/diagram_odp/content.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/powerpoint/tests/data/diagram_odp/meta.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/powerpoint/tests/data/diagram_odp/settings.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/powerpoint/tests/data/diagram_odp/styles.xml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/111734/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>