<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119136/">https://git.reviewboard.kde.org/r/119136/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">does this not need to be calligra-wide? or use a calligre solution...sureley there are other apps with plugin loading issues?</p></pre>
<br />
<p>- Adam Pigg</p>
<br />
<p>On July 5th, 2014, 7:17 p.m. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated July 5, 2014, 7:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix issue with resolving version of plugins (at least) on Linux
Use C function instead of int member.
By the way simplify code using wrapper class.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested every type of plugin affected</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/kexidb/drivers/sybase/sybasedriver.cpp <span style="color: grey">(e2c9d52dff66f9d72937a924ff681f25781529f8)</span></li>
<li>kexi/kexidb/drivers/xbase/xbasedriver.cpp <span style="color: grey">(f3f5f49d63e9de2bf035a909f3ca1020cce31d52)</span></li>
<li>kexi/migration/keximigrate.h <span style="color: grey">(606d58b318a8a7bc57e57bc492f58bc321c34785)</span></li>
<li>kexi/migration/keximigrate_p.h <span style="color: grey">(697723212463489008026092fba029cc2f6eb2a7)</span></li>
<li>kexi/migration/mdb/src/keximdb/mdbmigrate.h <span style="color: grey">(320c3e0e90fb29d1157d506ae3bb4b714c0df77a)</span></li>
<li>kexi/migration/mdb/src/keximdb/mdbmigrate.cpp <span style="color: grey">(af8e432b0c3d4ddf42d52c860efa68903b1345f9)</span></li>
<li>kexi/migration/migratemanager.cpp <span style="color: grey">(0a52a738d6a4934691a575a91b80cc7dfe4b759a)</span></li>
<li>kexi/migration/mysql/mysqlmigrate.h <span style="color: grey">(0a0bd2bf6022ba2f33572ff17692494ed3578f35)</span></li>
<li>kexi/migration/mysql/mysqlmigrate.cpp <span style="color: grey">(d511d159d400c38281335e20522d816414e6c06f)</span></li>
<li>kexi/migration/pqxx/pqxxmigrate.h <span style="color: grey">(1870cd2b552d65acaec5c073af8f23b1c1c24948)</span></li>
<li>kexi/migration/pqxx/pqxxmigrate.cpp <span style="color: grey">(ecd987381e5e53c1ddf689e81ee8ccd0e8bdb8e6)</span></li>
<li>kexi/migration/sybase/sybasemigrate.h <span style="color: grey">(5bdbb879b3162ead8fddca20997abc4d7c379904)</span></li>
<li>kexi/formeditor/widgetfactory.h <span style="color: grey">(2a8fb7f49878186a0c8bd24d70f47ded3fe1f8b2)</span></li>
<li>libs/db/driver_p.h <span style="color: grey">(62a23dbd7909f0c61b0a81b55c88e71ffc9f0acc)</span></li>
<li>libs/db/drivermanager.cpp <span style="color: grey">(ddca64e3aeee8b9d8c9c512053a8c0c38b1ad078)</span></li>
<li>libs/db/drivers/sqlite/sqlitedriver.cpp <span style="color: grey">(f28ec7f5cca8a3a51d44e2e9e01317048f96fa03)</span></li>
<li>libs/db/pluginloader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/db/pluginloader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/CMakeLists.txt <span style="color: grey">(26d299c54189f5b402348baa1821f7641a1afd74)</span></li>
<li>libs/koreport/common/KoReportPluginInterface.h <span style="color: grey">(32629afcabd4384ef3f64320065fe880e87130ab)</span></li>
<li>libs/koreport/common/KoReportPluginManager.cpp <span style="color: grey">(246027cbd605aa69c8b7e9eb3ff01de5c712ac97)</span></li>
<li>plugins/kexi/spreadsheet/spreadsheetmigrate.cpp <span style="color: grey">(03b728c0d27f3172bb56083fe4d7792866a2e2a4)</span></li>
<li>kexi/plugins/migration/keximigrationpart.cpp <span style="color: grey">(21b0d88118b986930cc01298ce4ded7cafeb1696)</span></li>
<li>kexi/plugins/queries/kexiquerypart.cpp <span style="color: grey">(ded8537da76d21a55e5705ec4e60072edd956f42)</span></li>
<li>kexi/plugins/relations/kexirelationpartimpl.cpp <span style="color: grey">(901038a10134a4e2406063048079e0615b14741e)</span></li>
<li>kexi/plugins/reports/kexireports.cpp <span style="color: grey">(67b4189f621ad9c4c3b37fd6a1954a9fa2abdf92)</span></li>
<li>kexi/plugins/scripting/kexiscripting/kexiscriptpart.cpp <span style="color: grey">(158b5acaf88ba05a7ab7a9649ef358d951892c25)</span></li>
<li>kexi/plugins/tables/kexitablepart.cpp <span style="color: grey">(36c5922cf61e853b645fa98ed446e5ecdff590d8)</span></li>
<li>libs/db/CMakeLists.txt <span style="color: grey">(419a06abb65d8995dd30149913960380a0b1b1c9)</span></li>
<li>libs/db/driver.h <span style="color: grey">(ed2469f158b9e0320645b4bd0cbc574e9a692dbf)</span></li>
<li>kexi/core/kexipart.h <span style="color: grey">(172fd0e3a2b7139edc71c820a9ef7857492f64b1)</span></li>
<li>kexi/core/kexipartmanager.cpp <span style="color: grey">(0aae8df91a84e11d3ecaf15f29d554cfd6892302)</span></li>
<li>kexi/formeditor/factories/containerfactory.cpp <span style="color: grey">(20ade31ed167a040cb32022f9a21da46176c9f45)</span></li>
<li>kexi/formeditor/factories/stdwidgetfactory.cpp <span style="color: grey">(45347aebc77145cd108bb21a7c0430131951615c)</span></li>
<li>kexi/migration/sybase/sybasemigrate.cpp <span style="color: grey">(4967726bf4faf302326d4460bd64b587e0adc43a)</span></li>
<li>kexi/migration/txt/txtmigrate.h <span style="color: grey">(8f87a8a9e92e3bec3d5a215ac5c19db3d82c7207)</span></li>
<li>kexi/migration/txt/txtmigrate.cpp <span style="color: grey">(1cf380538e43172e6a32e039dfd7c30c210347a2)</span></li>
<li>kexi/migration/xbase/xbasemigrate.h <span style="color: grey">(18ec11102a5a1d7751e0c2d0c9841d608e1be95e)</span></li>
<li>kexi/migration/xbase/xbasemigrate.cpp <span style="color: grey">(403ea869b905e79a3585c6427e22964c79ba6422)</span></li>
<li>kexi/plugins/autoforms/KexiAutoForms.cpp <span style="color: grey">(874e0817d61cdcfe1e9b03a39cb69ec859931e2a)</span></li>
<li>kexi/plugins/forms/kexidbfactory.cpp <span style="color: grey">(b320afdbaf03d99d7d1ca1c8d08bb3b93cabf2a7)</span></li>
<li>kexi/plugins/forms/kexiforms.cpp <span style="color: grey">(24be71e15aadbe62adbe6bf9800fa9fd15eb2bd6)</span></li>
<li>kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactory.cpp <span style="color: grey">(5d9ecb9567b15484042f7a1d974b215dd8951c18)</span></li>
<li>kexi/plugins/forms/widgets/webbrowser/WebBrowserFactory.cpp <span style="color: grey">(fa768cced66d57583d9f14bf8cd74fbc1e6be667)</span></li>
<li>kexi/plugins/importexport/csv/kexicsv_importexportpart.cpp <span style="color: grey">(7a6e8a833be005a269a80c1f444f1062c31882f1)</span></li>
<li>kexi/formeditor/widgetlibrary.cpp <span style="color: grey">(883d6787574de63039035497d45ac175748f4b51)</span></li>
<li>kexi/kexidb/drivers/mysql/mysqldriver.cpp <span style="color: grey">(b243685ca9c71b25d46b8624fa06fa24652cdcbe)</span></li>
<li>kexi/kexidb/drivers/odbc/kodbcdriver.cpp <span style="color: grey">(4be964588023c79d651b53d68b96b87b2418e2d9)</span></li>
<li>kexi/kexidb/drivers/oracle/oracledriver.cpp <span style="color: grey">(64d1efc2d4bc9843949a188453c6c205bf4b7443)</span></li>
<li>kexi/kexidb/drivers/pqxx/pqxxdriver.cpp <span style="color: grey">(2f1ea2bb5bbd180b72eee959d66e82d1e56bb2ad)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119136/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>