<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118986/">https://git.reviewboard.kde.org/r/118986/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 29th, 2014, 9:33 p.m. UTC, <b>Adam Pigg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118986/diff/1/?file=285029#file285029line216" style="color: black; font-weight: bold; text-decoration: underline;">kexi/widget/KexiFileWidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KexiFileWidget::updateFilters()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">200</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1">//! @todo hardcoded for MSA:</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">204</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1">//! @todo hardcoded for MSA:</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">??</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll remove this outdated comment.</pre>
<br />
<p>- Jarosław</p>
<br />
<p>On June 27th, 2014, 11:08 p.m. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, harshita mistry, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated June 27, 2014, 11:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Show all possible file extensions in the file widget of database importer
The extensions are grabbed from meta data of available migration plugins supporting files.
This way, list of extensions no longer have to be hard-coded.
With coming ODB import, this is a need.
To make it all possible, migration lib no longer uses keximain, it's the other way around.
By the way, properly clear error status in migrate manager so previous failures do not affect result of further imports.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extenstions show properly</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/core/KexiMainWindowIface.h <span style="color: grey">(4ffd111fb321194380ca1a4088a8138971eb1eda)</span></li>
<li>kexi/core/KexiMigrateManagerInterface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/main/CMakeLists.txt <span style="color: grey">(e08981a9c72ff5371904efa3945fb86925447636)</span></li>
<li>kexi/main/KexiMainWindow.h <span style="color: grey">(a8f643ee01c7eb2659e09f78e48aa6b9be3337de)</span></li>
<li>kexi/main/KexiMainWindow.cpp <span style="color: grey">(9f0127d1acec8c1b2f9baf8facbcde1a36be3375)</span></li>
<li>kexi/main/KexiMainWindow_p.h <span style="color: grey">(9e1fd7d0337472d1e9b309c9810fbb4faf44d833)</span></li>
<li>kexi/migration/CMakeLists.txt <span style="color: grey">(2478b103ce31a561fa716473725655dce8719516)</span></li>
<li>kexi/migration/importtablewizard.cpp <span style="color: grey">(219adac5d13d230e83ecb5490d274a355789e110)</span></li>
<li>kexi/migration/migratemanager.h <span style="color: grey">(967c1baa9ae49fabd0d4a1e775afa69e30801e87)</span></li>
<li>kexi/migration/migratemanager.cpp <span style="color: grey">(92a8877b31e388777d1e9b0096f1b83cabb2238a)</span></li>
<li>kexi/widget/KexiFileWidget.cpp <span style="color: grey">(86e472b5a7f64ba0aba0a6ea30b80616d2d2b99e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118986/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>