<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118984/">https://git.reviewboard.kde.org/r/118984/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 29th, 2014, 4:45 a.m. UTC, <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In general looks good. But shouldn't the same idea be used in the other apps too?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's something that is going away in the mvc branch in any case.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On June 27th, 2014, 10:25 p.m. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated June 27, 2014, 10:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KoPart argument of KoDocument and descendants should not be optional
Currently KoPart is required, there is even assertion for, so express this in the API.
Current API apparently caused one crash (in spreadsheet plugin of Kexi).
Also put 2 more assertions as early as possible.
Finally, fixed outdated docs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, nobody is used the argument-less constructor (after https://git.reviewboard.kde.org/r/118983/ is pushed)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sheets/DocBase.h <span style="color: grey">(946e9cd9bdbf414430bd7914bc6bb5bf3e57c3df)</span></li>
<li>sheets/DocBase.cpp <span style="color: grey">(b01a2004c15d2a03201e527af3ac3255f8c75646)</span></li>
<li>sheets/part/Doc.h <span style="color: grey">(bf8341cafd0f6f79668870043af1169ce76df0ca)</span></li>
<li>sheets/part/Doc.cpp <span style="color: grey">(44fd7ab5e237676296a28590e938a01669f0bb86)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118984/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>