<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118541/">https://git.reviewboard.kde.org/r/118541/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Sven Langkamp.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 5, 2014, 5:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As I now and then try to view ODT documents directly in KDevelop... I wanted better support. Given that Calligra parts are no longer KPart-based, and writing a sublime-MVC-based plugin for KDevelop (like done with Okteta) would take some time, having a plugin for Okular (KPart) seems like a quick and generally nice solution.
Picked up some old work of slangkamp for another generator plugin for Okular which support ODT. Also added desktop files to extend support for DOC and DOCX (like done with PPT/PPTX). Could be extended for other doc formats for which there are 2odt/words filters, but first would like to see how this is accepted.
((Somehow I still think Okular should be part of Calligra, given the overlap of problem/solution space... but well :) ))
Used pattern OKULAR_GENERATOR_* to already match the pattern used in proposal in r118510.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could view DOC and DOCX files in Okular, as well as had better ODT display (Okular's native ODT support is not that good).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(256d810)</span></li>
<li>cmake/productsets/all.cmake <span style="color: grey">(778f9c0)</span></li>
<li>cmake/productsets/desktop.cmake <span style="color: grey">(97ff7e8)</span></li>
<li>extras/CMakeLists.txt <span style="color: grey">(e603883)</span></li>
<li>extras/okularodtgenerator/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>extras/okularodtgenerator/OkularOdtGenerator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>extras/okularodtgenerator/OkularOdtGenerator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>extras/okularodtgenerator/libokularGenerator_odt.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>extras/okularodtgenerator/okularApplication_odt.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>extras/okularodtgenerator/okularOdt.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/docx/import/CMakeLists.txt <span style="color: grey">(036e828)</span></li>
<li>filters/words/docx/import/libokularGenerator_docx_calligra.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/docx/import/okularApplication_docx_calligra.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/docx/import/okularDocx_calligra.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/msword-odf/CMakeLists.txt <span style="color: grey">(8342552)</span></li>
<li>filters/words/msword-odf/libokularGenerator_doc_calligra.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/msword-odf/okularApplication_doc_calligra.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/msword-odf/okularDoc_calligra.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118541/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>