<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118517/">https://git.reviewboard.kde.org/r/118517/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi, Juan!
Your patch gives quite interesting results, I like the effect! But there are at least two bugs right now:
http://wstaw.org/m/2014/06/04/plasma-desktopdI1303.png
1) When you release the mouse button, the curve jumps to a random direction. Well, it might be not random, it is just tracing the trajectory which the mouse did in the background. In the attached screenshot, I painted a circle and the curve at the top appeared when I released the button.
2) With four smoothing algorithms the Tool Options docker became too wide to fit usual panel size and scrollbars appeared. We need to invent a better UI for switching the smoothing engines. You can also see it in the attached screenshot.
</pre>
<br />
<p>- Dmitry Kazakov</p>
<br />
<p>On June 4th, 2014, 11:13 a.m. UTC, Juan Luis Boya García wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Dmitry Kazakov, Sven Langkamp, and Boudewijn Rempt.</div>
<div>By Juan Luis Boya García.</div>
<p style="color: grey;"><i>Updated June 4, 2014, 11:13 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This commit adds to calligra a new stabilizer feature as an alternative
to the current "Weigthed smoothing".
This stabilizer is very simple, calculating an arithmetic mean of the
last N values (position, pressure and tilt) each millisecond and drawing
a line from the previous point to there.
This takes into account both the length of the strokes and the speed
they are made with.
Fast and small movements are considered erratic and are likely to be
ignored yielding a mostly straight line.
On the other hand, slower and bigger movements are assumed to be
deliberated and will follow the shape the user draws. The slower and
bigger, the more accurate.
This process makes the strokes draw 'slowly'. The user sees how the line
pursues their cursor. The effect is harder or softer depending on the N
chosen (sample size), which is user-customizable.
Starting and end points are forced by the algorithm to be drawn exactly
where the user began and ended the line.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/tools/defaulttools/kis_tool_brush.cc <span style="color: grey">(ceab3d8)</span></li>
<li>krita/ui/tool/kis_smoothing_options.h <span style="color: grey">(f2d5388)</span></li>
<li>krita/ui/tool/kis_tool_freehand_helper.h <span style="color: grey">(ee49086)</span></li>
<li>krita/ui/tool/kis_tool_freehand_helper.cpp <span style="color: grey">(aae08f1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118517/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>