<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118028/">https://git.reviewboard.kde.org/r/118028/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Sven Langkamp</p>
<br />
<p>On May 6th, 2014, 11:04 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Sven Langkamp.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated May 6, 2014, 11:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It was found (by missing deps in OpenSUSE packages) that Okular crashes (for some yet to be investigated reason) if the Calligra Okular ODP plugin is installed, but not the Stage part.
This patch notes this runtime dependency in the README.PACKAGERS.
It also splits the definition of the PPT and PPTX support into separate desktop files, only installed if the needed filters are also built.
Possibly should be also backported to 2.8</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a32d6b4)</span></li>
<li>README.PACKAGERS <span style="color: grey">(2a686d6)</span></li>
<li>cmake/productsets/all.cmake <span style="color: grey">(8e82b40)</span></li>
<li>cmake/productsets/desktop.cmake <span style="color: grey">(4e85bc8)</span></li>
<li>extras/okularodpgenerator/libokularGenerator_odp.desktop <span style="color: grey">(964bf21)</span></li>
<li>extras/okularodpgenerator/okularApplication_odp.desktop <span style="color: grey">(788825e)</span></li>
<li>extras/okularodpgenerator/okularOdp.desktop <span style="color: grey">(7b1a8d3)</span></li>
<li>filters/stage/powerpoint/CMakeLists.txt <span style="color: grey">(8d7df54)</span></li>
<li>filters/stage/powerpoint/libokularGenerator_powerpoint_calligra.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/powerpoint/okularApplication_powerpoint_calligra.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/powerpoint/okularPowerpoint_calligra.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/pptx/CMakeLists.txt <span style="color: grey">(9a07c37)</span></li>
<li>filters/stage/pptx/libokularGenerator_pptx_calligra.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/pptx/okularApplication_pptx_calligra.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/pptx/okularPptx_calligra.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118028/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>