<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118067/">https://git.reviewboard.kde.org/r/118067/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good progress.
1. Please apply this coding style (especially 4 spaces for indentation, no tabs): http://techbase.kde.org/Policies/Kdelibs_Coding_Style
2. You can skip the a.out and helloWorld.class binaries in the next patch.
3. I propose put the code in OdbMigrate.cpp and start implementing the KexiMigrate interface.
4. Qt should be used everywhere in C++, except naturally the JNI calls: QString for unicode, kDebug and kWarning for debugging, etc.
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118067/diff/1/?file=272281#file272281line41" style="color: black; font-weight: bold; text-decoration: underline;">kexi/migration/odb/cppWithJni/cppPrg.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">midMain</span> <span class="o">=</span> <span class="n">env</span><span class="o">-></span><span class="n">GetStaticMethodID</span><span class="p">(</span><span class="n">clsH</span><span class="p">,</span> <span class="s">"main"</span><span class="p">,</span> <span class="s">"([Ljava/lang/String;)V"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, we need to call method with at least one arg (path to the .odb file) and the method should return bool.
In fact we want to be able to ask the java-based reader about error message (string).
Also we want to set a number of migrate driver's C++ methods that call the reader's methods so the actual schema and data is created by the driver. Please add a plan for that at http://community.kde.org/Kexi/Junior_Jobs/Add_support_for_importing_tables_from_LibreOffice_Base#Development
For example, the C++ driver calls a getTableNames() Java method from implementation of KexiMigrate::drv_tableNames() and returns the result.
We always need to check the result of calling.
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118067/diff/1/?file=272281#file272281line46" style="color: black; font-weight: bold; text-decoration: underline;">kexi/migration/odb/cppWithJni/cppPrg.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">missing return with failure here</pre>
</div>
<br />
<p>- Jarosław Staniek</p>
<br />
<p>On May 10th, 2014, 12:46 a.m. UTC, harshita mistry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By harshita mistry.</div>
<p style="color: grey;"><i>Updated May 10, 2014, 12:46 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A cpp program with jni that calls a java program.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/migration/odb/cppWithJni/helloWorld.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/migration/odb/cppWithJni/helloWorld.class <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/migration/odb/cppWithJni/cppPrg.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/migration/odb/cppWithJni/a.out <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118067/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>