<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117937/">https://git.reviewboard.kde.org/r/117937/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit f6ca90eb379e651c0f1689294b01e5e3bb0c1b3f by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On May 1st, 2014, 10:36 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated May 1, 2014, 10:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The Ok & Cancel buttons in the Krita filter dialog are not following the standards, also will not adapt to different Cancel/Ok order on other platforms (e.g. Gnome OS). Also are some margins hardcoded to certain random pixel sizes, which is a problem on HiDPI screens and with styles where those margins do not match the built-in ones.
These two patches remove some hard-coded margins, use a QButtonBox for the Ok and Cancel buttons and also some ";" to labels where they are missing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/filters/blur/wdg_motion_blur.ui <span style="color: grey">(5377ccf)</span></li>
<li>krita/plugins/filters/blur/wdg_lens_blur.ui <span style="color: grey">(e7daea4)</span></li>
<li>krita/plugins/filters/blur/wdg_gaussian_blur.ui <span style="color: grey">(728f608)</span></li>
<li>krita/plugins/filters/colorsfilters/kis_hsv_adjustment_filter.cpp <span style="color: grey">(85f476c)</span></li>
<li>krita/ui/dialogs/kis_dlg_filter.cpp <span style="color: grey">(4fd86ca)</span></li>
<li>krita/ui/forms/wdgfilterdialog.ui <span style="color: grey">(7a1e3c6)</span></li>
<li>krita/ui/forms/wdgfilterselector.ui <span style="color: grey">(c9d87c7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117937/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/01/cbb4ea9c-90a8-4b0d-90e0-febdca546f98__filterdialogafter.png">After, by example of levels filter</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/01/9dd88e38-8a3f-4ab5-aced-ecad20d887db__filterdialogbefore.png">Before, by example of levels filter</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>