<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117709/">https://git.reviewboard.kde.org/r/117709/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 65f6d4f1f2480580cd6788b8f3e1417817294555 by Jaroslaw Staniek to branch calligra/2.8.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On April 23rd, 2014, 4:01 p.m. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated April 23, 2014, 4:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=333548">333548</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=333549">333549</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make setting solid and inherited background color possible in form widgets. "autoFillBackgound" has been property re-enabled for this; it's set to true when user selects background color.
This patch also contains bits for reloading the property set what's handy for the affected properties but not critical. More investigation on another level is needed to finish this.
"autoFillBackgound" is not i18n'd but not a big deal - this will be added for 2.9.0.
A fix for 2.8.3: it's better to have it now and allow users to properly format their forms earlier than later.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Forms with colorful labels/frames work, changes save/load OK</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/formeditor/form.cpp <span style="color: grey">(efdd2309ec76494014e8d096f16d5783195a5b29)</span></li>
<li>kexi/formeditor/formIO.cpp <span style="color: grey">(e307c843c2f485d43eb4777200fec2e4a2ec6c91)</span></li>
<li>kexi/formeditor/widgetlibrary.cpp <span style="color: grey">(e0b34c4815ee44002ebccd889f1f48abda739f13)</span></li>
<li>kexi/plugins/forms/kexidbfactory.h <span style="color: grey">(a8b2a7e5dca2b2484bac03eab0d28d7a780c3e59)</span></li>
<li>kexi/plugins/forms/kexidbfactory.cpp <span style="color: grey">(94786a006fb6d6def32b43b28ca048811bd00a82)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117709/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>