<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117790/">https://git.reviewboard.kde.org/r/117790/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">0. Please update the patch based on current calligra master, in one place it doesn't apply cleanly (because of my commit that appeared in the meantime).
1. If this is removal of all traces of Q3, I see 4 lines in widget/relations/ where Q3 is still present.
2. It seems that earlier part of the port to Qt4 isn't complete. Only if I click on header, slotTableViewGotFocus() gets called. If I click on the contents of the QListView, the focus pointer is not transferred so right click does not work at all initially unless I click on one of the table headers.
3. When the context menu finally shows (see 2.) its position is mapped to global coordinates, so appears in wrong place. The pos has to be mapped.</pre>
<br />
<p>- Jarosław Staniek</p>
<br />
<p>On April 26th, 2014, 3:18 p.m. UTC, Adam Pigg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated April 26, 2014, 3:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port the relation widget away from q3 support
Set the context Menu policy of the listview widget to Qt::Custom, and use the QWidget customContextMenu event.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Checked compiles and that the context menu event is triggered</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/widget/relations/CMakeLists.txt <span style="color: grey">(264a1420643009d872e2bb259ea42c98e9de348e)</span></li>
<li>kexi/widget/relations/KexiRelationsConnection.cpp <span style="color: grey">(3e8f0c7d1a95473e4ba0a76471fc9b751f54a499)</span></li>
<li>kexi/widget/relations/KexiRelationsScrollArea.cpp <span style="color: grey">(0512b3bd5a047950eca9099bf74b8b5530321bae)</span></li>
<li>kexi/widget/relations/KexiRelationsTableContainer.h <span style="color: grey">(2b48c39ed41c7e7abd267a56223811affd53c443)</span></li>
<li>kexi/widget/relations/KexiRelationsTableContainer.cpp <span style="color: grey">(e91278f7c51da34a697d0bf514f3414cc356a876)</span></li>
<li>kexi/widget/relations/KexiRelationsTableContainer_p.cpp <span style="color: grey">(a90d0972e25c7f9c45d4839103637abaf2356959)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117790/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>