<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117790/">https://git.reviewboard.kde.org/r/117790/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/117790/diff/1-2/?file=268463#file268463line125" style="color: black; font-weight: bold; text-decoration: underline;">kexi/widget/relations/KexiRelationsTableContainer.cpp</a>
<span style="font-weight: normal;">
(Diff revisions 1 - 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KexiDB::TableOrQuerySchema* KexiRelationsTableContainer::schema() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">124</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">emit</span> <span class="nf">contextMenuRequest</span><span class="p">(</span><span class="n">mapToGlobal</span><span class="p">(</span><span class="n">p</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Look at why the context menu is moved up:
p is a position in coordinates of d->fieldList. So d->fieldList widget should map to global, not the KexiRelationsTableContainer.</pre>
</div>
<br />
<p>- Jarosław Staniek</p>
<br />
<p>On April 26th, 2014, 7:33 p.m. UTC, Adam Pigg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated April 26, 2014, 7:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed remnants of q3 Emit gotFocus before contsxt menu to ensure correct focus Map the context menu point to global coordinates
Port relation widget away from q3 support</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Checked compiles and that the context menu event is triggered</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/widget/relations/CMakeLists.txt <span style="color: grey">(264a1420643009d872e2bb259ea42c98e9de348e)</span></li>
<li>kexi/widget/relations/KexiRelationsConnection.cpp <span style="color: grey">(3e8f0c7d1a95473e4ba0a76471fc9b751f54a499)</span></li>
<li>kexi/widget/relations/KexiRelationsScrollArea.cpp <span style="color: grey">(0512b3bd5a047950eca9099bf74b8b5530321bae)</span></li>
<li>kexi/widget/relations/KexiRelationsTableContainer.h <span style="color: grey">(2b48c39ed41c7e7abd267a56223811affd53c443)</span></li>
<li>kexi/widget/relations/KexiRelationsTableContainer.cpp <span style="color: grey">(e91278f7c51da34a697d0bf514f3414cc356a876)</span></li>
<li>kexi/widget/relations/KexiRelationsTableContainer_p.cpp <span style="color: grey">(a90d0972e25c7f9c45d4839103637abaf2356959)</span></li>
<li>kexi/widget/relations/KexiRelationsView.h <span style="color: grey">(c6ee229530bfda6187ed979d40bf9cafb8fd787d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117790/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>