<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117687/">https://git.reviewboard.kde.org/r/117687/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The code looks littered with casts to q3scrollview. Is this intentional? What is the plan for removing them?</pre>
<br />
<p>- Adam Pigg</p>
<br />
<p>On April 22nd, 2014, noon UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Inge Wallin, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated April 22, 2014, noon</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port Kexi Forms to Qt4's scroll area from Qt3's Scroll View. This is a milestone leading to Qt5-based Kexi.
- Removed KexiScrollView which was a complex and not widely used generalization of KexiFormScrollView. Removed functionality goes to KexiFormScrollView.
- Temporarily wrapped TableView in order to keep it functional.
Porting TableView will go next.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Form and Table views work as before</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/core/KexiRecordNavigatorIface.h <span style="color: grey">(bb0c13f3ff92f8dd4b4263c2e59c141ef2406de1)</span></li>
<li>kexi/formeditor/commands.cpp <span style="color: grey">(4a90ab52d90f4c1208896a0bbb32e75f67ca461d)</span></li>
<li>kexi/formeditor/container.cpp <span style="color: grey">(54a6a83fdf5a5b916d85916272ce983774d57c4d)</span></li>
<li>kexi/formeditor/form.h <span style="color: grey">(3dbbe27bdb88ede2c92f9f8d51853b9785d5c63b)</span></li>
<li>kexi/formeditor/form.cpp <span style="color: grey">(ee92e84d99a31c4bfd3262ab3244396d70af0d8c)</span></li>
<li>kexi/formeditor/resizehandle.cpp <span style="color: grey">(b503261d5c9939d00cdec21a78027ded3b3a7f49)</span></li>
<li>kexi/plugins/forms/CMakeLists.txt <span style="color: grey">(972456d857c60237ab7d332c6e90859da4d780e2)</span></li>
<li>kexi/plugins/forms/KexiFormScrollAreaWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/plugins/forms/KexiFormScrollAreaWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/plugins/forms/kexiformpart.h <span style="color: grey">(8d670bd43ccde174c1684445b2519b9cd649c72d)</span></li>
<li>kexi/plugins/forms/kexiformpart.cpp <span style="color: grey">(0cfa59eed4caa46666d250284ebb9503d1ea554e)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.h <span style="color: grey">(fac76070987761c201bb63bc25e7cc2ed32f6b26)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.cpp <span style="color: grey">(d6120cf663f32c32650a429af42c67cbd18613cd)</span></li>
<li>kexi/plugins/forms/kexiformview.h <span style="color: grey">(a58de5e0b82111397852c09a355cf0fd416674b8)</span></li>
<li>kexi/plugins/forms/kexiformview.cpp <span style="color: grey">(5cf7053b6f7027bff1edcd00057c8250928bb182)</span></li>
<li>kexi/plugins/forms/widgets/kexidbform.h <span style="color: grey">(78da95574207ec2db69f07b4ec10905d50ec90cb)</span></li>
<li>kexi/plugins/forms/widgets/kexidbform.cpp <span style="color: grey">(7c6f49c3120748ba36a521188fb170972f229426)</span></li>
<li>kexi/widget/CMakeLists.txt <span style="color: grey">(cf6be390218b4e620719acd4bc5e0c6fb19d1531)</span></li>
<li>kexi/widget/kexiscrollview.h <span style="color: grey">(7c5cc13b72ac0e94f3e242845bfa70ee58c1ab76)</span></li>
<li>kexi/widget/kexiscrollview.cpp <span style="color: grey">(f175f40376c031207c6915c5a736e36ffe383cfb)</span></li>
<li>kexi/widget/tableview/kexitableview.cpp <span style="color: grey">(212011754c748ca1794bb7ff71acb999944f18b3)</span></li>
<li>kexi/widget/utils/kexirecordnavigator.h <span style="color: grey">(afc255e82bd4cc66a2c5079959d95f7b14caa40d)</span></li>
<li>kexi/widget/utils/kexirecordnavigator.cpp <span style="color: grey">(5400578174ad40ceef2ed2fcd287caa951b92dd1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117687/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>