<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116816/">https://git.reviewboard.kde.org/r/116816/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 23rd, 2014, 10:51 p.m. UTC, <b>Yue Liu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">do you still have the gmic clang issue?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On OSX 10.6, yes. But there one could choose to use a recent gcc version.
I cannot test on the intermediate OS versions, but on OS X 10.9 the situation is a bit more complicated. Apple's current clang version ("3.4 svn") compiles gmic.cpp fine, without particular memory requirements. However, clang 3.5 displays the almost same behaviour as clang 3.3 on OS X 10.6: taking the form of very high memory pressure that basically brings the machine down to a point where it requires extreme patience to get the focus back to the controlling terminal window in order to ^C the process.
Might it be a good idea to disable the gmic extension when not using a verified clang version? </pre>
<br />
<p>- RJVB</p>
<br />
<p>On March 16th, 2014, 8:17 a.m. UTC, RJVB Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By RJVB Bertin.</div>
<p style="color: grey;"><i>Updated March 16, 2014, 8:17 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Small modifications for building on Mac OS X against KDE, Qt and other libraries installed through MacPorts installed under /opt/local. MacPorts installs GLEW as a simple dylib in /opt/local/lib, FindGLEW.cmake has been modified accordingly. I installed Vc (not in MacPorts) by hand into /opt/local; the modification to FindVc.cmake is possibly redundant. The modification to kis_opengl_canvas2_p.h enables building on systems that do not have the (optional!) GLEW framework.
Note that gmic.cpp is so huge that clang 3.3 needs almost 20GB memory at some time, and takes an enormous time to compile.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With these modifications the non-packager OSX productset builds correctly on my OS X 10.6.8 system (after also modifying cmake's CMAKE_SHARED_MODULE_CREATE formulas), using the clang-3.3 compiler from MacPorts.
Basic functionality appears correct in all member applications, and 79% of the unittests succeed.
I have not tested my patch to kis_opengl_canvas2_p.h exhaustively as if figured out why GLEW wasn't found shortly after patching the file, but it's a step in the right direction if GLEW is indeed to be an optional dependency.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindGLEW.cmake <span style="color: grey">(adcc452)</span></li>
<li>cmake/modules/FindVc.cmake <span style="color: grey">(bb9823f)</span></li>
<li>krita/ui/opengl/kis_opengl_canvas2_p.h <span style="color: grey">(3b1e369)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116816/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>