<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116889/">https://git.reviewboard.kde.org/r/116889/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 19th, 2014, 2:53 p.m. UTC, <b>Adam Pigg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would it be appropriate to add an example db with this, and an associated test to /test/parser and tests/features?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, we're planning a policy of adding unit/functional tests for all new features. A template would come soon after 2.8.1 I hope. Also for older features. Contributors wanted :)</pre>
<br />
<p>- Jarosław</p>
<br />
<p>On March 18th, 2014, 11:40 p.m. UTC, Radosław Wicik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Jarosław Staniek, Dimitrios Tanis, and Tomasz Olszak.</div>
<div>By Radosław Wicik.</div>
<p style="color: grey;"><i>Updated March 18, 2014, 11:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added 'NOT LIKE' SQL operator support in kexi queries.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested manually with SQLite backend</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/db/parser/sqlscanner.l <span style="color: grey">(9fc2a49755f8c96310a20e398d006273c8db27af)</span></li>
<li>libs/db/parser/sqlparser.y <span style="color: grey">(3b08fe85b9d5d0465310d9c1e5b5d225820fc97c)</span></li>
<li>libs/db/expression.h <span style="color: grey">(a237e7118d1dd7157d3f0245b99074853317f4d3)</span></li>
<li>libs/db/expression.cpp <span style="color: grey">(74a5d717dd4d12588351a781e1452eb5abe17bdb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116889/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>