<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116662/">https://git.reviewboard.kde.org/r/116662/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If leinir doesn't have any more bugs or issues, I'm fine with merging this branc. Nice work!</pre>
<br />
<p>- Inge Wallin</p>
<br />
<p>On March 11th, 2014, 12:06 p.m. UTC, Denis Kuplyakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Inge Wallin and Dan Leinir Turthra Jensen.</div>
<div>By Denis Kuplyakov.</div>
<p style="color: grey;"><i>Updated March 11, 2014, 12:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's the navigator docker for Words. It allow to quickly navigate through document by jumping to sections headers.
Navigator looks through all paragraphs with outline property, and stores them in QTreeView allowing fast jump with single click.
I want some response about UI:
1) maybe make the rows bigger?
and about the implementation:
2) how can we track structure changes more effective to avoid complete rebuilding of tree?
3) view is flickering when updating..</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have tested it on document, containing 3 pages with many headers of different levels.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>words/part/CMakeLists.txt <span style="color: grey">(e6e39e8)</span></li>
<li>words/part/KWFactory.cpp <span style="color: grey">(14dfbed)</span></li>
<li>words/part/dockers/KWNavigationDocker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWNavigationDocker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWNavigationDockerFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWNavigationDockerFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWNavigationWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWNavigationWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116662/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/08/4147a7ee-bb9b-4ff9-b809-fba7c2eb1b16__test.odt">Test file</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>