<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/103476/">https://git.reviewboard.kde.org/r/103476/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Dan Leinir Turthra Jensen.</div>
<p style="color: grey;"><i>Updated March 15, 2014, 8:16 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Refactor out the pseudo-private blocking property in KoPrintingDialog
This is done by implementing a new flag for KoPrintJobs, which will allow the user to decide whether to block the call, and whether or not to show the progress dialog, making the logic inside the startPrintJob function clearer.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Tried to print preview (the original reason for the pseudo-private property)
- Tried to print various documents to PDF
- Tried using adapted version of calligraconverter (which will be uploaded separately) which optionally hides the progress dialog in batch mode
(have no printer at my current location so could not test physical printing)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/kis_print_job.h <span style="color: grey">(387d64b)</span></li>
<li>krita/ui/kis_print_job.cpp <span style="color: grey">(4f33472)</span></li>
<li>libs/kopageapp/KoPAPrintJob.h <span style="color: grey">(057bb46)</span></li>
<li>libs/kopageapp/KoPAPrintJob.cpp <span style="color: grey">(ba069c7)</span></li>
<li>libs/main/KoMainWindow.h <span style="color: grey">(499b186)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(e1c3217)</span></li>
<li>libs/main/KoPrintJob.h <span style="color: grey">(bcbe894)</span></li>
<li>libs/main/KoPrintJob.cpp <span style="color: grey">(ff51adb)</span></li>
<li>libs/main/KoPrintingDialog.h <span style="color: grey">(f486620)</span></li>
<li>libs/main/KoPrintingDialog.cpp <span style="color: grey">(3ed83bd)</span></li>
<li>plan/libs/ui/kptganttview.h <span style="color: grey">(293d54a)</span></li>
<li>plan/libs/ui/kptganttview.cpp <span style="color: grey">(720111b)</span></li>
<li>plan/libs/ui/kptviewbase.h <span style="color: grey">(d3dc51b)</span></li>
<li>plan/libs/ui/kptviewbase.cpp <span style="color: grey">(95cda67)</span></li>
<li>stage/part/KPrPdfPrintJob.h <span style="color: grey">(b53e272)</span></li>
<li>stage/part/KPrPdfPrintJob.cpp <span style="color: grey">(39bdaf9)</span></li>
<li>tables/part/PrintJob.h <span style="color: grey">(93ba0f1)</span></li>
<li>tables/part/PrintJob.cpp <span style="color: grey">(1c6e710)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/103476/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>