<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116611/">https://git.reviewboard.kde.org/r/116611/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have not tested, but reading the diff, it should be ok, except for the following two comments:</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/116611/diff/1/?file=252207#file252207line3" style="color: black; font-weight: bold; text-decoration: underline;">krita/plugins/paintops/libbrush/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">add_definitions</span><span class="p">(</span> <span class="s">-DEIGEN3_SUPPORT</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this look strange, I guess it was intented to be EIGEN2_SUPPORT (there is no EIGEN3_SUPPORT). That said, I would recommend not using EIGEN2_SUPPORT anyway, since there is talk of dropping it in the near future. And since the line is likely wrong, I would suggest to try to remove it.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/116611/diff/1/?file=252212#file252212line1233" style="color: black; font-weight: bold; text-decoration: underline;">sheets/functions/math.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Value func_minverse(valVector args, ValueCalc* calc, FuncExtra*)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1233</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">lu</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">computeInverse</span></span><span class="p"><span class="hl">(</span></span><span class="o"><span class="hl">&</span></span><span class="n">eMatrixInverse</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1233</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">eMatrixInverse</span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">inverse</span></span><span class="p"><span class="hl">(</span>);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This line is wrong, it should be eMatrixInverse = eMatrix.inverse();
and line 1231 with the FullPivLU can be removed.</pre>
</div>
<br />
<p>- Cyrille Berger Skott</p>
<br />
<p>On March 5th, 2014, 12:36 p.m. UTC, Maximiliano Curia wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Maximiliano Curia.</div>
<p style="color: grey;"><i>Updated March 5, 2014, 12:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi,
In Debian eigen2 was removed from the archive, so, this is the patch we are using to support eigen3. The pathch was originaly developed by Anton Gladky, and later modified by the debian calligra maintainers.
Please consider adding it as part of the official calligra.
Happy hacking,</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/tools/selectiontools/kis_tool_select_magnetic.h <span style="color: grey">(d69c6b82845b00bc6e540d5daccafcc9850f4dc5)</span></li>
<li>krita/plugins/tools/selectiontools/kis_tool_select_brush.cc <span style="color: grey">(08cd4efdc071145485abd511885546a63c44390e)</span></li>
<li>krita/plugins/paintops/libbrush/CMakeLists.txt <span style="color: grey">(ac9cd72146eebefe58d20896b63c7d221460d288)</span></li>
<li>krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_triangle.cpp <span style="color: grey">(f2889b866c3d733f8fbc3ac5c93ba94061099b2c)</span></li>
<li>krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_ring.cpp <span style="color: grey">(5f88701aea3eddcf4d3deb5059f91d12cb22fd71)</span></li>
<li>krita/image/tests/kis_paint_information_test.cpp <span style="color: grey">(188103c29add9bb706134ff75ae9e260af5b0de0)</span></li>
<li>krita/image/tests/kis_convolution_painter_test.cpp <span style="color: grey">(d6562dd3aef886d4173ee4f2c18692fc0ae13f82)</span></li>
<li>krita/image/kis_perspective_math.cpp <span style="color: grey">(74566e205244e92627cf84adc1360204028ddeba)</span></li>
<li>krita/CMakeLists.txt <span style="color: grey">(b81e9f41c78291b284e04a613b00ba4d1c8a5191)</span></li>
<li>cmake/modules/FindEigen3.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(f3a193c20c83fe8df737be838d23d9f5247c997c)</span></li>
<li>sheets/CMakeLists.txt <span style="color: grey">(04f213f72a06c32f790c86091d97e19900a70a91)</span></li>
<li>sheets/functions/CMakeLists.txt <span style="color: grey">(ba20613be6ca0c8516f19a6bcb9da861370b098b)</span></li>
<li>sheets/functions/math.cpp <span style="color: grey">(6b475f5dbc4bac22b2f6930ec25e08b302e6abe2)</span></li>
<li>sheets/tests/CMakeLists.txt <span style="color: grey">(0d1d37c09d0415c10133cc5c27dad9b3e9693eb1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116611/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>