<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115537/">https://git.reviewboard.kde.org/r/115537/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 16th, 2014, 9:37 p.m. UTC, <b>Andrius da Costa Ribas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've tried this, but I still get the unneeded extra scrollbars in the example of Bug 330886. Maybe it needs to compensate the extra left margin on Windows?</pre>
</blockquote>
<p>On February 16th, 2014, 10:08 p.m. UTC, <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the review. Needs extra testing on windows. The question for now is whether the patch is an improvement or degradation in general. We have not too much time left.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It just makes no noticeable change on Windows. I think this can go in, it just can't close the bug yet.</pre>
<br />
<p>- Andrius da Costa</p>
<br />
<p>On February 7th, 2014, 1:18 p.m. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2014, 1:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=330885">330885</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=330886">330886</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Misplaced editor in table view's combo box for right alignment
- Scrollbars sometimes appear in combo box popup even when they are not needed
- Minor margin/padding improvements in table view cells
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on related databases</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/widget/tableview/kexicomboboxtableedit.cpp <span style="color: grey">(599660cfb3b470e899fd52bb6c08eba84cd78c6a)</span></li>
<li>kexi/widget/tableview/kexiinputtableedit.h <span style="color: grey">(2ac6ee19f6bb49a00d39043ab7f10c1a0a76e0a4)</span></li>
<li>kexi/widget/tableview/kexiinputtableedit.cpp <span style="color: grey">(61d9d4929bc5ccb903c9024a5658aa2812b3030a)</span></li>
<li>kexi/widget/tableview/kexitableedit.cpp <span style="color: grey">(d67427505468afe4eb9d001c530ed44f72d341f2)</span></li>
<li>kexi/widget/tableview/kexitableview.cpp <span style="color: grey">(4303c3f9fc48ed1986148f1abde3d620c0b83563)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115537/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>