<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115314/">https://git.reviewboard.kde.org/r/115314/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for this work Andrius, and I am sorry for the delay.
We're going to ship it on time for 2.8.0.
As in any work involving formats, we need to be supercareful because mistakes often cannot be fixed due to a requirement of backward compatibility.
I just updated the page Reports Fileformat page and especially the section for <report:page-style> http://community.kde.org/Kexi/Plugins/Reports/Fileformat#.3Creport:page-style.3E
My proposal:
- I noticed there's a legacy text element report:page-style/$TEXT. I explained on the wiki to only have two possible values there: "predefined" and empty.
- Alter the name of the new elements, this leads to better harmonization with ODF 1.2
- Saving should be fixed too: save fo:page-width/fo:page-height even for non-custom page sizes. Also do not save "custom" value of report:page-style/$TEXT.
Example change for custom page size:
CURRENT:
<report:page-style report:custom-page-height="141.732529000000000pt" report:print-orientation="portrait" fo:margin-bottom="28.346505799999999pt" fo:margin-top="28.346505799999999pt" fo:margin-left="19.842554059999991pt" fo:margin-right="28.346505799999999pt" report:custom-page-width="141.732529000000000pt">custom</report:page-style>
EXPECTED, notice lack of text:
<report:page-style report:page-size="Custom" fo:page-height="141.732529000000000pt" report:print-orientation="portrait" fo:margin-bottom="28.346505799999999pt" fo:margin-top="28.346505799999999pt" fo:margin-left="19.842554059999991pt" fo:margin-right="28.346505799999999pt" fo:page-width="141.732529000000000pt"></report:page-style>
Example change for predefined page size A4:
CUSTOM:
<report:grid report:grid-divisions="4" report:grid-snap="1" report:page-unit="cm" report:grid-visible="1"/>
<report:page-style report:print-orientation="portrait" fo:margin-bottom="1.00cm" fo:margin-top="1.00cm" fo:margin-left="1.00cm" fo:margin-right="1.00cm" report:page-size="A4">predefined</report:page-style>
NEW: added fo:page-width, fo:page-height even for A4:
<report:grid report:grid-divisions="4" report:grid-snap="1" report:page-unit="cm" report:grid-visible="1"/>
<report:page-style report:print-orientation="portrait" fo:margin-bottom="1.00cm" fo:margin-top="1.00cm" fo:margin-left="1.00cm" fo:margin-right="1.00cm" report:page-size="A4" fo:page-height="....pt" fo:page-width="....pt">predefined</report:page-style>
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115314/diff/2/?file=240578#file240578line239" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/wrtembed/KoReportDesigner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KoReportDesigner::KoReportDesigner(QWidget *parent, QDomElement data) : QWidget(parent), d(new Private())</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">237</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_pageSize</span><span class="o">-></span><span class="n">setValue</span><span class="p">(</span><span class="n">it</span><span class="p">.</span><span class="n">toElement</span><span class="p">().</span><span class="n">attribute</span><span class="p">(</span><span class="s">"report:page-size"</span><span class="p">,</span> <span class="s">"A4"</span><span class="p">));</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">239</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_pageSize</span><span class="o">-></span><span class="n">setValue</span><span class="p">(</span><span class="n">it</span><span class="p">.</span><span class="n">toElement</span><span class="p">().</span><span class="n">attribute</span><span class="p">(</span><span class="s">"report:page-size"</span><span class="p">,</span> <span class="s">"A4"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Check this value, if it's "Custom" or "" then perform steps for the custom size.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115314/diff/2/?file=240578#file240578line243" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/wrtembed/KoReportDesigner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KoReportDesigner::KoReportDesigner(QWidget *parent, QDomElement data) : QWidget(parent), d(new Private())</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">241</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_customWidth</span><span class="o">-></span><span class="n">setValue</span><span class="p">(</span><span class="n">KoUnit</span><span class="o">::</span><span class="n">parseValue</span><span class="p">(</span><span class="n">it</span><span class="p">.</span><span class="n">toElement</span><span class="p">().</span><span class="n">attribute</span><span class="p">(</span><span class="s">"report:custom-page-widtht"</span><span class="p">,</span> <span class="s">""</span><span class="p">)));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">243</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_customWidth</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KoProperty</span><span class="o">::</span><span class="n">Property</span><span class="p">(</span><span class="s">"custom-page-width"</span><span class="p">,</span> <span class="n">KoUnit</span><span class="o">::</span><span class="n">parseValue</span><span class="p">(</span><span class="n">it</span><span class="p">.</span><span class="n">toElement</span><span class="p">().</span><span class="n">attribute</span><span class="p">(</span><span class="s">"report:custom-page-height"</span><span class="p">,</span> <span class="s">""</span><span class="p">)),</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Custom Width"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Custom Width"</span><span class="p">),</span> <span class="n">KoProperty</span><span class="o">::</span><span class="n">Double</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">custom-page-width -> page-width
report:custom-page-width -> fo:page-width
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115314/diff/2/?file=240578#file240578line244" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/wrtembed/KoReportDesigner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KoReportDesigner::KoReportDesigner(QWidget *parent, QDomElement data) : QWidget(parent), d(new Private())</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">244</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_customHeight</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KoProperty</span><span class="o">::</span><span class="n">Property</span><span class="p">(</span><span class="s">"custom-page-height"</span><span class="p">,</span> <span class="n">KoUnit</span><span class="o">::</span><span class="n">parseValue</span><span class="p">(</span><span class="n">it</span><span class="p">.</span><span class="n">toElement</span><span class="p">().</span><span class="n">attribute</span><span class="p">(</span><span class="s">"report:custom-page-height"</span><span class="p">,</span> <span class="s">""</span><span class="p">)),</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Custom Height"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Custom Height"</span><span class="p">),</span> <span class="n">KoProperty</span><span class="o">::</span><span class="n">Double</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">custom-page-height -> page-height
report:custom-page-height -> fo:page-height
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115314/diff/2/?file=240578#file240578line248" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/wrtembed/KoReportDesigner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KoReportDesigner::KoReportDesigner(QWidget *parent, QDomElement data) : QWidget(parent), d(new Private())</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">248</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_customHeight</span><span class="o">-></span><span class="n">setValue</span><span class="p">(</span><span class="n">KoUnit</span><span class="o">::</span><span class="n">parseValue</span><span class="p">(</span><span class="n">it</span><span class="p">.</span><span class="n">toElement</span><span class="p">().</span><span class="n">attribute</span><span class="p">(</span><span class="s">"report:custom-page-height"</span><span class="p">,</span> <span class="s">""</span><span class="p">)));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">report:custom-page-height -> fo:page-height
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115314/diff/2/?file=240578#file240578line249" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/wrtembed/KoReportDesigner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KoReportDesigner::KoReportDesigner(QWidget *parent, QDomElement data) : QWidget(parent), d(new Private())</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">249</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_customWidth</span><span class="o">-></span><span class="n">setValue</span><span class="p">(</span><span class="n">KoUnit</span><span class="o">::</span><span class="n">parseValue</span><span class="p">(</span><span class="n">it</span><span class="p">.</span><span class="n">toElement</span><span class="p">().</span><span class="n">attribute</span><span class="p">(</span><span class="s">"report:custom-page-width"</span><span class="p">,</span> <span class="s">""</span><span class="p">)));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">report:custom-page-width -> fo:page-width
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115314/diff/2/?file=240578#file240578line703" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/wrtembed/KoReportDesigner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoReportDesigner::slotPropertyChanged(KoProperty::Set &s, KoProperty::Property &p)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">703</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="n">m_set</span><span class="o">-></span><span class="n">property</span><span class="p">(</span><span class="s">"page-size"</span><span class="p">).</span><span class="n">value</span><span class="p">().</span><span class="n">toString</span><span class="p">()</span> <span class="o">==</span> <span class="s">"Custom"</span> <span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please remove spaces:
( foo ) -> (foo)
-here and everywhere</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115314/diff/2/?file=240578#file240578line704" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/wrtembed/KoReportDesigner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoReportDesigner::slotPropertyChanged(KoProperty::Set &s, KoProperty::Property &p)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">704</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_set</span><span class="o">-></span><span class="n">property</span><span class="p">(</span><span class="s">"custom-page-width"</span><span class="p">).</span><span class="n">setOption</span><span class="p">(</span><span class="s">"unit"</span><span class="p">,</span> <span class="n">newstr</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">custom-page-width -> page-width
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115314/diff/2/?file=240578#file240578line705" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/wrtembed/KoReportDesigner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoReportDesigner::slotPropertyChanged(KoProperty::Set &s, KoProperty::Property &p)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">705</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_set</span><span class="o">-></span><span class="n">property</span><span class="p">(</span><span class="s">"custom-page-height"</span><span class="p">).</span><span class="n">setOption</span><span class="p">(</span><span class="s">"unit"</span><span class="p">,</span> <span class="n">newstr</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">custom-page-height -> page-height
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115314/diff/2/?file=240578#file240578line719" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/wrtembed/KoReportDesigner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoReportDesigner::slotPropertyChanged(KoProperty::Set &s, KoProperty::Property &p)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">719</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_customWidth</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KoProperty</span><span class="o">::</span><span class="n">Property</span><span class="p">(</span><span class="s">"custom-page-width"</span><span class="p">,</span> <span class="n">KoUnit</span><span class="p">(</span><span class="n">KoUnit</span><span class="o">::</span><span class="n">Millimeter</span><span class="p">).</span><span class="n">fromUserValue</span><span class="p">(</span><span class="n">width</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Custom Width"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Custom Width"</span><span class="p">),</span> <span class="n">KoProperty</span><span class="o">::</span><span class="n">Double</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">remove "custom-"</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115314/diff/2/?file=240578#file240578line720" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/wrtembed/KoReportDesigner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoReportDesigner::slotPropertyChanged(KoProperty::Set &s, KoProperty::Property &p)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">720</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_customHeight</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KoProperty</span><span class="o">::</span><span class="n">Property</span><span class="p">(</span><span class="s">"custom-page-height"</span><span class="p">,</span> <span class="n">KoUnit</span><span class="p">(</span><span class="n">KoUnit</span><span class="o">::</span><span class="n">Millimeter</span><span class="p">).</span><span class="n">fromUserValue</span><span class="p">(</span><span class="n">height</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Custom Height"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Custom Height"</span><span class="p">),</span> <span class="n">KoProperty</span><span class="o">::</span><span class="n">Double</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">remove "custom-"</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115314/diff/2/?file=240578#file240578line755" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/wrtembed/KoReportDesigner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoReportDesigner::slotPropertyChanged(KoProperty::Set &s, KoProperty::Property &p)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">755</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span class="p">(</span> <span class="p">(</span><span class="n">p</span><span class="p">.</span><span class="n">name</span><span class="p">()</span> <span class="o">==</span> <span class="s">"custom-page-width"</span><span class="p">)</span> <span class="o">||</span> <span class="p">(</span><span class="n">p</span><span class="p">.</span><span class="n">name</span><span class="p">()</span> <span class="o">==</span> <span class="s">"custom-page-height"</span><span class="p">)</span> <span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">remove "custom-" here and below</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115314/diff/2/?file=240578#file240578line853" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/wrtembed/KoReportDesigner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QSize KoReportDesigner::sizeHint() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">853</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">cw</span> <span class="o">=</span> <span class="n">POINT_TO_INCH</span><span class="p">(</span><span class="n">m_set</span><span class="o">-></span><span class="n">property</span><span class="p">(</span><span class="s">"custom-page-width"</span><span class="p">).</span><span class="n">value</span><span class="p">().</span><span class="n">toDouble</span><span class="p">())</span> <span class="o">*</span> <span class="n">KoDpi</span><span class="o">::</span><span class="n">dpiX</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">remove "custom-" here and below</pre>
</div>
<br />
<p>- Jarosław Staniek</p>
<br />
<p>On January 25th, 2014, 8:33 p.m. UTC, Andrius da Costa Ribas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Friedrich W. H. Kossebau, Adam Pigg, and Jarosław Staniek.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2014, 8:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch enables "Custom" sized reports which were not working before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested using MSVC, with both Plan and Kexi reports.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/wrtembed/KoReportDesigner.cpp <span style="color: grey">(7644c1d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115314/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>