<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114193/">http://git.reviewboard.kde.org/r/114193/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 5th, 2013, 8:15 a.m. UTC, <b>Boudewijn Rempt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine on Linux as well. Only two things I'm concerned about:
* adding new 3rd party libraries: we shouldn't unless they are unlikely to be packaged by distributions.
* adding a libary that will be used, but isn't yet -- but maybe I'm missing something here.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I spoke too soon. CMake ran without trouble, but a clean build failed:
...
Generating writeodf.h^M
'RNG2CCP_EXECUTABLE-NOTFOUND' is not recognized as an internal or external command,^M
operable program or batch file.^M
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V110\Microsoft.CppCommon.targets(172,5): error MSB6006: "cmd.exe"
Build FAILED.^M
^M
...
"C:\dev\desktop64\p\vs11\INSTALL.vcxproj" (default target) (1) ->^M
"C:\dev\desktop64\p\vs11\ALL_BUILD.vcxproj" (default target) (2) ->^M
"C:\dev\desktop64\p\vs11\libs\basicflakes\basicflakes.vcxproj" (default target) (18) ->^M
"C:\dev\desktop64\p\vs11\libs\flake\flake.vcxproj" (default target) (20) ->^M
"C:\dev\desktop64\p\vs11\libs\odf\koodf.vcxproj" (default target) (22) ->^M
"C:\dev\desktop64\p\vs11\libs\odf\writeodf\writeodf.h-target.vcxproj" (default target) (24) ->^M
(CustomBuild target) -> ^M
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V110\Microsoft.CppCommon.targets(172,5): error MSB6006: "cmd.exe" exited with code 9009. [C:\dev\desktop64\p\vs11\libs\odf\writeodf\writeodf.h-target.vcxproj]^M
^M
0 Warning(s)^M
1 Error(s)^M
^M
Time Elapsed 00:00:11.03^M
Though that might be Xiluembo's earlier commit, not a problem in this branch. Is master fully merged?
</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On December 4th, 2013, 6:09 p.m. UTC, Yue Liu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Yue Liu.</div>
<p style="color: grey;"><i>Updated Dec. 4, 2013, 6:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use LibFindMacros.cmake to simplify package finding, fixed FindFFTW3, FindLIBWPD, FINDLIBWPG on mac, and some other mac fixes.
Added dependency libodfgen and future dependency libetonyek, deleteed writerperfet code.
To test the patch, just checkout branch cmake-fix-osx-yue</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works on OSX 10.9, and Arch Linux. Please check if the FindXXX changes work on windows.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(6587ecc)</span></li>
<li>cmake/modules/FindFFTW3.cmake <span style="color: grey">(a4c8997)</span></li>
<li>cmake/modules/FindLibEtonyek.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/modules/FindLibOdfGen.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/modules/FindLibVisio.cmake <span style="color: grey">(69a598a)</span></li>
<li>cmake/modules/FindLibWPS.cmake <span style="color: grey">(e34f382)</span></li>
<li>cmake/modules/FindLibWpd.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/modules/FindLibWpg.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/modules/FindLibWps.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/modules/FindWPD.cmake <span style="color: grey">(0f666b3)</span></li>
<li>cmake/modules/FindWPG.cmake <span style="color: grey">(066e579)</span></li>
<li>cmake/modules/LibFindMacros.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/CMakeLists.txt <span style="color: grey">(ba04b83)</span></li>
<li>filters/flow/CMakeLists.txt <span style="color: grey">(c37d395)</span></li>
<li>filters/flow/visio/import/CMakeLists.txt <span style="color: grey">(55b8488)</span></li>
<li>filters/flow/visio/import/VSDXImport.h <span style="color: grey">(712d9d7)</span></li>
<li>filters/flow/visio/import/VSDXImport.cpp <span style="color: grey">(788379e)</span></li>
<li>filters/flow/wpg/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/flow/wpg/import/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/flow/wpg/import/WPGImport.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/flow/wpg/import/WPGImport.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/flow/wpg/import/calligra_filter_wpg2odg.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/flow/wpg/import/flow_wpg_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/wpg/CMakeLists.txt <span style="color: grey">(e8600a0)</span></li>
<li>filters/libodfhandler/DiskDocumentHandler.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfhandler/DiskDocumentHandler.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfhandler/FemtoZip.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfhandler/FemtoZip.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfhandler/OutputFileHelper.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfhandler/OutputFileHelper.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfhandler/StdOutHandler.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfhandler/StdOutHandler.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/wordperfect/import/CMakeLists.txt <span style="color: grey">(cbcf650)</span></li>
<li>filters/words/wordperfect/import/WPDImport.h <span style="color: grey">(ad515f7)</span></li>
<li>filters/words/wordperfect/import/WPDImport.cpp <span style="color: grey">(e3b2c2c)</span></li>
<li>filters/words/works/import/CMakeLists.txt <span style="color: grey">(082cb31)</span></li>
<li>filters/words/works/import/WPSImport.h <span style="color: grey">(2d1b20c)</span></li>
<li>filters/words/works/import/WPSImport.cpp <span style="color: grey">(e52d5b5)</span></li>
<li>filters/writerperfect/CMakeLists.txt <span style="color: grey">(1f57075)</span></li>
<li>filters/writerperfect/DiskDocumentHandler.hxx <span style="color: grey">(7b37ea3)</span></li>
<li>filters/writerperfect/DiskDocumentHandler.cxx <span style="color: grey">(799fdd0)</span></li>
<li>filters/writerperfect/DocumentElement.hxx <span style="color: grey">(5a03977)</span></li>
<li>filters/writerperfect/DocumentElement.cxx <span style="color: grey">(47a9d7e)</span></li>
<li>filters/writerperfect/FemtoZip.hxx <span style="color: grey">(afecf5e)</span></li>
<li>filters/writerperfect/FemtoZip.cxx <span style="color: grey">(c52a707)</span></li>
<li>filters/writerperfect/FilterInternal.hxx <span style="color: grey">(eb2ddf8)</span></li>
<li>filters/writerperfect/FontStyle.hxx <span style="color: grey">(379b9c1)</span></li>
<li>filters/writerperfect/FontStyle.cxx <span style="color: grey">(111b46d)</span></li>
<li>filters/writerperfect/InternalHandler.hxx <span style="color: grey">(9223f1f)</span></li>
<li>filters/writerperfect/InternalHandler.cxx <span style="color: grey">(6ad9142)</span></li>
<li>filters/writerperfect/ListStyle.hxx <span style="color: grey">(94b31f8)</span></li>
<li>filters/writerperfect/ListStyle.cxx <span style="color: grey">(dab5058)</span></li>
<li>filters/writerperfect/OdfDocumentHandler.hxx <span style="color: grey">(d2911a9)</span></li>
<li>filters/writerperfect/OdgGenerator.hxx <span style="color: grey">(7296935)</span></li>
<li>filters/writerperfect/OdgGenerator.cxx <span style="color: grey">(49a3ac3)</span></li>
<li>filters/writerperfect/OdtGenerator.hxx <span style="color: grey">(425143d)</span></li>
<li>filters/writerperfect/OdtGenerator.cxx <span style="color: grey">(bbcdc5c)</span></li>
<li>filters/writerperfect/OutputFileHelper.hxx <span style="color: grey">(48023b1)</span></li>
<li>filters/writerperfect/OutputFileHelper.cxx <span style="color: grey">(22a1895)</span></li>
<li>filters/writerperfect/PageSpan.hxx <span style="color: grey">(64c7053)</span></li>
<li>filters/writerperfect/PageSpan.cxx <span style="color: grey">(c64a1dd)</span></li>
<li>filters/writerperfect/SectionStyle.hxx <span style="color: grey">(bb52a55)</span></li>
<li>filters/writerperfect/SectionStyle.cxx <span style="color: grey">(2e5d352)</span></li>
<li>filters/writerperfect/StdOutHandler.hxx <span style="color: grey">(de5d402)</span></li>
<li>filters/writerperfect/StdOutHandler.cxx <span style="color: grey">(f8175f2)</span></li>
<li>filters/writerperfect/Style.hxx <span style="color: grey">(2682b24)</span></li>
<li>filters/writerperfect/TableStyle.hxx <span style="color: grey">(bcd45a5)</span></li>
<li>filters/writerperfect/TableStyle.cxx <span style="color: grey">(1b99b6e)</span></li>
<li>filters/writerperfect/TextRunStyle.hxx <span style="color: grey">(63c297d)</span></li>
<li>filters/writerperfect/TextRunStyle.cxx <span style="color: grey">(e34b2dd)</span></li>
<li>filters/writerperfect/WriterProperties.hxx <span style="color: grey">(8b61b65)</span></li>
<li>krita/image/CMakeLists.txt <span style="color: grey">(da1102c)</span></li>
<li>krita/image/kis_assert.cpp <span style="color: grey">(17a85f8)</span></li>
<li>krita/plugins/extensions/gmic/CMakeLists.txt <span style="color: grey">(15291af)</span></li>
<li>libs/main/KoDocument.cpp <span style="color: grey">(0a17961)</span></li>
<li>libs/widgets/KoEditColorSetDialog.cpp <span style="color: grey">(d683bcc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114193/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>