<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110821/">http://git.reviewboard.kde.org/r/110821/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 19th, 2013, 2 p.m. UTC, <b>Boudewijn Rempt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I now get a crash when trying to paste into a text shape in Krita:
Thread 1 (Thread 0x7f16749697c0 (LWP 20528)):
[KCrash Handler]
#5 KoShapeController::resourceManager (this=0x0) at /home/boud/kde/src/calligra/libs/flake/KoShapeController.cpp:193
#6 0x00007f16710d1537 in TextPasteCommand::TextPasteCommand (this=0x3c59b00, mimeData=0x380d1e0, document=0xa80d140, shapeController=0x0, canvas=0x229f4b0, parent=<optimized out>, pasteAsText=false) at /home/boud/kde/src/calligra/libs/kotext/commands/TextPasteCommand.cpp:65
#7 0x00007f1671001380 in paste (pasteAsText=false, mimeData=0x380d1e0, canvas=0x229f4b0, this=0xa80c360) at /home/boud/kde/src/calligra/libs/kotext/KoTextEditor.cpp:613
#8 KoTextEditor::paste (this=0xa80c360, canvas=0x229f4b0, mimeData=0x380d1e0, pasteAsText=false) at /home/boud/kde/src/calligra/libs/kotext/KoTextEditor.cpp:601
#9 0x00007f165c21f402 in TextTool::paste (this=0xa968fc0) at /home/boud/kde/src/calligra/plugins/textshape/TextTool.cpp:1092
#10 0x00007f1670cada70 in KoToolProxy::paste (this=0x6600ba0) at /home/boud/kde/src/calligra/libs/flake/KoToolProxy.cpp:537
#11 0x00007f1673da660c in KisPasteActionFactory::run (this=0x7fffb19377e0, view=0x3c15de0) at /home/boud/kde/src/calligra/krita/ui/actions/kis_selection_action_factories.cpp:306
#12 0x00007f1673c4fa00 in KisSelectionManager::paste (this=0x6c67b70) at /home/boud/kde/src/calligra/krita/ui/kis_selection_manager.cc:365
#13 0x00007f1673c55535 in qt_static_metacall (_id=9, _o=0x6c67b70, _c=<optimized out>, _a=<optimized out>) at /home/boud/kde/build/calligra/krita/ui/kis_selection_manager.moc:108
#14 KisSelectionManager::qt_static_metacall (_o=0x6c67b70, _c=<optimized out>, _id=9, _a=<optimized out>) at /home/boud/kde/build/calligra/krita/ui/kis_selection_manager.moc:93
#15 0x00007f166c66e29f in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) () from /usr/lib64/libQtCore.so.4
#16 0x00007f166d2d8662 in QAction::triggered(bool) () from /usr/lib64/libQtGui.so.4
#17 0x00007f166d2d8850 in QAction::activate(QAction::ActionEvent) () from /usr/lib64/libQtGui.so.4
#18 0x00007f166d2d89b7 in QAction::event(QEvent*) () from /usr/lib64/libQtGui.so.4
#19 0x00007f166df17607 in KAction::event(QEvent*) () from /usr/lib64/libkdeui.so.5
#20 0x00007f166d2de86c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib64/libQtGui.so.4
#21 0x00007f166d2e2ceb in QApplication::notify(QObject*, QEvent*) () from /usr/lib64/libQtGui.so.4
#22 0x00007f16730bf598 in KoApplication::notify (this=<optimized out>, receiver=0xa1ba6b0, event=0x7fffb1937f30) at /home/boud/kde/src/calligra/libs/main/KoApplication.cpp:549
#23 0x00007f166c658d8e in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/lib64/libQtCore.so.4
#24 0x00007f166d30f524 in ?? () from /usr/lib64/libQtGui.so.4
#25 0x00007f166d310b53 in ?? () from /usr/lib64/libQtGui.so.4
#26 0x00007f166d2e47ef in QApplication::notify(QObject*, QEvent*) () from /usr/lib64/libQtGui.so.4
#27 0x00007f16730bf598 in KoApplication::notify (this=<optimized out>, receiver=0x20a1120, event=0x7fffb1938510) at /home/boud/kde/src/calligra/libs/main/KoApplication.cpp:549
#28 0x00007f166c658d8e in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/lib64/libQtCore.so.4
#29 0x00007f166d37ae8a in ?? () from /usr/lib64/libQtGui.so.4
#30 0x00007f166d37b2c1 in ?? () from /usr/lib64/libQtGui.so.4
#31 0x00007f166d3589f8 in QApplication::x11ProcessEvent(_XEvent*) () from /usr/lib64/libQtGui.so.4
#32 0x00007f166d37f9d9 in ?? () from /usr/lib64/libQtGui.so.4
#33 0x00007f166c657adf in QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
#34 0x00007f166c657d68 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
#35 0x00007f166c65ca08 in QCoreApplication::exec() () from /usr/lib64/libQtCore.so.4
#36 0x00007f1674309afa in kdemain (argc=<optimized out>, argv=<optimized out>) at /home/boud/kde/src/calligra/krita/main.cc:99
#37 0x00007f166b4c0a15 in __libc_start_main () from /lib64/libc.so.6
#38 0x00000000004009e1 in _start () at ../sysdeps/x86_64/start.S:123
Before, ctrl-v just worked.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">right thanks, I see this crash in other apps (besides Words) too. Will fix it tonight.</pre>
<br />
<p>- C.</p>
<br />
<p>On November 18th, 2013, 10:04 p.m. UTC, C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Nov. 18, 2013, 10:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pasting of images of text and images was broken, because you could only paste text if the texttool was active, or you could only paste images if the default tool was active.
This patch changes it so that pasting of these things is now handled by toolproxy, so you are able to paste in all cases, unless the active tool consumes the data.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/tests/TestKoTextEditor.h <span style="color: grey">(60fe599)</span></li>
<li>libs/kotext/tests/TestKoTextEditor.cpp <span style="color: grey">(75fa075)</span></li>
<li>plugins/defaultTools/defaulttool/DefaultTool.cpp <span style="color: grey">(68ba881)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(96294a0)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(b299234)</span></li>
<li>libs/flake/KoShapeAnchor.cpp <span style="color: grey">(83087c3)</span></li>
<li>libs/flake/KoShapePaste.cpp <span style="color: grey">(1457daf)</span></li>
<li>libs/flake/KoToolProxy.cpp <span style="color: grey">(634a1ed)</span></li>
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(9fd3c05)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(40ac427)</span></li>
<li>libs/kotext/KoTextPaste.h <span style="color: grey">(522ccce)</span></li>
<li>libs/kotext/KoTextPaste.cpp <span style="color: grey">(2304d6a)</span></li>
<li>libs/kotext/commands/ChangeTrackedDeleteCommand.cpp <span style="color: grey">(044fd27)</span></li>
<li>libs/kotext/commands/TextPasteCommand.h <span style="color: grey">(77d710a)</span></li>
<li>libs/kotext/commands/TextPasteCommand.cpp <span style="color: grey">(34ea25c)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(7831109)</span></li>
<li>libs/kotext/opendocument/KoTextSharedLoadingData.h <span style="color: grey">(5ebb7a1)</span></li>
<li>libs/kotext/opendocument/KoTextSharedLoadingData.cpp <span style="color: grey">(d9a73e9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110821/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>