<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113784/">http://git.reviewboard.kde.org/r/113784/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Cyrille Berger Skott and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2013, 3:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looking into why libs-pigment-TestKoColor failed I saw that I failed on
QFATAL : TestKoColor::testChannelsInfo() ASSERT: "cs->profile()->name() == profileName" in file /home/koder/Kode/kdegit/Calligra/calligra/libs/pigment/KoColorSpaceRegistry.cpp, line 355
for all the LCMS2 XYZ colorspaces.
The default profile name was always "XYZ built-in - (lcms internal)", where cs->profile()->name() was "XYZ identity built-in".
Looking at https://github.com/mm2/Little-CMS/blob/master/src/cmsvirt.c I saw that there "XYZ identity built-in" is used, and seems to have done so for some years. This pattern also matches the naming expected of the other LCMS colorspaces in plugins/colorengines/lcms2, so I just assumed that XYZ might have been forgotten in the port to LCMS2 and did the attached patch, which made libs-pigment-TestKoColor pass without an error.
No real clue if this is a proper patch, so passing on to you, Cyrille and Boud (and who else?). Correct fix?
PS:
No idea why libs-pigment-TestKoColorSpaceSanity still fails on , left for you as well :)
For XYZAF32 this assert triggers:
QFATAL : TestKoColorSpaceSanity::testChannelsInfo() ASSERT: "profileIsCompatible(p)" in file /home/koder/Kode/kdegit/Calligra/calligra/plugins/colorengines/lcms2/LcmsColorSpace.h, line 171
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/colorengines/lcms2/LcmsEnginePlugin.cpp <span style="color: grey">(fb9c5a1)</span></li>
<li>plugins/colorengines/lcms2/colorspaces/xyz_f16/XyzF16ColorSpace.h <span style="color: grey">(bd3dd1d)</span></li>
<li>plugins/colorengines/lcms2/colorspaces/xyz_f32/XyzF32ColorSpace.h <span style="color: grey">(62c777f)</span></li>
<li>plugins/colorengines/lcms2/colorspaces/xyz_u16/XyzU16ColorSpace.h <span style="color: grey">(402ca79)</span></li>
<li>plugins/colorengines/lcms2/colorspaces/xyz_u8/XyzU8ColorSpace.h <span style="color: grey">(7c77b51)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113784/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>