<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109907/">http://git.reviewboard.kde.org/r/109907/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In my work I use to save documents. In remote (sftp) places because I have not much disk in my local machine. This is not possible using native win dialog. IMHO this should be a configurable setting, as it is with KDE4 in general (not sure how this is working on KF5)</pre>
<br />
<p>- Andrius da Costa Ribas</p>
<br />
<p>On October 1st, 2013, 10:38 p.m. UTC, Yue Liu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Yue Liu.</div>
<p style="color: grey;"><i>Updated Oct. 1, 2013, 10:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently kfiledialog and kofiledialog is widely used, this results in non-native file dialog on Mac/Windows/Gnome. However, qfiledialog static methods does not support modal sheet in Mac, so a KoModalFileDialog is created for window-modal file dialog, such as save as or import, while other file dialog such as open will use qfiledialog static methods.
This is a very first version which blocks save as encrypted since encrypted odf has same suffix as normal odf while when using native dialog you have to use suffix to distinguish different format. My idea is to create another menu item "Save As Encrypted..." where encrypted odf will be saved.
There are still many file dialogs not touched yet, and for places where kfilewidget is used, such as startup file open widget, kexi file widget, export to pdf widget, it is impossible to use native dialog. My idea is redesign those widget and split the configure part and file chooser part into two separate dialogs, then use native file dialogs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine on OS X 10.8</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>flow/part/flow.rc <span style="color: grey">(f6fa60a)</span></li>
<li>krita/plugins/extensions/bigbrother/bigbrother.cc <span style="color: grey">(5ba4ac5)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(3a9110c)</span></li>
<li>libs/main/KoDetailsPaneBase.ui <span style="color: grey">(d692a00)</span></li>
<li>libs/main/KoExistingDocumentPane.h <span style="color: grey">(fd7b4fd)</span></li>
<li>libs/main/KoExistingDocumentPane.cpp <span style="color: grey">(2ea6746)</span></li>
<li>libs/main/KoFileDialog.h <span style="color: grey">(da94281)</span></li>
<li>libs/main/KoFileDialog.cpp <span style="color: grey">(c5a7fc2)</span></li>
<li>libs/main/KoFileDialogHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/KoFileDialogHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/KoMainWindow.h <span style="color: grey">(1b3503f)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(10cef0e)</span></li>
<li>libs/main/KoOpenPane.h <span style="color: grey">(4e9ac13)</span></li>
<li>libs/main/KoOpenPane.cpp <span style="color: grey">(53d4b48)</span></li>
<li>libs/main/KoOpenPaneBase.ui <span style="color: grey">(0b2f2cf)</span></li>
<li>plan/workpackage/application.cpp <span style="color: grey">(b3642d6)</span></li>
<li>sheets/dialogs/CSVDialog.h <span style="color: grey">(0763538)</span></li>
<li>sheets/dialogs/CSVDialog.cpp <span style="color: grey">(4d6a19d)</span></li>
<li>sheets/sheets.rc <span style="color: grey">(76439c0)</span></li>
<li>stage/part/stage.rc <span style="color: grey">(2dba463)</span></li>
<li>stage/stage.rc <span style="color: grey">(d0b912f)</span></li>
<li>stage/stage_only.rc <span style="color: grey">(73c743b)</span></li>
<li>words/part/author/author.rc <span style="color: grey">(b5567f5)</span></li>
<li>words/part/words.rc <span style="color: grey">(31cabbd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109907/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/08/Screen_Shot_2013-04-07_at_11.54.47_PM.png">save as dialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>