<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112573/">http://git.reviewboard.kde.org/r/112573/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">9611fc67fa4e4dca4d151a3e9c801bbb9ce72c90 was done under the assumption that KoParts are now only used in the respective applications.
But that missed a few cases, grepping for createKoPart lists those:
* thumbnailer
* Okular ODP plugin
* calligraconverter
The attached patch tries to fix that by not simply using the appname in KoServiceProvider::readNativeService(), but demanding that the component is passed. That way each place which uses KoServiceProvider can precisely define what context should be used.
Not perfect, perhaps an issue for the Qt5 port?
But at least it seems to fix the problem with the thumbnailer for me: now when it tries to generate the KoPart to render the thumbnail no longer the assert in KoServiceProvider is hit and I get thumbnails rendered again for all kind of documents we support, including kra and ora files.
And the apps seem to still work as before.
Not sure about the solution with KisDlgFileLayer, for most simple code changes I just passed the view as another member, instead of e.g. creating the mimefilterlist callee side. Left to decide for you, Boud, what best to do there.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=323489">323489</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/main/KoVersionDialog.cpp <span style="color: grey">(2f38510)</span></li>
<li>libs/main/KoServiceProvider.cpp <span style="color: grey">(e6ab77c)</span></li>
<li>libs/main/KoPart.cpp <span style="color: grey">(56e27b5)</span></li>
<li>libs/main/KoServiceProvider.h <span style="color: grey">(35ca3ac)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(26327aa)</span></li>
<li>libs/main/KoDocument.cpp <span style="color: grey">(622678f)</span></li>
<li>libs/main/KoApplication.cpp <span style="color: grey">(7421107)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(2e6400c)</span></li>
<li>krita/ui/widgets/KisFlipbookSelector.cpp <span style="color: grey">(09425fb)</span></li>
<li>krita/ui/dialogs/kis_dlg_file_layer.cpp <span style="color: grey">(46abb0a)</span></li>
<li>krita/ui/dialogs/kis_dlg_file_layer.h <span style="color: grey">(cb4dbe0)</span></li>
<li>krita/plugins/extensions/dockers/flipbook/flipbookdocker_dock.cpp <span style="color: grey">(49cf62a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112573/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>