<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112405/">http://git.reviewboard.kde.org/r/112405/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 47d5f65eb3519b604d5d275a324bb4203c3feb33 by Dmitry Kazakov to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 31st, 2013, 3:52 p.m. UTC, Dmitry Kazakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Dmitry Kazakov.</div>
<p style="color: grey;"><i>Updated Aug. 31, 2013, 3:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds three protected methods for ending and canceling creation of the path in KoCreatePathTool. These protected methods are later used in the derived classes in Krita. This patch is necessary for fixing the path-finishing bugs in Krita.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested in Krita</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=322328">https://bugs.kde.org/show_bug.cgi?id=322328</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/tools/defaulttools/kis_tool_path.h <span style="color: grey">(55e5c75)</span></li>
<li>krita/plugins/tools/defaulttools/kis_tool_path.cc <span style="color: grey">(709f14f)</span></li>
<li>krita/plugins/tools/selectiontools/kis_tool_select_path.h <span style="color: grey">(9214159)</span></li>
<li>krita/plugins/tools/selectiontools/kis_tool_select_path.cc <span style="color: grey">(7913a71)</span></li>
<li>krita/ui/tool/kis_delegated_tool.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/tool/kis_tool.h <span style="color: grey">(e936d9d)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool.h <span style="color: grey">(101ad4e)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool.cpp <span style="color: grey">(8f0f547)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool_p.h <span style="color: grey">(51f4a8f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112405/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>