<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111747/">http://git.reviewboard.kde.org/r/111747/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here is the first review. I will test the code a bit more. I have committed some fixes already.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111747/diff/3/?file=175416#file175416line415" style="color: black; font-weight: bold; text-decoration: underline;">libs/basicflakes/tools/KoCreatePathTool.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QList<QWidget *> KoCreatePathTool::createOptionWidgets()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">415</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">strokeWidget</span><span class="o">-></span><span class="n">unactivate</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The activate is never called again. Is this correct?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111747/diff/3/?file=175418#file175418line690" style="color: black; font-weight: bold; text-decoration: underline;">libs/flake/KoShape.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">690</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="hl"> </span><span class="n"><span class="hl">virtual</span></span> <span class="n">ChildZOrderPolicy</span> <span class="nf">childZOrderPolicy</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">690</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ChildZOrderPolicy</span> <span class="n">childZOrderPolicy</span><span class="p">()</span><span class="hl"> </span><span class="k"><span class="hl">const</span></span><span class="p">;</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">691</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">692</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="cm">/**</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">693</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Set the kind of policy used during compareShapeZIndex()</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">694</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * @returns the z order policy of this shape</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">695</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> */</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">696</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">setChildZOrderPolicy</span><span class="p">(</span><span class="n">ChildZOrderPolicy</span> <span class="n">policy</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do these changes belong here? It seems to be unrelated.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111747/diff/3/?file=175433#file175433line256" style="color: black; font-weight: bold; text-decoration: underline;">libs/main/KoModeBox.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QIcon KoModeBox::createRotatedIcon(const KoToolButton button)</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QIcon KoModeBox::createTextedIcon(const KoToolButton button)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">195</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QIcon</span> <span class="n">KoModeBox</span><span class="o">::</span><span class="n">create<span class="hl">Rota</span>tedIcon</span><span class="p">(</span><span class="k">const</span> <span class="n">KoToolButton</span> <span class="n">button</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">253</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QIcon</span> <span class="n">KoModeBox</span><span class="o">::</span><span class="n">create<span class="hl">Tex</span>tedIcon</span><span class="p">(</span><span class="k">const</span> <span class="n">KoToolButton</span> <span class="n">button</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">shoudn't this be renamed to createdTextIcon?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111747/diff/3/?file=175439#file175439line62" style="color: black; font-weight: bold; text-decoration: underline;">libs/widgets/KoStrokeConfigWidget.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">62</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">activate</span><span class="p">();</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">unactivate</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moved into one method</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111747/diff/3/?file=175440#file175440line395" style="color: black; font-weight: bold; text-decoration: underline;">libs/widgets/KoStrokeConfigWidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoStrokeConfigWidget::applyChanges()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">376</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">395</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">396</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KoShapeStroke</span> <span class="o">*</span><span class="n">newStroke</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KoShapeStroke</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Who is going to delete the stroke that is emitted here? Looks like a memory leak to me.</pre>
</div>
<br />
<p>- Thorsten</p>
<br />
<p>On July 30th, 2013, 2:48 p.m. UTC, C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated July 30, 2013, 2:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">An earlier version of this patch has already been up for review before, but now is the time to ask for it to be merged</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">just working with it, and fixing the reviews from the earlier review</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>flow/part/FlowView.cpp <span style="color: grey">(b30dbe9)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool.h <span style="color: grey">(101ad4e)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool.cpp <span style="color: grey">(8f0f547)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool_p.h <span style="color: grey">(51f4a8f)</span></li>
<li>libs/flake/KoShape.h <span style="color: grey">(fd3349d)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(30774a8)</span></li>
<li>libs/flake/KoShape_p.h <span style="color: grey">(27ff915)</span></li>
<li>libs/kopageapp/CMakeLists.txt <span style="color: grey">(7cbf340)</span></li>
<li>libs/kopageapp/KoPAView.h <span style="color: grey">(80b9f78)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(bbb068a)</span></li>
<li>libs/kopageapp/tools/backgroundTool/BackgroundToolWidget.ui <span style="color: grey">(937e569)</span></li>
<li>libs/kopageapp/tools/backgroundTool/CMakeLists.txt <span style="color: grey">(339c671)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h <span style="color: grey">(45a240f)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp <span style="color: grey">(69f7649)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.h <span style="color: grey">(cb75621)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp <span style="color: grey">(b803e79)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp <span style="color: grey">(505c3da)</span></li>
<li>libs/kopageapp/widgets/KoPABackgroundFillWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kopageapp/widgets/KoPABackgroundFillWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/KoModeBox.cpp <span style="color: grey">(a653216)</span></li>
<li>libs/main/KoModeBoxDocker.cpp <span style="color: grey">(a6969fd)</span></li>
<li>libs/main/KoModeBoxDocker_p.h <span style="color: grey">(f480781)</span></li>
<li>libs/main/KoModeBox_p.h <span style="color: grey">(2d54bf5)</span></li>
<li>libs/widgets/KoFillConfigWidget.h <span style="color: grey">(c2d8fca)</span></li>
<li>libs/widgets/KoFillConfigWidget.cpp <span style="color: grey">(3948290)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.h <span style="color: grey">(8b37d48)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.cpp <span style="color: grey">(4f4ead8)</span></li>
<li>plugins/defaultTools/defaulttool/DefaultTool.cpp <span style="color: grey">(0e77389)</span></li>
<li>plugins/dockers/CMakeLists.txt <span style="color: grey">(16988b3)</span></li>
<li>plugins/dockers/Plugin.cpp <span style="color: grey">(9b6c442)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.h <span style="color: grey">(06082e4)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.cpp <span style="color: grey">(1945a57)</span></li>
<li>plugins/dockers/styledocker/StyleButtonBox.h <span style="color: grey">(e2957fa)</span></li>
<li>plugins/dockers/styledocker/StyleButtonBox.cpp <span style="color: grey">(291a5af)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.h <span style="color: grey">(6daa8f4)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.cpp <span style="color: grey">(9f86be9)</span></li>
<li>plugins/dockers/styledocker/StyleDockerFactory.h <span style="color: grey">(acd91ac)</span></li>
<li>plugins/dockers/styledocker/StyleDockerFactory.cpp <span style="color: grey">(5898610)</span></li>
<li>plugins/dockers/styledocker/StylePreview.h <span style="color: grey">(da81351)</span></li>
<li>plugins/dockers/styledocker/StylePreview.cpp <span style="color: grey">(e196fe3)</span></li>
<li>plugins/textshape/TextShape.h <span style="color: grey">(8190ab1)</span></li>
<li>plugins/textshape/dialogs/SimpleTableWidget.ui <span style="color: grey">(cf9efa0)</span></li>
<li>stage/part/CMakeLists.txt <span style="color: grey">(87df86c)</span></li>
<li>stage/part/KPrPageLayoutWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrPageLayoutWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrView.cpp <span style="color: grey">(fd6b762)</span></li>
<li>stage/part/dockers/KPrPageLayoutDocker.h <span style="color: grey">(ed7a547)</span></li>
<li>stage/part/dockers/KPrPageLayoutDocker.cpp <span style="color: grey">(8348e2c)</span></li>
<li>words/part/frames/KWFrameLayout.cpp <span style="color: grey">(d778e1e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111747/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>