<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111787/">http://git.reviewboard.kde.org/r/111787/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 4th, 2013, 11:21 a.m. UTC, <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Jeremy,
Great to see things happening in the formatting department! I'd love to see this go in eventually.
Camilla told me that she had already gone over some bugs and the user experience with you so we agreed that I will concentrate on coding issues instead. Here is a list of issues that need to be fixed. I think you should perhaps take a look at our coding standards so that you don't get drowned in nitpicks that are easily avoidable. Other than that I had some naming issues and one place where I might have not understood (the pixel vs point issue).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello? Is anything happening with this patch? It would be a great pity if it started to bitrot.</pre>
<br />
<p>- Inge</p>
<br />
<p>On July 29th, 2013, 8:07 p.m. UTC, Jérémy BOURDIOL wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jérémy BOURDIOL.</div>
<p style="color: grey;"><i>Updated July 29, 2013, 8:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Huge feature on page layout started a moment ago.
PageLayout improvement now allows users to :
- resize margins directly with the mouse (still in debug)
- resize page borders directly with the mouse (still in debug)
- switch from portrait to landscape (and vise-versa) with one movement (vertical drag)
- add and remove header/footer with a simple double-click in the corresponding half of the page
- all changes could be see in the page layout dialog (in "page layout" section)
The feature has still some problems (most of them graphical) in extrem uses, please checkout the branch and give your feelings.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A lot of manual tests.
known bug :
When resizing the page and the cursor is passing over the previous/next page a double textarea appears</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/widgets/KoPageLayoutDialog.h <span style="color: grey">(7b0d029)</span></li>
<li>libs/widgets/KoPageLayoutWidget.cpp <span style="color: grey">(fd3667b)</span></li>
<li>words/part/CMakeLists.txt <span style="color: grey">(4e2650c)</span></li>
<li>words/part/KWView.h <span style="color: grey">(517cbc1)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(48265fd)</span></li>
<li>words/part/author/CAuView.cpp <span style="color: grey">(0c21610)</span></li>
<li>words/part/dialogs/KWPageSettingsDialog.h <span style="color: grey">(30a25d3)</span></li>
<li>words/part/dialogs/KWPageSettingsDialog.cpp <span style="color: grey">(e046ac6)</span></li>
<li>words/part/pagetool/KWPageTool.h <span style="color: grey">(45ad7d5)</span></li>
<li>words/part/pagetool/KWPageTool.cpp <span style="color: grey">(7935390)</span></li>
<li>words/part/pagetool/SimpleHeaderFooterWidget.h <span style="color: grey">(981d917)</span></li>
<li>words/part/pagetool/SimpleHeaderFooterWidget.cpp <span style="color: grey">(75b4409)</span></li>
<li>words/part/pagetool/SimplePageStyleWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/pagetool/SimplePageStyleWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/pagetool/SimplePageStyleWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111787/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>