<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111545/">http://git.reviewboard.kde.org/r/111545/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 13th, 2013, 10:36 p.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only had time for the first 3 pages tonight. Will do the rest tomorrow.
(And grr, the shell->mainWindow rename should have really been a separate step. Next time please, please think of your reviewers if you want more quality reviews and happy reviewers. It really complicates the review unneededly of code that is already complex :( )</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, that's why it's all different commits in the branch. In any case, what I really wanted to know is: can you confirm the issue you had in plan is now fixed?</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 13th, 2013, 10:36 p.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111545/diff/4/?file=178696#file178696line260" style="color: black; font-weight: bold; text-decoration: underline;">libs/main/KoDocument.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">259</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">showLoadingErrorDialog</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">UI stuff in KoDocument? Not so perfect.
Can this be somehow delegated to the kopart instance?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not, it's not perfect. But it's better than it used to be and KoPart is also the wrong place for gui stuff. This will need to be cleaned up in later patches, but as Inge said, it doesn't seem a good idea to wait with merging until the patch is really unmanagably big.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 13th, 2013, 10:36 p.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111545/diff/4/?file=178696#file178696line749" style="color: black; font-weight: bold; text-decoration: underline;">libs/main/KoDocument.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">748</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="n">KoDocumentInfoDlg</span><span class="o">*</span> <span class="n">createDocumentInfoDialog</span><span class="p">(</span><span class="n">QWidget</span> <span class="o">*</span><span class="n">parent</span><span class="p">,</span> <span class="n">KoDocumentInfo</span> <span class="o">*</span><span class="n">docInfo</span><span class="p">)</span> <span class="k">const</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QWidget in the KoDocument API :/
Can this functionality be handled by the view somehow, instead of the doc?
At least add a big TODO for now.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here, I don't really believe in adding big TODO's -- not after having removed several that came from 1999 or so...</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 13th, 2013, 10:36 p.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111545/diff/4/?file=178697#file178697line356" style="color: black; font-weight: bold; text-decoration: underline;">libs/main/KoDocument.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool KoDocument::saveFile()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">355</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KMessageBox</span><span class="o">::</span><span class="n">error</span><span class="p">(</span><span class="mi">0</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Could not save</span><span class="se">\n</span><span class="s">%1"</span><span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">parentPart</span><span class="o">-></span><span class="n">localFilePath</span><span class="p">()));</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">356</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span class="p">(</span><span class="n">errorMessage</span><span class="p">()</span> <span class="o">!=</span> <span class="s">"USER_CANCELED"</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">357</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KMessageBox</span><span class="o">::</span><span class="n">error</span><span class="p">(</span><span class="mi">0</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Could not save %1</span><span class="se">\n</span><span class="s">Reason: %2"</span><span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">parentPart</span><span class="o">-></span><span class="n">localFilePath</span><span class="p">(),</span> <span class="n">errorMessage</span><span class="p">()));</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">358</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">359</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Meh. UI/QWidget in the KoDocument.
What about a signal that is catched by the KoPart, which then does what is needed to present this info to the user?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KoPart is the wrong place. With the move to Qt5, KIO will also be split, and that will make it a lot easier to actually properly split out all the QWidget stuff. It's not something I want to fix in this iteration of the refactoring.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On August 13th, 2013, 8:17 a.m. UTC, Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Friedrich W. H. Kossebau and Marijn Kruisselbrink.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated Aug. 13, 2013, 8:17 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a continuation of the KoDocument/KoPart split that Camilla and I worked on last year, and it is a step towards the MVC refactoring discussed in Essen.
We actually did not use any of the kparts functionality anymore: not the embedding of Calligra parts in other applications, not document embedding, and the various plugins that were kparts actually did not do anything beyond what a kxmlguiclient plugin did.
This patch makes KoView and KoPart a KXMLGuiClient and lets KoMainWindow manage the KoParts. It is the first step in further refactoring:
* Make KoMainWindow a generic window for Calligra apps
* Make KoDocument responsible for all loading and saving
* Make KoPart a factory class that can create documents, views and canvaes
* Make KoView more properly an application-specific mainwindow implementation for an application that can show one or more documents
Current issues:
* In CalligraPlan I have commented out some code that didn't seem to actually do anything but was dependent on KParts. That needs to be checked by Friedrich for regressions
* KoMainWindow has way too many local KoPart pointers... That needs to be cleaned up.
Then I want to move the load/save code from KoPart to KoDocument and start the bigger refactoring... That will hopefully give us split view/mdi/tabbed view of documents again. And make the flipbook and animation plugins for krita easier to handle.
For easy testing I recommend checking out the krita-mvc-rempt branch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran all apps, loaded and saved documents and ran unittests.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=310310">310310</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=313482">313482</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=313483">313483</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(06e4971)</span></li>
<li>active/src/CATextDocumentHandler.cpp <span style="color: grey">(609832f)</span></li>
<li>braindump/plugins/quickstates/CMakeLists.txt <span style="color: grey">(ecadaea)</span></li>
<li>braindump/src/CMakeLists.txt <span style="color: grey">(7bfe50b)</span></li>
<li>cmake/modules/FindCalligraLibs.cmake.in <span style="color: grey">(1e49d17)</span></li>
<li>flow/part/FlowPart.cpp <span style="color: grey">(5fedf83)</span></li>
<li>karbon/data/CMakeLists.txt <span style="color: grey">(5183c06)</span></li>
<li>karbon/data/karbon_viewplugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>karbon/main.cpp <span style="color: grey">(b341d27)</span></li>
<li>karbon/plugins/flattenpath/CMakeLists.txt <span style="color: grey">(60bfe96)</span></li>
<li>karbon/plugins/flattenpath/FlattenPathPlugin.cpp <span style="color: grey">(936ddcc)</span></li>
<li>karbon/plugins/flattenpath/karbonflattenpathplugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>karbon/plugins/refinepath/CMakeLists.txt <span style="color: grey">(6d3de3d)</span></li>
<li>karbon/plugins/refinepath/RefinePathPlugin.cpp <span style="color: grey">(2e375cf)</span></li>
<li>karbon/plugins/refinepath/karbonrefinepathplugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>karbon/plugins/roundcorners/CMakeLists.txt <span style="color: grey">(f22cd94)</span></li>
<li>karbon/plugins/roundcorners/RoundCornersPlugin.cpp <span style="color: grey">(9892ce9)</span></li>
<li>karbon/plugins/roundcorners/karbonroundcornersplugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>karbon/plugins/whirlpinch/CMakeLists.txt <span style="color: grey">(accac4e)</span></li>
<li>karbon/plugins/whirlpinch/WhirlPinchPlugin.cpp <span style="color: grey">(4a50720)</span></li>
<li>karbon/plugins/whirlpinch/karbonwhirlpinchplugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>karbon/ui/KarbonDocument.cpp <span style="color: grey">(da78714)</span></li>
<li>karbon/ui/KarbonPart.cpp <span style="color: grey">(ab6774e)</span></li>
<li>karbon/ui/KarbonView.cpp <span style="color: grey">(d84b6da)</span></li>
<li>krita/plugins/assistants/RulerAssistant/CMakeLists.txt <span style="color: grey">(957fb4f)</span></li>
<li>krita/plugins/extensions/dockers/flipbook/flipbookdocker_dock.cpp <span style="color: grey">(49cf62a)</span></li>
<li>krita/sdk/tests/ui_manager_test.h <span style="color: grey">(63d8397)</span></li>
<li>krita/ui/actions/kis_selection_action_factories.cpp <span style="color: grey">(bf49d0a)</span></li>
<li>krita/ui/kis_flipbook.cpp <span style="color: grey">(918df92)</span></li>
<li>krita/ui/kis_part2.cpp <span style="color: grey">(83d5f34)</span></li>
<li>krita/ui/kis_view2.cpp <span style="color: grey">(2deab8b)</span></li>
<li>krita/ui/tests/kis_action_manager_test.cpp <span style="color: grey">(f4df430)</span></li>
<li>krita/ui/tests/kis_doc2_test.cpp <span style="color: grey">(d86e20a)</span></li>
<li>krita/ui/tests/kis_zoom_and_pan_test.cpp <span style="color: grey">(794c1ae)</span></li>
<li>krita/ui/widgets/kis_workspace_chooser.cpp <span style="color: grey">(0100372)</span></li>
<li>libs/kokross/KoScriptingDocker.cpp <span style="color: grey">(d2b7e16)</span></li>
<li>libs/kokross/KoScriptingModule.h <span style="color: grey">(4d57e94)</span></li>
<li>libs/kokross/KoScriptingModule.cpp <span style="color: grey">(304d547)</span></li>
<li>libs/kokross/KoScriptingPart.cpp <span style="color: grey">(68054ac)</span></li>
<li>libs/kopageapp/KoPAView.h <span style="color: grey">(80b9f78)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(bb88ee4)</span></li>
<li>libs/kopageapp/tests/CMakeLists.txt <span style="color: grey">(0d44ee3)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(3a9110c)</span></li>
<li>libs/main/KoApplication.h <span style="color: grey">(d973820)</span></li>
<li>libs/main/KoApplication.cpp <span style="color: grey">(7421107)</span></li>
<li>libs/main/KoApplicationAdaptor.h <span style="color: grey">(d71356f)</span></li>
<li>libs/main/KoDocument.h <span style="color: grey">(3372060)</span></li>
<li>libs/main/KoDocument.cpp <span style="color: grey">(622678f)</span></li>
<li>libs/main/KoDocumentEntry.cpp <span style="color: grey">(abbb55b)</span></li>
<li>libs/main/KoDocument_p.h <span style="color: grey">(6f3931f)</span></li>
<li>libs/main/KoFilterEntry.cpp <span style="color: grey">(8e23eac)</span></li>
<li>libs/main/KoMainWindow.h <span style="color: grey">(1b3503f)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(26327aa)</span></li>
<li>libs/main/KoPart.h <span style="color: grey">(d4ecf5f)</span></li>
<li>libs/main/KoPart.cpp <span style="color: grey">(56e27b5)</span></li>
<li>libs/main/KoPartAdaptor.h <span style="color: grey">(b7eb540)</span></li>
<li>libs/main/KoPartAdaptor.cpp <span style="color: grey">(58acde5)</span></li>
<li>libs/main/KoStartupDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/KoStartupDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/KoVersionDialog.cpp <span style="color: grey">(2f38510)</span></li>
<li>libs/main/KoView.h <span style="color: grey">(7b8d943)</span></li>
<li>libs/main/KoView.cpp <span style="color: grey">(1b4a722)</span></li>
<li>libs/pigment/KoColorSpaceMaths.h <span style="color: grey">(a517b2f)</span></li>
<li>libs/rdf/CMakeLists.txt <span style="color: grey">(bd29ead)</span></li>
<li>plan/kptmaindocument.cpp <span style="color: grey">(26cd92b)</span></li>
<li>plan/kptpart.cpp <span style="color: grey">(7674480)</span></li>
<li>plan/kptview.h <span style="color: grey">(02acb77)</span></li>
<li>plan/kptview.cpp <span style="color: grey">(64d0c68)</span></li>
<li>plan/libs/ui/kptviewbase.h <span style="color: grey">(9c4022a)</span></li>
<li>plan/libs/ui/kptviewbase.cpp <span style="color: grey">(7049a76)</span></li>
<li>plan/workpackage/CMakeLists.txt <span style="color: grey">(a1fbb87)</span></li>
<li>plugins/chartshape/ChartShape.cpp <span style="color: grey">(34a3db9)</span></li>
<li>plugins/colorengines/lcms2/CMakeLists.txt <span style="color: grey">(faa07a9)</span></li>
<li>plugins/kexi/spreadsheet/CMakeLists.txt <span style="color: grey">(78fbe7e)</span></li>
<li>plugins/reporting/barcode/CMakeLists.txt <span style="color: grey">(7423872)</span></li>
<li>plugins/reporting/chart/CMakeLists.txt <span style="color: grey">(a0d6378)</span></li>
<li>plugins/reporting/maps/CMakeLists.txt <span style="color: grey">(6bc29a0)</span></li>
<li>plugins/reporting/web/CMakeLists.txt <span style="color: grey">(03a9aeb)</span></li>
<li>plugins/staging/CMakeLists.txt <span style="color: grey">(754362f)</span></li>
<li>plugins/staging/googledocs/onlinedocument.h <span style="color: grey">(d4141f3)</span></li>
<li>plugins/staging/googledocs/onlinedocument.cpp <span style="color: grey">(a74ecd5)</span></li>
<li>sheets/part/Part.cpp <span style="color: grey">(7fd573e)</span></li>
<li>sheets/part/View.h <span style="color: grey">(49bcdf6)</span></li>
<li>sheets/part/View.cpp <span style="color: grey">(9dae4a5)</span></li>
<li>sheets/plugins/scripting/CMakeLists.txt <span style="color: grey">(90a0b24)</span></li>
<li>sheets/ui/MapViewModel.h <span style="color: grey">(ef3cf55)</span></li>
<li>sheets/ui/MapViewModel.cpp <span style="color: grey">(070ee29)</span></li>
<li>stage/part/KPrDocument.cpp <span style="color: grey">(7bdd5f9)</span></li>
<li>stage/part/KPrPart.cpp <span style="color: grey">(b79da91)</span></li>
<li>stage/part/KPrView.cpp <span style="color: grey">(fd6b762)</span></li>
<li>words/part/CMakeLists.txt <span style="color: grey">(4e2650c)</span></li>
<li>words/part/KWDocument.h <span style="color: grey">(7654aa3)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(259fd4e)</span></li>
<li>words/part/KWGui.cpp <span style="color: grey">(26c5281)</span></li>
<li>words/part/KWPart.h <span style="color: grey">(63e4e5f)</span></li>
<li>words/part/KWPart.cpp <span style="color: grey">(9e3a818)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(48265fd)</span></li>
<li>words/part/author/CAuPart.cpp <span style="color: grey">(0863305)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111545/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>