<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112080/">http://git.reviewboard.kde.org/r/112080/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To fix the spacing issue do this:
d->splitter->setSizePolicy(QSizePolicy::MinimumExpanding, QSizePolicy::MinimumExpanding);
</pre>
<br />
<p>- Sven</p>
<br />
<p>On August 14th, 2013, 3:53 p.m. UTC, Sascha Suelzer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Sascha Suelzer.</div>
<p style="color: grey;"><i>Updated Aug. 14, 2013, 3:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A rather chunky patch again, I'm afraid.
KoResourceItemChooser has been stripped of the tagging code, along with the GUI bits for it.
KoResourceTaggingInterface now contains the logic (assignment, renaming, etc), it also does the context menu for the resources themselves (maybe that should go into its own bit, too).
KoTagFilterWidget is the GUI bit for all filtering/searching operations.
KoTagChooserWidget is the GUI bit for choosing tags along with a tool button for modifying them (addition, removal, renaming, undeletion)
I've also updated my email address as well as some whitespace errors which got fixed along the way.
------------------------------------------
This is my first attempt at creating custom widgets.
That is most likely the reason for several issues that the code has.
1.) http://s18.postimg.org/9bgox9yvb/2013_08_08_171912_3200x1080_scrot.png
The layout breaks for KoResourceItemChooser instances where tagging and filter bar are shown. When they are hidden (like predefined brush settings, or favorite brush palette manager), the gaps don't occur.
2.) I have no idea if the widget/GUI code I have written is up to style/standards in general. (pimpl (which I was corrected on before, but I think it makes sense this time), using privacy and friends, etc)
3.) I don't know if I split the components sensibly.
Any pointers on any of that will be highly appreciated and incorporated as promptly as I am able to ^^ </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual, thorough testing, Krita only. Could not detect regressions in actual functionality.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/kis_palette_manager.cpp <span style="color: grey">(53b9c58)</span></li>
<li>krita/ui/widgets/kis_preset_chooser.h <span style="color: grey">(92d1501)</span></li>
<li>krita/ui/widgets/kis_preset_chooser.cpp <span style="color: grey">(4da9ed3)</span></li>
<li>krita/ui/widgets/kis_workspace_chooser.cpp <span style="color: grey">(0100372)</span></li>
<li>libs/widgets/CMakeLists.txt <span style="color: grey">(a1b9344)</span></li>
<li>libs/widgets/KoResourceFiltering.h <span style="color: grey">(ca5a360)</span></li>
<li>libs/widgets/KoResourceFiltering.cpp <span style="color: grey">(4a3976e)</span></li>
<li>libs/widgets/KoResourceItemChooser.h <span style="color: grey">(b5e0022)</span></li>
<li>libs/widgets/KoResourceItemChooser.cpp <span style="color: grey">(2f9e71f)</span></li>
<li>libs/widgets/KoResourceItemChooserContextMenu.h <span style="color: grey">(fb5bfbb)</span></li>
<li>libs/widgets/KoResourceItemChooserContextMenu.cpp <span style="color: grey">(bfeb907)</span></li>
<li>libs/widgets/KoResourceModel.h <span style="color: grey">(783de22)</span></li>
<li>libs/widgets/KoResourceModel.cpp <span style="color: grey">(636dd44)</span></li>
<li>libs/widgets/KoResourceServer.h <span style="color: grey">(a56e9b4)</span></li>
<li>libs/widgets/KoResourceServerAdapter.h <span style="color: grey">(7d63504)</span></li>
<li>libs/widgets/KoResourceTaggingInterface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoResourceTaggingInterface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoTagChooserWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoTagChooserWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoTagFilterWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoTagFilterWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112080/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>