<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111787/">http://git.reviewboard.kde.org/r/111787/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 4th, 2013, 11:21 a.m. UTC, <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111787/diff/1/?file=175244#file175244line272" style="color: black; font-weight: bold; text-decoration: underline;">words/part/pagetool/KWPageTool.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">271</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">KWPageTool</span><span class="o">::</span><span class="n">applyStyle</span><span class="p">(</span><span class="kt">int</span> <span class="n">page</span><span class="p">,</span> <span class="n">QString</span> <span class="n">style</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is "style" the name of the style? If so, I think it would be clearer if the parameter was called "styleName". Otherwise you'd think it was a serialization of the style, i.e. the actual style contents.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also; const-ref. E.g. "const QString &styleName".</pre>
<br />
<p>- Elvis</p>
<br />
<p>On July 29th, 2013, 8:07 p.m. UTC, Jérémy BOURDIOL wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jérémy BOURDIOL.</div>
<p style="color: grey;"><i>Updated July 29, 2013, 8:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Huge feature on page layout started a moment ago.
PageLayout improvement now allows users to :
- resize margins directly with the mouse (still in debug)
- resize page borders directly with the mouse (still in debug)
- switch from portrait to landscape (and vise-versa) with one movement (vertical drag)
- add and remove header/footer with a simple double-click in the corresponding half of the page
- all changes could be see in the page layout dialog (in "page layout" section)
The feature has still some problems (most of them graphical) in extrem uses, please checkout the branch and give your feelings.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A lot of manual tests.
known bug :
When resizing the page and the cursor is passing over the previous/next page a double textarea appears</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/widgets/KoPageLayoutDialog.h <span style="color: grey">(7b0d029)</span></li>
<li>libs/widgets/KoPageLayoutWidget.cpp <span style="color: grey">(fd3667b)</span></li>
<li>words/part/CMakeLists.txt <span style="color: grey">(4e2650c)</span></li>
<li>words/part/KWView.h <span style="color: grey">(517cbc1)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(48265fd)</span></li>
<li>words/part/author/CAuView.cpp <span style="color: grey">(0c21610)</span></li>
<li>words/part/dialogs/KWPageSettingsDialog.h <span style="color: grey">(30a25d3)</span></li>
<li>words/part/dialogs/KWPageSettingsDialog.cpp <span style="color: grey">(e046ac6)</span></li>
<li>words/part/pagetool/KWPageTool.h <span style="color: grey">(45ad7d5)</span></li>
<li>words/part/pagetool/KWPageTool.cpp <span style="color: grey">(7935390)</span></li>
<li>words/part/pagetool/SimpleHeaderFooterWidget.h <span style="color: grey">(981d917)</span></li>
<li>words/part/pagetool/SimpleHeaderFooterWidget.cpp <span style="color: grey">(75b4409)</span></li>
<li>words/part/pagetool/SimplePageStyleWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/pagetool/SimplePageStyleWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/pagetool/SimplePageStyleWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111787/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>