<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111615/">http://git.reviewboard.kde.org/r/111615/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have not tested the patch but from the looks it looks ok, besides the last change in words/part/KWPageStyle.cpp maybe camilla can say what it should be. </pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111615/diff/2/?file=174102#file174102line499" style="color: black; font-weight: bold; text-decoration: underline;">libs/widgets/KoFillConfigWidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoFillConfigWidget::updateWidget(KoShape *shape)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">498</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KoGradientBackground</span> <span class="o">*</span><span class="n">newGradient</span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">499</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QSharedPointer</span><span class="o"><</span><span class="n">KoGradientBackground</span><span class="o">></span> <span class="n">newGradient</span> <span class="o">=</span> <span class="n">QSharedPointer</span><span class="o"><</span><span class="n">KoGradientBackground</span><span class="o">></span><span class="p">(</span><span class="mi">0</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I meant can be simplified to QSharedPointer<KoGradientBackground> newGardient</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111615/diff/2/?file=174108#file174108line267" style="color: black; font-weight: bold; text-decoration: underline;">plugins/dockers/styledocker/StrokeFillWidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void StrokeFillWidget::setStretchPolicy(StrokeFillWidget::StretchPolicy policy)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">267</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KoGradientBackground</span> <span class="o">*</span><span class="n">newGradient</span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">267</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QSharedPointer</span><span class="o"><</span><span class="n">KoGradientBackground</span><span class="o">></span> <span class="n">newGradient</span> <span class="o">=</span> <span class="n">QSharedPointer</span><span class="o"><</span><span class="n">KoGradientBackground</span><span class="o">></span><span class="p">(</span><span class="mi">0</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can be simplified to QSharedPointer<KoGradientBackground> newGradient;</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111615/diff/2/?file=174110#file174110line424" style="color: black; font-weight: bold; text-decoration: underline;">plugins/dockers/styledocker/StyleDocker.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void StyleDocker::updatePattern(KoResource * item)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">424</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KoPatternBackground</span><span class="hl"> </span><span class="o"><span class="hl">*</span></span> <span class="n">fill</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KoPatternBackground</span><span class="p">(</span><span class="n">imageCollection</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">424</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">QSharedPointer</span></span><span class="o"><span class="hl"><</span></span><span class="n">KoPatternBackground</span><span class="o"><span class="hl">></span></span><span class="hl"> </span> <span class="n">fill</span> <span class="o">=</span> <span class="n"><span class="hl">QSharedPointer</span></span><span class="o"><span class="hl"><</span></span><span class="n"><span class="hl">KoPatternBackground</span></span><span class="o"><span class="hl">></span></span><span class="p"><span class="hl">(</span></span><span class="k">new</span> <span class="n">KoPatternBackground</span><span class="p">(</span><span class="n">imageCollection</span><span class="p">)<span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can be simplified to QSharedPointer<KoPatternBackground> fill(new KoPatternBackground(imageCollection));</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111615/diff/2/?file=174121#file174121line436" style="color: black; font-weight: bold; text-decoration: underline;">words/part/KWPageStyle.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">uint qHash(const KWPageStyle &style)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">436</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">fullPageBackground</span><span class="p">)</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure here but shouldn't this call d->fullPageBackground.clear()?</pre>
</div>
<br />
<p>- Thorsten</p>
<br />
<p>On July 28th, 2013, 9:46 a.m. UTC, Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Jan Hambrecht.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated July 28, 2013, 9:46 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch wraps KoShapeBackground in a QPointer instead of doing manual refcounting. Bug 321714 shows, imo, that the manual refcounting is fragile and sometimes breaks. I don't remember why we weren't supposed to use QPointer (other than that it gets a little ugly with subclassing), but it seems a good fit here.
There are other classes that do manual refcounting, and I think those should be converted, too -- but in another patch.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=321714">321714</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(38c3f62)</span></li>
<li>cmake/modules/FindVc.cmake <span style="color: grey">(bb9823f)</span></li>
<li>filters/karbon/wmf/WmfExport.cpp <span style="color: grey">(bf0aa85)</span></li>
<li>karbon/plugins/tools/CalligraphyTool/KarbonCalligraphicShape.cpp <span style="color: grey">(e9921b8)</span></li>
<li>karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp <span style="color: grey">(2517164)</span></li>
<li>karbon/plugins/tools/KarbonGradientEditStrategy.cpp <span style="color: grey">(0bf30d1)</span></li>
<li>karbon/plugins/tools/KarbonGradientTool.cpp <span style="color: grey">(79d4fde)</span></li>
<li>karbon/plugins/tools/KarbonPatternEditStrategy.h <span style="color: grey">(b66b78d)</span></li>
<li>karbon/plugins/tools/KarbonPatternEditStrategy.cpp <span style="color: grey">(1b4e0c0)</span></li>
<li>karbon/plugins/tools/KarbonPatternTool.cpp <span style="color: grey">(5c0ac36)</span></li>
<li>karbon/ui/KarbonView.cpp <span style="color: grey">(7e54ede)</span></li>
<li>karbon/ui/widgets/KarbonPaletteBarWidget.cpp <span style="color: grey">(5898872)</span></li>
<li>karbon/ui/widgets/KarbonSmallStylePreview.cpp <span style="color: grey">(f6d76cf)</span></li>
<li>krita/ui/flake/kis_shape_selection_model.cpp <span style="color: grey">(4c59ad0)</span></li>
<li>krita/ui/opengl/kis_opengl_canvas2.cpp <span style="color: grey">(1674ab4)</span></li>
<li>krita/ui/tool/kis_tool_shape.cc <span style="color: grey">(aab57dd)</span></li>
<li>krita/ui/widgets/kis_floating_message.cpp <span style="color: grey">(d53e133)</span></li>
<li>libs/flake/KoConnectionShape.cpp <span style="color: grey">(09af2dd)</span></li>
<li>libs/flake/KoOdfWorkaround.h <span style="color: grey">(5faa268)</span></li>
<li>libs/flake/KoOdfWorkaround.cpp <span style="color: grey">(8a5b593)</span></li>
<li>libs/flake/KoShape.h <span style="color: grey">(fe6cc3f)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(6d14a8c)</span></li>
<li>libs/flake/KoShapeBackground.h <span style="color: grey">(33253a8)</span></li>
<li>libs/flake/KoShapeBackground.cpp <span style="color: grey">(9d6b29e)</span></li>
<li>libs/flake/KoShapeBackground_p.h <span style="color: grey">(92acc36)</span></li>
<li>libs/flake/KoShape_p.h <span style="color: grey">(aa6633c)</span></li>
<li>libs/flake/commands/KoShapeBackgroundCommand.h <span style="color: grey">(bee749d)</span></li>
<li>libs/flake/commands/KoShapeBackgroundCommand.cpp <span style="color: grey">(f4acd2c)</span></li>
<li>libs/flake/svg/SvgParser.cpp <span style="color: grey">(6898ffc)</span></li>
<li>libs/flake/svg/SvgStyleWriter.h <span style="color: grey">(1327e27)</span></li>
<li>libs/flake/svg/SvgStyleWriter.cpp <span style="color: grey">(8be614a)</span></li>
<li>libs/flake/tests/TestShapeBackgroundCommand.cpp <span style="color: grey">(e0b69ba)</span></li>
<li>libs/kopageapp/KoPAPageBase.cpp <span style="color: grey">(d56c7fe)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(58b4940)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp <span style="color: grey">(c0c5afa)</span></li>
<li>libs/widgets/KoFillConfigWidget.h <span style="color: grey">(4d71718)</span></li>
<li>libs/widgets/KoFillConfigWidget.cpp <span style="color: grey">(d086eb7)</span></li>
<li>libs/widgets/KoResourcePopupAction.h <span style="color: grey">(91031e4)</span></li>
<li>libs/widgets/KoResourcePopupAction.cpp <span style="color: grey">(2d873ca)</span></li>
<li>plugins/artistictextshape/ArtisticTextShapeFactory.cpp <span style="color: grey">(37552b8)</span></li>
<li>plugins/chartshape/ChartShape.cpp <span style="color: grey">(55d5eb8)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.h <span style="color: grey">(212eaa0)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.cpp <span style="color: grey">(d67cabf)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.h <span style="color: grey">(2408188)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.cpp <span style="color: grey">(052b2ee)</span></li>
<li>plugins/dockers/styledocker/StylePreview.h <span style="color: grey">(db33b3f)</span></li>
<li>plugins/dockers/styledocker/StylePreview.cpp <span style="color: grey">(39f8b42)</span></li>
<li>plugins/pathshapes/ellipse/EllipseShapeFactory.cpp <span style="color: grey">(0a4c68d)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathParameter.cpp <span style="color: grey">(29d2ad2)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp <span style="color: grey">(f1e3974)</span></li>
<li>plugins/pathshapes/rectangle/RectangleShapeFactory.cpp <span style="color: grey">(689abfe)</span></li>
<li>plugins/pathshapes/star/StarShapeFactory.cpp <span style="color: grey">(dd34c06)</span></li>
<li>plugins/textshape/TextShape.cpp <span style="color: grey">(b230f0a)</span></li>
<li>stage/part/KPrEndOfSlideShowPage.cpp <span style="color: grey">(061aa58)</span></li>
<li>words/part/KWPageStyle.h <span style="color: grey">(b2eeb43)</span></li>
<li>words/part/KWPageStyle.cpp <span style="color: grey">(f53dab5)</span></li>
<li>words/part/KWPageStyle_p.h <span style="color: grey">(356af3a)</span></li>
<li>words/part/frames/KWFrameLayout.cpp <span style="color: grey">(6b2a31e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111615/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>