<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111615/">http://git.reviewboard.kde.org/r/111615/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 27th, 2013, 4:53 a.m. UTC, <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using a QObject for all KoShapeBackgrounds is quite a very big overhead and also the first place why we did not use it. If this stuff fails somewhere it looks like a big bug to me. Do you have some details why the crash did happens so I can have a look.
If we want to use smart pointers then it would be in my oppinion much better to use QSharedPointer instead of makin this a QObject and using by that quite a lot of memory for each shape.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Well, yes, after discussing this with Inge yesterday, I agreed that I should rewrite it using QSharedPointer -- or maybe make KisSharedPtr available for the rest of Calligra. QPointer is the wrong solution here anyway. I do think that we need to replace _all_ places where we do manual refcounting, though. It's simply not safe. For the crash, see the linked bug.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On July 20th, 2013, 12:11 p.m. UTC, Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Jan Hambrecht.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated July 20, 2013, 12:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch wraps KoShapeBackground in a QPointer instead of doing manual refcounting. Bug 321714 shows, imo, that the manual refcounting is fragile and sometimes breaks. I don't remember why we weren't supposed to use QPointer (other than that it gets a little ugly with subclassing), but it seems a good fit here.
There are other classes that do manual refcounting, and I think those should be converted, too -- but in another patch.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=321714">321714</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>karbon/plugins/tools/KarbonPatternTool.cpp <span style="color: grey">(5c0ac36)</span></li>
<li>karbon/plugins/tools/KarbonPatternEditStrategy.cpp <span style="color: grey">(1b4e0c0)</span></li>
<li>karbon/plugins/tools/KarbonPatternEditStrategy.h <span style="color: grey">(b66b78d)</span></li>
<li>karbon/plugins/tools/KarbonGradientTool.cpp <span style="color: grey">(79d4fde)</span></li>
<li>karbon/plugins/tools/KarbonGradientEditStrategy.cpp <span style="color: grey">(0bf30d1)</span></li>
<li>filters/karbon/wmf/WmfExport.cpp <span style="color: grey">(bf0aa85)</span></li>
<li>braindump/src/SectionContainer.cpp <span style="color: grey">(9cbf6d7)</span></li>
<li>karbon/ui/KarbonView.cpp <span style="color: grey">(7e54ede)</span></li>
<li>karbon/ui/widgets/KarbonPaletteBarWidget.cpp <span style="color: grey">(5898872)</span></li>
<li>karbon/ui/widgets/KarbonSmallStylePreview.cpp <span style="color: grey">(f6d76cf)</span></li>
<li>krita/ui/flake/kis_shape_selection_model.cpp <span style="color: grey">(4c59ad0)</span></li>
<li>krita/ui/tool/kis_tool_shape.cc <span style="color: grey">(aab57dd)</span></li>
<li>libs/flake/KoConnectionShape.cpp <span style="color: grey">(09af2dd)</span></li>
<li>libs/flake/KoOdfWorkaround.h <span style="color: grey">(5faa268)</span></li>
<li>libs/flake/KoOdfWorkaround.cpp <span style="color: grey">(8a5b593)</span></li>
<li>libs/flake/KoShape.h <span style="color: grey">(fe6cc3f)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(6d14a8c)</span></li>
<li>libs/flake/KoShapeBackground.h <span style="color: grey">(33253a8)</span></li>
<li>libs/flake/KoShapeBackground.cpp <span style="color: grey">(9d6b29e)</span></li>
<li>libs/flake/KoShapeBackground_p.h <span style="color: grey">(92acc36)</span></li>
<li>libs/flake/KoShape_p.h <span style="color: grey">(aa6633c)</span></li>
<li>libs/flake/commands/KoShapeBackgroundCommand.h <span style="color: grey">(bee749d)</span></li>
<li>libs/flake/commands/KoShapeBackgroundCommand.cpp <span style="color: grey">(f4acd2c)</span></li>
<li>libs/flake/svg/SvgParser.cpp <span style="color: grey">(6898ffc)</span></li>
<li>libs/flake/svg/SvgStyleWriter.h <span style="color: grey">(1327e27)</span></li>
<li>libs/flake/svg/SvgStyleWriter.cpp <span style="color: grey">(8be614a)</span></li>
<li>libs/flake/tests/TestShapeBackgroundCommand.cpp <span style="color: grey">(e0b69ba)</span></li>
<li>libs/kopageapp/KoPAPageBase.cpp <span style="color: grey">(d56c7fe)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp <span style="color: grey">(c0c5afa)</span></li>
<li>libs/widgets/KoFillConfigWidget.h <span style="color: grey">(4d71718)</span></li>
<li>libs/widgets/KoFillConfigWidget.cpp <span style="color: grey">(d086eb7)</span></li>
<li>libs/widgets/KoResourcePopupAction.h <span style="color: grey">(91031e4)</span></li>
<li>libs/widgets/KoResourcePopupAction.cpp <span style="color: grey">(2d873ca)</span></li>
<li>plugins/chartshape/ChartShape.cpp <span style="color: grey">(55d5eb8)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.h <span style="color: grey">(212eaa0)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.cpp <span style="color: grey">(d67cabf)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.h <span style="color: grey">(2408188)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.cpp <span style="color: grey">(052b2ee)</span></li>
<li>plugins/dockers/styledocker/StylePreview.h <span style="color: grey">(db33b3f)</span></li>
<li>plugins/dockers/styledocker/StylePreview.cpp <span style="color: grey">(39f8b42)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathParameter.cpp <span style="color: grey">(29d2ad2)</span></li>
<li>plugins/textshape/TextShape.cpp <span style="color: grey">(b230f0a)</span></li>
<li>words/part/KWPageStyle.h <span style="color: grey">(b2eeb43)</span></li>
<li>words/part/KWPageStyle.cpp <span style="color: grey">(f53dab5)</span></li>
<li>words/part/KWPageStyle_p.h <span style="color: grey">(356af3a)</span></li>
<li>words/part/frames/KWFrameLayout.cpp <span style="color: grey">(6b2a31e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111615/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>