<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111595/">http://git.reviewboard.kde.org/r/111595/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit ee83b45a3d04ad61fc96a9dae1bb53cba0cb9bf4 by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 19th, 2013, 10:07 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 19, 2013, 10:07 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The power of QStringBuilder only sets in if more than two strings are concatenated before picking up the result as QString again (e.g. when assigning to a QString variable). There are some code parts where a lot of concatenating is done, but not in one expression, instead assigning the intermediate result to a QString var again and again, thus preventing the advantage of QStringBuilder.
There are also a few places in the code where literal strings are concatenated using "+", instead of having the compiler concatenate them already.
Attached patch optimizes the code in those two cases: by removing "+" between literal string and turning sequences of += into a chain of +</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/karbon/eps/EpsImport.cpp <span style="color: grey">(d91f092)</span></li>
<li>filters/karbon/karbon1.x/Karbon1xImport.cpp <span style="color: grey">(4510b88)</span></li>
<li>filters/karbon/wmf/WmfImportParser.cpp <span style="color: grey">(9ba0faa)</span></li>
<li>filters/libmso/shapes2.cpp <span style="color: grey">(9f794e2)</span></li>
<li>filters/libmsooxml/ComplexShapeHandler.cpp <span style="color: grey">(b093db4)</span></li>
<li>filters/libmsooxml/MsooXmlVmlReaderImpl.h <span style="color: grey">(6a96176)</span></li>
<li>filters/sheets/applixspread/applixspreadimport.cc <span style="color: grey">(7b52ed4)</span></li>
<li>filters/sheets/csv/csvexport.cc <span style="color: grey">(8e2a79c)</span></li>
<li>filters/sheets/dbase/dbaseimport.cc <span style="color: grey">(38b30b5)</span></li>
<li>filters/sheets/html/htmlexport.cc <span style="color: grey">(1d5bfc6)</span></li>
<li>filters/stage/kpr2odf/Filterkpr2odf.cpp <span style="color: grey">(9a3e83e)</span></li>
<li>kexi/kexiutils/identifier.cpp <span style="color: grey">(0505326)</span></li>
<li>kexi/migration/pqxx/pqxxmigrate.cpp <span style="color: grey">(c7aaefc)</span></li>
<li>libs/db/connection.cpp <span style="color: grey">(4eebf3a)</span></li>
<li>libs/db/cursor.cpp <span style="color: grey">(80bf01d)</span></li>
<li>libs/db/expression.cpp <span style="color: grey">(e8e43c1)</span></li>
<li>libs/db/fieldlist.cpp <span style="color: grey">(9ed9812)</span></li>
<li>libs/db/preparedstatement.cpp <span style="color: grey">(cfc2b05)</span></li>
<li>libs/db/queryschema.cpp <span style="color: grey">(2fa34e9)</span></li>
<li>libs/db/utils.cpp <span style="color: grey">(1beec54)</span></li>
<li>libs/flake/svg/SvgCssHelper.cpp <span style="color: grey">(8d68c63)</span></li>
<li>libs/koreport/renderer/KoReportHTMLCSSRenderer.cpp <span style="color: grey">(58c1598)</span></li>
<li>libs/koreport/renderer/KoReportHTMLTableRenderer.cpp <span style="color: grey">(c98866d)</span></li>
<li>libs/koreport/renderer/KoReportKSpreadRenderer.cpp <span style="color: grey">(bf70deb)</span></li>
<li>libs/main/KoDocumentEntry.cpp <span style="color: grey">(e1b03f7)</span></li>
<li>libs/main/KoFilterManager.cpp <span style="color: grey">(2648885)</span></li>
<li>libs/main/KoRecentDocumentsPane.cpp <span style="color: grey">(126078e)</span></li>
<li>libs/main/PriorityQueue_p.h <span style="color: grey">(e83c137)</span></li>
<li>libs/odf/KoStyleStack.cpp <span style="color: grey">(d07b635)</span></li>
<li>libs/odf/KoXmlStreamReader.cpp <span style="color: grey">(45073c3)</span></li>
<li>libs/pigment/KoColorConversionSystem.cpp <span style="color: grey">(2ad1b98)</span></li>
<li>libs/vectorimage/libwmf/qwmf.cc <span style="color: grey">(73c661a)</span></li>
<li>sheets/Condition.cpp <span style="color: grey">(b84ebde)</span></li>
<li>sheets/Currency.cpp <span style="color: grey">(74ad638)</span></li>
<li>sheets/FunctionDescription.cpp <span style="color: grey">(a13dccb)</span></li>
<li>sheets/GenValidationStyle.cpp <span style="color: grey">(d3622fb)</span></li>
<li>sheets/Sheet.cpp <span style="color: grey">(fb3b9d0)</span></li>
<li>sheets/Util.cpp <span style="color: grey">(f54e673)</span></li>
<li>sheets/ValueFormatter.cpp <span style="color: grey">(9dacad5)</span></li>
<li>sheets/dialogs/DatabaseDialog.cpp <span style="color: grey">(b644f4b)</span></li>
<li>sheets/dialogs/FormulaDialog.cpp <span style="color: grey">(905b844)</span></li>
<li>sheets/dialogs/ListDialog.cpp <span style="color: grey">(ba032b6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111595/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>