<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110949/">http://git.reviewboard.kde.org/r/110949/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good now, please merge and push.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110949/diff/2/?file=167683#file167683line242" style="color: black; font-weight: bold; text-decoration: underline;">filters/sheets/libkspreadexport/KSpreadLeader.cc</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KoFilter::ConversionStatus Leader::doSpreadSheet(KSpreadSheet *spreadSheet)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">242</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">docSpreadSheetProperty</span><span class="p">[</span><span class="s">"showpageborders"</span><span class="p">]</span> <span class="o">=</span> <span class="p">(</span><span class="n">spreadSheet</span><span class="o">-></span><span class="n">isShowPage<span class="hl">Borders</span></span><span class="p">()</span> <span class="o">==</span> <span class="mi">0</span> <span class="o">?</span> <span class="s">"false"</span> <span class="o">:</span> <span class="s">"true"</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">242</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">docSpreadSheetProperty</span><span class="p">[</span><span class="s">"showpageborders"</span><span class="p">]</span> <span class="o">=</span> <span class="p">(</span><span class="n">spreadSheet</span><span class="o">-></span><span class="n">isShowPage<span class="hl">Outline</span></span><span class="p">()</span> <span class="o">==</span> <span class="mi">0</span> <span class="o">?</span> <span class="s">"false"</span> <span class="o">:</span> <span class="s">"true"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe this property should also be renamed but that's for another patch.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110949/diff/2/?file=167694#file167694line334" style="color: black; font-weight: bold; text-decoration: underline;">sheets/part/View.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void View::Private::initActions()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">334</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">actions</span><span class="o">-></span><span class="n">showPage<span class="hl">Borders</span></span><span class="o">-></span><span class="n">setToolTip</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"Show on the spreadsheet where the page borders will be"</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">334</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">actions</span><span class="o">-></span><span class="n">showPage<span class="hl">Outline</span></span><span class="o">-></span><span class="n">setToolTip</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"Show on the spreadsheet where the page borders will be"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">page boundaries, not borders</pre>
</div>
<br />
<p>- Inge</p>
<br />
<p>On July 3rd, 2013, 2:09 a.m. UTC, Jigar Raisinghani wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Inge Wallin and Marijn Kruisselbrink.</div>
<div>By Jigar Raisinghani.</div>
<p style="color: grey;"><i>Updated July 3, 2013, 2:09 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, Calligra Sheets has a feature called Page Borders which displays the boundaries for pages. This is useful to get an idea of where a page ends and new page begins. But these are NOT actual Borders/Boundaries but just the Markers. Page Borders would mean ACTUAL Borders(customizable) and not just markers. So, Renaming "Page Borders" to "Page Markers" </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, Page Borders renamed to Page Markers successfully.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/sheets/excel/import/ExcelImport.cpp <span style="color: grey">(53decbd)</span></li>
<li>filters/sheets/excel/import/excelimporttoods.cc <span style="color: grey">(42586ea)</span></li>
<li>filters/sheets/libkspreadexport/KSpreadLeader.cc <span style="color: grey">(9880b11)</span></li>
<li>sheets/ApplicationSettings.h <span style="color: grey">(c3828f2)</span></li>
<li>sheets/ApplicationSettings.cpp <span style="color: grey">(c779129)</span></li>
<li>sheets/Sheet.h <span style="color: grey">(7090a8c)</span></li>
<li>sheets/Sheet.cpp <span style="color: grey">(7d3548a)</span></li>
<li>sheets/commands/PageBreakCommand.cpp <span style="color: grey">(7f0f49a)</span></li>
<li>sheets/commands/SheetCommands.h <span style="color: grey">(68a30e1)</span></li>
<li>sheets/commands/SheetCommands.cpp <span style="color: grey">(b501c06)</span></li>
<li>sheets/interfaces/SheetAdaptor.h <span style="color: grey">(cf0ec69)</span></li>
<li>sheets/interfaces/SheetAdaptor.cpp <span style="color: grey">(c4a51ce)</span></li>
<li>sheets/part/View.h <span style="color: grey">(4be69c4)</span></li>
<li>sheets/part/View.cpp <span style="color: grey">(61c485c)</span></li>
<li>sheets/part/dialogs/InterfaceOptionsWidget.ui <span style="color: grey">(0afc27c)</span></li>
<li>sheets/part/dialogs/PreferenceDialog.cpp <span style="color: grey">(721ce25)</span></li>
<li>sheets/part/dialogs/SheetPropertiesDialog.h <span style="color: grey">(2330ae6)</span></li>
<li>sheets/part/dialogs/SheetPropertiesDialog.cpp <span style="color: grey">(858fdb3)</span></li>
<li>sheets/part/dialogs/SheetPropertiesWidget.ui <span style="color: grey">(1d41fc7)</span></li>
<li>sheets/sheets.kcfg <span style="color: grey">(c0ec520)</span></li>
<li>sheets/sheets.rc <span style="color: grey">(6256df6)</span></li>
<li>sheets/sheets_readonly.rc <span style="color: grey">(1e9e248)</span></li>
<li>sheets/ui/CellView.cpp <span style="color: grey">(d2b6e26)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110949/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>