<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111326/">http://git.reviewboard.kde.org/r/111326/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 1st, 2013, 2:25 a.m. UTC, <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No comment on the patch yet but it seems to me that you have a larger plan behind all of these patches. Is it just to get out of the way from other applications or is your ultimate goal something else? None of the other large KDE apps, like the Kontact suite for instance, does this as far as I know. And the Gnome apps definitely don't. Instead they go the other way and try to occupy as much namespace as possible and also preferably as generic as possible. Case in point: The "Document" Foundation instead of The LibreOffice Foundation.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No hidden plan, just wanting to make Calligra a good citizen of the FLOSS world (I tend to follow good examples, not the bad ones ;) )
And see the arguments I gave above, for me it's basically also about having it easier to do the cat-herding of our plugins/libs/headers as developer.
(And to increase the K in your AFAIK, kdepim (thus Kontact) installs to akonadi/, kcal/, kabc/, kmime/ etc. Marble installs to marble/. And others similar. Which is a Good Thing (tm) IMHO :) No idea about other apps (using other toolkits), they might have to learn the hard way that this is not a smart way to go, unless by purpose to do evil to the rest of the gang. But then I expect Good Will from FLOSS projects in general :) So please if you see any non-namespaced headers, by prefix or subdir, which can result in conflicts, file a bug report with that project. Or file the bug via your distribution, they should share the interest)
For names of companies/foundations/states I do not care here :)</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On June 30th, 2013, 9:38 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 30, 2013, 9:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While almost all headers of Calligra libs are prefixed with "Ko"/"ko" it feels better to install them to their own subdir named "calligra/":
* Easier for people using the libs and wanting to browse through all the available headers (until we improve http://api.kde.org/bundled-apps-api/calligra-apidocs/)
* Easier also for developers to just remove the complete calligra/ dir to clean up
* subdirs "styles/" & "changetracker/" are used by kotext headers, which feels strange directly in the normal include dir, without any prefix
Questions:
* Should that "calligra/" be made a configuration option? Who might need/want change that to something else?
* Should all the other apps also install below calligra/$APP, or continue to use "words/", "sheets/", "stage/" etc.?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2504353)</span></li>
<li>interfaces/CMakeLists.txt <span style="color: grey">(36eb42a)</span></li>
<li>libs/basicflakes/CMakeLists.txt <span style="color: grey">(4750c5f)</span></li>
<li>libs/flake/CMakeLists.txt <span style="color: grey">(233d3ce)</span></li>
<li>libs/kopageapp/CMakeLists.txt <span style="color: grey">(deb7d76)</span></li>
<li>libs/kotext/CMakeLists.txt <span style="color: grey">(8929d8a)</span></li>
<li>libs/kundo2/CMakeLists.txt <span style="color: grey">(cf66a13)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(147b25c)</span></li>
<li>libs/odf/CMakeLists.txt <span style="color: grey">(574f8a5)</span></li>
<li>libs/pigment/CMakeLists.txt <span style="color: grey">(8cc00e8)</span></li>
<li>libs/rdf/CMakeLists.txt <span style="color: grey">(875ce13)</span></li>
<li>libs/textlayout/CMakeLists.txt <span style="color: grey">(cf2b83b)</span></li>
<li>libs/widgets/CMakeLists.txt <span style="color: grey">(38155e7)</span></li>
<li>libs/widgetutils/CMakeLists.txt <span style="color: grey">(bfe64ca)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111326/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>