<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111326/">http://git.reviewboard.kde.org/r/111326/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice patch. Having it configurable might be asking for trouble IMO, as 3rd parties should be able to rely on the headers being at a fixed location. For the second question; I think it makes sense to put everything under calligra/, but I'll let more people chime in on that.</pre>
<br />
<p>- Elvis</p>
<br />
<p>On June 30th, 2013, 9:38 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 30, 2013, 9:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While almost all headers of Calligra libs are prefixed with "Ko"/"ko" it feels better to install them to their own subdir named "calligra/":
* Easier for people using the libs and wanting to browse through all the available headers (until we improve http://api.kde.org/bundled-apps-api/calligra-apidocs/)
* Easier also for developers to just remove the complete calligra/ dir to clean up
* subdirs "styles/" & "changetracker/" are used by kotext headers, which feels strange directly in the normal include dir, without any prefix
Questions:
* Should that "calligra/" be made a configuration option? Who might need/want change that to something else?
* Should all the other apps also install below calligra/$APP, or continue to use "words/", "sheets/", "stage/" etc.?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2504353)</span></li>
<li>interfaces/CMakeLists.txt <span style="color: grey">(36eb42a)</span></li>
<li>libs/basicflakes/CMakeLists.txt <span style="color: grey">(4750c5f)</span></li>
<li>libs/flake/CMakeLists.txt <span style="color: grey">(233d3ce)</span></li>
<li>libs/kopageapp/CMakeLists.txt <span style="color: grey">(deb7d76)</span></li>
<li>libs/kotext/CMakeLists.txt <span style="color: grey">(8929d8a)</span></li>
<li>libs/kundo2/CMakeLists.txt <span style="color: grey">(cf66a13)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(147b25c)</span></li>
<li>libs/odf/CMakeLists.txt <span style="color: grey">(574f8a5)</span></li>
<li>libs/pigment/CMakeLists.txt <span style="color: grey">(8cc00e8)</span></li>
<li>libs/rdf/CMakeLists.txt <span style="color: grey">(875ce13)</span></li>
<li>libs/textlayout/CMakeLists.txt <span style="color: grey">(cf2b83b)</span></li>
<li>libs/widgets/CMakeLists.txt <span style="color: grey">(38155e7)</span></li>
<li>libs/widgetutils/CMakeLists.txt <span style="color: grey">(bfe64ca)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111326/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>