<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111305/">http://git.reviewboard.kde.org/r/111305/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 30th, 2013, 3:26 p.m. UTC, <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, the patch looks good. Ship it!
And I agree with boemann that we don't want "ko" in the library directory names.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay, shipping. Thanks.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 30th, 2013, 3:26 p.m. UTC, <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111305/diff/1/?file=166684#file166684line50" style="color: black; font-weight: bold; text-decoration: underline;">filters/sheets/excel/export/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">50</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">calligra_filter_sheets2xls</span> <span class="s">msooxml</span> <span class="s">komain</span> <span class="s">mso</span> <span class="s">koodf</span> <span class="o">${</span><span class="nv">ZLIB_LIBRARIES</span><span class="o">}</span> <span class="s">calligrasheetscommon</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">50</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">calligra_filter_sheets2xls</span> <span class="s"><span class="hl">ko</span>msooxml</span> <span class="s">komain</span> <span class="s">mso</span> <span class="s">koodf</span> <span class="o">${</span><span class="nv">ZLIB_LIBRARIES</span><span class="o">}</span> <span class="s">calligrasheetscommon</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I suppose this should be ods2xls, right?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good eyes, but wrong, really should be sheets2xls. Because the input document is not a file in ODS format, but the working memory model of Sheets, see this in ExcelExport.cpp:
KoDocument* document = m_chain->inputDocument();
if (!document)
return KoFilter::StupidError;
d->inputDoc = qobject_cast<const Calligra::Sheets::Doc*>(document);
</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On June 29th, 2013, 12:40 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, C. Boemann and Inge Wallin.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 29, 2013, 12:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The installed libs "libmsooxml", "libodfreader", "libvectorimage", "libtextlayout" ideally also get a prefix. Attached patch does that.
It does not touch "pigment", "flake", "basicflakes", as these have unique enough names IMHO, so no clash can be expected.
Also does not touch the internal static libs which do not (yet?) get installed: mso, writerperfect.
libRtfReader would also be a candidate, but it is unclear to me whether we have the original clone of that lib in our repo, and the other one (on sf.net) should be removed. So ignoring that one here.
Open questions for me:
* "kundo2", "kformdesigner", "kformula" just use a k as prefix, so might clash with libs sometimes in kdelibs/kdeplatform? So better instead prefix with ko, not just k?
* also rename the subdirs in the repo? libs/ currently has a mix also without this patch: "main", "odf" and "rdf" are without ko, the other have the prefix in the subdir name. What would you think about a follow-up patch which adds consistency there? Will write an email to the mailinglist about that to query what people think, after this patch has been handled (discarded/committed).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(53fa5bd)</span></li>
<li>filters/karbon/wmf/CMakeLists.txt <span style="color: grey">(bc278f1)</span></li>
<li>filters/libmsooxml/CMakeLists.txt <span style="color: grey">(a9827cb)</span></li>
<li>filters/libodfreader/CMakeLists.txt <span style="color: grey">(71571f8)</span></li>
<li>filters/sheets/excel/export/CMakeLists.txt <span style="color: grey">(efd8e1a)</span></li>
<li>filters/sheets/excel/import/CMakeLists.txt <span style="color: grey">(06c6f9f)</span></li>
<li>filters/sheets/xlsx/CMakeLists.txt <span style="color: grey">(1a3ca07)</span></li>
<li>filters/stage/pptx/CMakeLists.txt <span style="color: grey">(ea87a0e)</span></li>
<li>filters/words/ascii/CMakeLists.txt <span style="color: grey">(e9846f9)</span></li>
<li>filters/words/docx/import/CMakeLists.txt <span style="color: grey">(32472dc)</span></li>
<li>filters/words/epub/CMakeLists.txt <span style="color: grey">(8954e75)</span></li>
<li>filters/words/msword-odf/CMakeLists.txt <span style="color: grey">(7479b5e)</span></li>
<li>libs/kopageapp/CMakeLists.txt <span style="color: grey">(35db53f)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(d74851b)</span></li>
<li>libs/textlayout/CMakeLists.txt <span style="color: grey">(3d9edfe)</span></li>
<li>libs/textlayout/tests/CMakeLists.txt <span style="color: grey">(71dc053)</span></li>
<li>libs/vectorimage/CMakeLists.txt <span style="color: grey">(2c25ce8)</span></li>
<li>plugins/chartshape/CMakeLists.txt <span style="color: grey">(1a7fbe3)</span></li>
<li>plugins/commentshape/CMakeLists.txt <span style="color: grey">(bf90d37)</span></li>
<li>plugins/textediting/spellcheck/CMakeLists.txt <span style="color: grey">(0dec50e)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(322f93e)</span></li>
<li>plugins/variables/CMakeLists.txt <span style="color: grey">(6e47086)</span></li>
<li>plugins/vectorshape/CMakeLists.txt <span style="color: grey">(739b9ba)</span></li>
<li>stage/part/CMakeLists.txt <span style="color: grey">(6eaf356)</span></li>
<li>stage/plugins/variable/CMakeLists.txt <span style="color: grey">(0893a76)</span></li>
<li>words/part/CMakeLists.txt <span style="color: grey">(437f443)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111305/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>