<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111306/">http://git.reviewboard.kde.org/r/111306/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 30th, 2013, 8:37 a.m. UTC, <b>Sune Vuorela</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">afaik, the DEVEL keyword is only used by cpack which no one is using (because it is kind of too primitive to be useful and not compliant with various rules set up by distributors). It is kind of usable on windows though. dunno about mac.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for review, Sune. Showed me that I need to add more explanation what this patch is about, as it has nothing to do with that DEVEL keyword of cpack :) Will update (but before split off the prefix of the include dirs into a separate patch/review request, orthogonal to this one)</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On June 29th, 2013, 2:31 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 29, 2013, 2:31 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">also...
* add that tag to all libs which install header and
split off header installation in x_DEVEL product guards
* install all calligralib headers in ${INCLUDE_INSTALL_DIR}/calligra
* install all krita headers in ${INCLUDE_INSTALL_DIR}/krita
* start to install also koproperty headers
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(53fa5bd)</span></li>
<li>cmake/modules/CalligraProductSetMacros.cmake <span style="color: grey">(17482a6)</span></li>
<li>cmake/productsets/all.cmake <span style="color: grey">(8e82b40)</span></li>
<li>cmake/productsets/desktop.cmake <span style="color: grey">(4e85bc8)</span></li>
<li>interfaces/CMakeLists.txt <span style="color: grey">(36eb42a)</span></li>
<li>kexi/formeditor/CMakeLists.txt <span style="color: grey">(00e0607)</span></li>
<li>krita/image/CMakeLists.txt <span style="color: grey">(0db29af)</span></li>
<li>krita/image/tiles3/CMakeLists.txt <span style="color: grey">(1222d5a)</span></li>
<li>krita/ui/CMakeLists.txt <span style="color: grey">(78a61c6)</span></li>
<li>libs/basicflakes/CMakeLists.txt <span style="color: grey">(4750c5f)</span></li>
<li>libs/db/CMakeLists.txt <span style="color: grey">(60e35a7)</span></li>
<li>libs/flake/CMakeLists.txt <span style="color: grey">(233d3ce)</span></li>
<li>libs/kopageapp/CMakeLists.txt <span style="color: grey">(35db53f)</span></li>
<li>libs/koproperty/CMakeLists.txt <span style="color: grey">(45aa69c)</span></li>
<li>libs/kotext/CMakeLists.txt <span style="color: grey">(8929d8a)</span></li>
<li>libs/kundo2/CMakeLists.txt <span style="color: grey">(cf66a13)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(d74851b)</span></li>
<li>libs/odf/CMakeLists.txt <span style="color: grey">(574f8a5)</span></li>
<li>libs/pigment/CMakeLists.txt <span style="color: grey">(8cc00e8)</span></li>
<li>libs/rdf/CMakeLists.txt <span style="color: grey">(875ce13)</span></li>
<li>libs/textlayout/CMakeLists.txt <span style="color: grey">(3d9edfe)</span></li>
<li>libs/widgets/CMakeLists.txt <span style="color: grey">(38155e7)</span></li>
<li>libs/widgetutils/CMakeLists.txt <span style="color: grey">(bfe64ca)</span></li>
<li>sheets/CMakeLists.txt <span style="color: grey">(e0f4a02)</span></li>
<li>stage/part/CMakeLists.txt <span style="color: grey">(6eaf356)</span></li>
<li>words/part/CMakeLists.txt <span style="color: grey">(437f443)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111306/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>