<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111265/">http://git.reviewboard.kde.org/r/111265/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3a2e13efeb61d19064dcb04aa549d8127765fb75 by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 26th, 2013, 10:55 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 26, 2013, 10:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After the renaming of the filters modules here now the renaming of all plugins which are not yet namespaced.
For the naming pattern the service type of the plugin was copied:
Calligra/Dock -> calligra_docker_
Calligra/Tool -> calligra_tool_
Calligra/Shape -> calligra_shape_
etc.
The Braindump specific plugins are prefixed with "braindump_" instead of "calligra_", following how all other app-specific plugins are also namespaced with the app name as prefix, more or less.
About the touched helper libs:
I also renamed the lib "chartshapelib" to "calligrachartshape", the suffix lib resulted in the strange name "libchartshapelib". Not sure that lib is really needed, could be perhaps just be a static lib, because besides the tests only the plugin uses it. But different problem, so for a different patch.
Similar with "kformulalib", renamed to "kformula".
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>braindump/plugins/stateshape/CMakeLists.txt <span style="color: grey">(c2376de)</span></li>
<li>braindump/plugins/stateshape/stateshape.desktop <span style="color: grey">(d089fc9)</span></li>
<li>braindump/plugins/webshape/CMakeLists.txt <span style="color: grey">(8630ce5)</span></li>
<li>braindump/plugins/webshape/webshape.desktop <span style="color: grey">(b043153)</span></li>
<li>libs/basicflakes/plugin/CMakeLists.txt <span style="color: grey">(ab06433)</span></li>
<li>libs/basicflakes/plugin/basicflakesplugin.desktop <span style="color: grey">(0f2dad1)</span></li>
<li>plugins/artistictextshape/CMakeLists.txt <span style="color: grey">(c1c0bcb)</span></li>
<li>plugins/artistictextshape/artistictextshape.desktop <span style="color: grey">(2f67422)</span></li>
<li>plugins/chartshape/CMakeLists.txt <span style="color: grey">(5517448)</span></li>
<li>plugins/chartshape/chartshape.desktop <span style="color: grey">(6969873)</span></li>
<li>plugins/chartshape/tests/CMakeLists.txt <span style="color: grey">(e415974)</span></li>
<li>plugins/chartshape/tests/odf/bubble-chart/CMakeLists.txt <span style="color: grey">(ff477c0)</span></li>
<li>plugins/chartshape/tests/odf/bug239802/CMakeLists.txt <span style="color: grey">(7440077)</span></li>
<li>plugins/chartshape/tests/odf/default-calligra-chart/CMakeLists.txt <span style="color: grey">(61d19b1)</span></li>
<li>plugins/chartshape/tests/odf/default-ooo-chart/CMakeLists.txt <span style="color: grey">(d522075)</span></li>
<li>plugins/chartshape/tests/odf/me07_percentage_stacked_bar_chart/CMakeLists.txt <span style="color: grey">(0620919)</span></li>
<li>plugins/chartshape/tests/odf/template/CMakeLists.txt <span style="color: grey">(fb163ad)</span></li>
<li>plugins/commentshape/CMakeLists.txt <span style="color: grey">(e4c130f)</span></li>
<li>plugins/commentshape/commentshape.desktop <span style="color: grey">(76081d8)</span></li>
<li>plugins/defaultTools/CMakeLists.txt <span style="color: grey">(1f16010)</span></li>
<li>plugins/defaultTools/defaulttools.desktop <span style="color: grey">(b4259e3)</span></li>
<li>plugins/dockers/CMakeLists.txt <span style="color: grey">(dde9e22)</span></li>
<li>plugins/dockers/calligradockers.desktop <span style="color: grey">(635ba49)</span></li>
<li>plugins/formulashape/CMakeLists.txt <span style="color: grey">(718f3c6)</span></li>
<li>plugins/formulashape/formulashape.desktop <span style="color: grey">(29a66b4)</span></li>
<li>plugins/formulashape/tests/CMakeLists.txt <span style="color: grey">(c411463)</span></li>
<li>plugins/musicshape/CMakeLists.txt <span style="color: grey">(c44baea)</span></li>
<li>plugins/musicshape/musicshape.desktop <span style="color: grey">(8023797)</span></li>
<li>plugins/pathshapes/CMakeLists.txt <span style="color: grey">(96fb22b)</span></li>
<li>plugins/pathshapes/pathshapes.desktop <span style="color: grey">(2f6148e)</span></li>
<li>plugins/pictureshape/CMakeLists.txt <span style="color: grey">(ea2890a)</span></li>
<li>plugins/pictureshape/pictureshape.desktop <span style="color: grey">(2f5212e)</span></li>
<li>plugins/pluginshape/CMakeLists.txt <span style="color: grey">(a95ed0c)</span></li>
<li>plugins/pluginshape/pluginshape.desktop <span style="color: grey">(896c404)</span></li>
<li>plugins/spacenavigator/CMakeLists.txt <span style="color: grey">(3c56f64)</span></li>
<li>plugins/spacenavigator/spacenavigator.desktop <span style="color: grey">(cf58384)</span></li>
<li>plugins/staging/templateshape/CMakeLists.txt <span style="color: grey">(7a0b40a)</span></li>
<li>plugins/staging/templateshape/templateshape.desktop <span style="color: grey">(21d4a0d)</span></li>
<li>plugins/staging/threedshape/CMakeLists.txt <span style="color: grey">(e50f4c6)</span></li>
<li>plugins/staging/threedshape/threedshape.desktop <span style="color: grey">(4a9bf44)</span></li>
<li>plugins/textediting/autocorrection/CMakeLists.txt <span style="color: grey">(56e6b53)</span></li>
<li>plugins/textediting/autocorrection/autocorrect.desktop <span style="color: grey">(cb26717)</span></li>
<li>plugins/textediting/changecase/CMakeLists.txt <span style="color: grey">(08e2666)</span></li>
<li>plugins/textediting/changecase/changecase.desktop <span style="color: grey">(49678ac)</span></li>
<li>plugins/textediting/spellcheck/CMakeLists.txt <span style="color: grey">(f349f3a)</span></li>
<li>plugins/textediting/spellcheck/spellcheck.desktop <span style="color: grey">(408b670)</span></li>
<li>plugins/textediting/thesaurus/CMakeLists.txt <span style="color: grey">(8cad11e)</span></li>
<li>plugins/textediting/thesaurus/thesaurustool.desktop <span style="color: grey">(bc568c8)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(3bc3628)</span></li>
<li>plugins/textshape/textshape.desktop <span style="color: grey">(5163b71)</span></li>
<li>plugins/variables/CMakeLists.txt <span style="color: grey">(2296b01)</span></li>
<li>plugins/variables/textvariables.desktop <span style="color: grey">(826e335)</span></li>
<li>plugins/vectorshape/CMakeLists.txt <span style="color: grey">(8aa997c)</span></li>
<li>plugins/vectorshape/vectorshape.desktop <span style="color: grey">(d847227)</span></li>
<li>plugins/videoshape/CMakeLists.txt <span style="color: grey">(816ae1d)</span></li>
<li>plugins/videoshape/videoshape.desktop <span style="color: grey">(35a567a)</span></li>
<li>sheets/shape/CMakeLists.txt <span style="color: grey">(9fc7d3c)</span></li>
<li>sheets/shape/spreadsheetshape-deferred.desktop <span style="color: grey">(11479bf)</span></li>
<li>sheets/shape/spreadsheetshape.desktop <span style="color: grey">(d578345)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111265/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>