<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111031/">http://git.reviewboard.kde.org/r/111031/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sure let's get it done - i just took a quick scan - looks simple enought</pre>
<br />
<p>- C.</p>
<br />
<p>On June 18th, 2013, 10:32 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, C. Boemann, Inge Wallin, and Yue Liu.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 18, 2013, 10:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As discussed now and then Calligra's libs and modules sometimes have rather generic names, like e.g. exporthtml, msooxml, textlayout, or vectorimage. It would be better behaving and possibly also easier for developers messing around in install dirs when we namespace our libs and modules and possibly also have some naming scheme where appropriate.
For a start I propose to change the names of all the filter modules, to have the prefix "calligra_filter_" and then the pattern "formatX2formatY". Attached patch renames all the modules with the pattern "calligra_filter_formatX2formatY", with variants to "formatX2formatY" where not directly applyable (should be still good enough to uniquely identify the purpose of the respective module). I also changed the cmake vars listing the source files (like vsdximport_PART_SRCS to vsdx2odg_PART_SRCS) to use the "formatX2formatY" identifier, to reduce the term variants in the CMakeLists.txt. I did not change the related source file names (like VSDXImport.cpp) though, because this would make this patch unreviewable and can be done in a different step, if wanted at all.
I also did not yet rename the desktop files, as that would need coordination with the translators and possibly should be done after 2.7.1+x release, when activity for translations of Calligra might be lower and master has got translations again (of course this patch is for master only).
Patch okay?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/flow/visio/import/CMakeLists.txt <span style="color: grey">(faa6767)</span></li>
<li>filters/flow/visio/import/flow_vsdx_import.desktop <span style="color: grey">(e18e46d)</span></li>
<li>filters/karbon/eps/CMakeLists.txt <span style="color: grey">(afec470)</span></li>
<li>filters/karbon/eps/karbon_eps_import.desktop <span style="color: grey">(c5c2cf4)</span></li>
<li>filters/karbon/eps/karbon_ps_import.desktop <span style="color: grey">(59b3b34)</span></li>
<li>filters/karbon/image/CMakeLists.txt <span style="color: grey">(18bd35c)</span></li>
<li>filters/karbon/image/karbon_jpg_export.desktop <span style="color: grey">(14e9e81)</span></li>
<li>filters/karbon/image/karbon_png_export.desktop <span style="color: grey">(e9acb75)</span></li>
<li>filters/karbon/karbon1.x/CMakeLists.txt <span style="color: grey">(1b3bda9)</span></li>
<li>filters/karbon/karbon1.x/karbon_1x_import.desktop <span style="color: grey">(235f84b)</span></li>
<li>filters/karbon/pdf/CMakeLists.txt <span style="color: grey">(3dd71c2)</span></li>
<li>filters/karbon/pdf/karbon_pdf_import.desktop <span style="color: grey">(b756597)</span></li>
<li>filters/karbon/svg/CMakeLists.txt <span style="color: grey">(789ceaf)</span></li>
<li>filters/karbon/svg/karbon_svg_export.desktop <span style="color: grey">(4486896)</span></li>
<li>filters/karbon/svg/karbon_svg_import.desktop <span style="color: grey">(558adda)</span></li>
<li>filters/karbon/svg/karbon_svgz_import.desktop <span style="color: grey">(4d51801)</span></li>
<li>filters/karbon/wmf/CMakeLists.txt <span style="color: grey">(9282735)</span></li>
<li>filters/karbon/wmf/karbon_wmf_export.desktop <span style="color: grey">(548b2f3)</span></li>
<li>filters/karbon/wmf/karbon_wmf_import.desktop <span style="color: grey">(7ee57ea)</span></li>
<li>filters/karbon/wpg/CMakeLists.txt <span style="color: grey">(fee395f)</span></li>
<li>filters/karbon/wpg/karbon_wpg_import.desktop <span style="color: grey">(53c6023)</span></li>
<li>filters/karbon/xfig/CMakeLists.txt <span style="color: grey">(aa39b5f)</span></li>
<li>filters/karbon/xfig/karbon_xfig_import.desktop <span style="color: grey">(41b7acf)</span></li>
<li>filters/plan/mpxj/import/CMakeLists.txt <span style="color: grey">(49dcf0f)</span></li>
<li>filters/plan/mpxj/import/plan_msproject_import.desktop <span style="color: grey">(98b4d3b)</span></li>
<li>filters/plan/mpxj/import/plan_msprojectexchange_import.desktop <span style="color: grey">(d0da3b4)</span></li>
<li>filters/plan/mpxj/import/plan_planner_import.desktop <span style="color: grey">(34a25bb)</span></li>
<li>filters/sheets/applixspread/CMakeLists.txt <span style="color: grey">(49a44d8)</span></li>
<li>filters/sheets/applixspread/kspread_applixspread_import.desktop <span style="color: grey">(ef2fedf)</span></li>
<li>filters/sheets/csv/CMakeLists.txt <span style="color: grey">(faa5b5f)</span></li>
<li>filters/sheets/csv/kspread_csv_export.desktop <span style="color: grey">(0f74103)</span></li>
<li>filters/sheets/csv/kspread_csv_import.desktop <span style="color: grey">(4a821a8)</span></li>
<li>filters/sheets/dbase/CMakeLists.txt <span style="color: grey">(80655ba)</span></li>
<li>filters/sheets/dbase/kspread_dbase_import.desktop <span style="color: grey">(5ed981d)</span></li>
<li>filters/sheets/excel/export/CMakeLists.txt <span style="color: grey">(5b5aac3)</span></li>
<li>filters/sheets/excel/export/kspread_excel_export.desktop <span style="color: grey">(e7b3eb7)</span></li>
<li>filters/sheets/excel/import/CMakeLists.txt <span style="color: grey">(496e113)</span></li>
<li>filters/sheets/excel/import/kspread_excel_import.desktop <span style="color: grey">(3e499c1)</span></li>
<li>filters/sheets/gnumeric/CMakeLists.txt <span style="color: grey">(a3215e3)</span></li>
<li>filters/sheets/gnumeric/kspread_gnumeric_export.desktop <span style="color: grey">(a6f68af)</span></li>
<li>filters/sheets/gnumeric/kspread_gnumeric_import.desktop <span style="color: grey">(0680a3d)</span></li>
<li>filters/sheets/html/CMakeLists.txt <span style="color: grey">(84ae42d)</span></li>
<li>filters/sheets/html/kspread_html_export.desktop <span style="color: grey">(e325fe7)</span></li>
<li>filters/sheets/html/kspread_html_import.desktop <span style="color: grey">(ce1334f)</span></li>
<li>filters/sheets/latex/export/CMakeLists.txt <span style="color: grey">(e154a63)</span></li>
<li>filters/sheets/latex/export/kspread_latex_export.desktop <span style="color: grey">(b3aa715)</span></li>
<li>filters/sheets/opencalc/CMakeLists.txt <span style="color: grey">(b850b82)</span></li>
<li>filters/sheets/opencalc/kspread_opencalc_export.desktop <span style="color: grey">(72abb3d)</span></li>
<li>filters/sheets/opencalc/kspread_opencalc_import.desktop <span style="color: grey">(70d215d)</span></li>
<li>filters/sheets/qpro/CMakeLists.txt <span style="color: grey">(0807f95)</span></li>
<li>filters/sheets/qpro/kspread_qpro_import.desktop <span style="color: grey">(a81bc9f)</span></li>
<li>filters/sheets/xlsx/CMakeLists.txt <span style="color: grey">(a8fae9a)</span></li>
<li>filters/sheets/xlsx/kspread_xlsx_import.desktop <span style="color: grey">(7ad3f33)</span></li>
<li>filters/stage/kpr2odf/CMakeLists.txt <span style="color: grey">(fe24e5c)</span></li>
<li>filters/stage/kpr2odf/Filterkpr2odf.desktop <span style="color: grey">(134c0c2)</span></li>
<li>filters/stage/powerpoint/CMakeLists.txt <span style="color: grey">(55c2080)</span></li>
<li>filters/stage/powerpoint/kpresenter_powerpoint_import.desktop <span style="color: grey">(e2deba3)</span></li>
<li>filters/stage/pptx/CMakeLists.txt <span style="color: grey">(85642f8)</span></li>
<li>filters/stage/pptx/kpresenter_pptx_import.desktop <span style="color: grey">(00d1128)</span></li>
<li>filters/words/applixword/CMakeLists.txt <span style="color: grey">(242a0d7)</span></li>
<li>filters/words/applixword/words_applixword_import.desktop <span style="color: grey">(db65669)</span></li>
<li>filters/words/ascii/CMakeLists.txt <span style="color: grey">(78655f9)</span></li>
<li>filters/words/ascii/words_ascii_export.desktop <span style="color: grey">(35a2222)</span></li>
<li>filters/words/ascii/words_ascii_import.desktop <span style="color: grey">(3aeed8e)</span></li>
<li>filters/words/docx/import/CMakeLists.txt <span style="color: grey">(aff322c)</span></li>
<li>filters/words/docx/import/words_docx_import.desktop <span style="color: grey">(e3384ad)</span></li>
<li>filters/words/epub/CMakeLists.txt <span style="color: grey">(f281c46)</span></li>
<li>filters/words/epub/words_epub2_export.desktop <span style="color: grey">(d48e543)</span></li>
<li>filters/words/epub/words_html_export.desktop <span style="color: grey">(7ddb19b)</span></li>
<li>filters/words/mobi/CMakeLists.txt <span style="color: grey">(f7e064f)</span></li>
<li>filters/words/mobi/words_Mobi_export.desktop <span style="color: grey">(2ee7f8b)</span></li>
<li>filters/words/msword-odf/CMakeLists.txt <span style="color: grey">(f903f75)</span></li>
<li>filters/words/msword-odf/words_msword-odf_import.desktop <span style="color: grey">(132397f)</span></li>
<li>filters/words/rtf/import/CMakeLists.txt <span style="color: grey">(d1ac6b1)</span></li>
<li>filters/words/rtf/import/words_rtf_import.desktop <span style="color: grey">(3f2daed)</span></li>
<li>filters/words/wordperfect/import/CMakeLists.txt <span style="color: grey">(c919657)</span></li>
<li>filters/words/wordperfect/import/words_wpd_import.desktop <span style="color: grey">(e46fbae)</span></li>
<li>filters/words/works/import/CMakeLists.txt <span style="color: grey">(2ada91b)</span></li>
<li>filters/words/works/import/words_wps_import.desktop <span style="color: grey">(27b4021)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111031/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>