<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111222/">http://git.reviewboard.kde.org/r/111222/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi, Sascha!
The point is, we have recently moved our zooming code from KoCanvasControllerWidget code to KisZoomAction and KisInputManager classes. There were several reasons for it: it makes the shortcut configurable and it doesn't conflict with any other shortcuts (which is not the case when we handle this event in the wheelEvent directly). So, I think, you need consider moving this code to the KisZoomAction. The action framework supports different modes of working, so you'll just need to implement a new mode and register a shortcut in the KisInputManager.
</pre>
<br />
<p>- Dmitry</p>
<br />
<p>On June 24th, 2013, 4:52 p.m. UTC, Sascha Suelzer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Sascha Suelzer.</div>
<p style="color: grey;"><i>Updated June 24, 2013, 4:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Small patch that zooms the canvas in smaller steps when the control key is held while turning the mousewheel.
Before the patch, in Krita, holding control while turning the wheel scrolled the canvas up and down, now it zooms in small increments.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only tested for Krita. Only did superficial testing, as in holding the control key down and turning the wheel.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoCanvasControllerWidget.cpp <span style="color: grey">(db7ded4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111222/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>