<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110700/">http://git.reviewboard.kde.org/r/110700/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 30th, 2013, 6:44 a.m. UTC, <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it looks okay and as such is committable, but I would prefer we have the followup solution before actually merging to master, so please in a local branch where you work on the next steps. When time comes this commit does/should not be squashed with the rest. If you keep it local it's easy to rebase and ammend the commit if needed, and so the final merge to master can be done in a clean way</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yep. i'll keep the local branch as a reminder. discard the RR i guess?
on a side note, shouldn't something like this preferably be part of the data model(s) on top of the SM, and as such be part of, or built on top of, the work Pierre/(Zagge?) is doing on those models? it somehow feels wrong to have this special casing built into the structure of the SM itself.</pre>
<br />
<p>- Elvis</p>
<br />
<p>On May 28th, 2013, 8:18 p.m. UTC, Elvis Stansvik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, C. Boemann, Gopalakrishna Bhat, Pierre Stirnweiss, and Thorsten Zachmann.</div>
<div>By Elvis Stansvik.</div>
<p style="color: grey;"><i>Updated May 28, 2013, 8:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In KoStyleManager, nothing is ever added to the d->unusedParagraphStyles hash, so I suggest we remove it along with the accompanying API.
I'm guessing it was an unfinished attempt to make ToC/bibliography styles not appear at all in the UI until they're used (I mean, not even appear as "Unused") ?
The code that used the API were the bibliography and ToC templates, but nothing was ever inserted into d->unusedParagraphStyles.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested bibliography functionality before/after the removal. There was no change in behavior that I could see.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/styles/KoStyleManager.h <span style="color: grey">(c44ba32)</span></li>
<li>libs/kotext/styles/KoStyleManager.cpp <span style="color: grey">(f7b9b5f)</span></li>
<li>libs/textlayout/ToCGenerator.cpp <span style="color: grey">(30df21e)</span></li>
<li>plugins/textshape/dialogs/BibliographyTemplate.h <span style="color: grey">(99ca6c4)</span></li>
<li>plugins/textshape/dialogs/BibliographyTemplate.cpp <span style="color: grey">(4bb2bd0)</span></li>
<li>plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp <span style="color: grey">(c93a673)</span></li>
<li>plugins/textshape/dialogs/SimpleTableOfContentsWidget.cpp <span style="color: grey">(48fb88e)</span></li>
<li>plugins/textshape/dialogs/TableOfContentsTemplate.h <span style="color: grey">(f98f6f9)</span></li>
<li>plugins/textshape/dialogs/TableOfContentsTemplate.cpp <span style="color: grey">(2bd73e7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110700/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>