<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110581/">http://git.reviewboard.kde.org/r/110581/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 21st, 2013, 6:40 p.m. UTC, <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110581/diff/1/?file=145634#file145634line779" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">779</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">set</span><span class="p">(</span><span class="s">KDCHART_LIBS</span> <span class="s">calligrakdchart</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is clearly overkill. Most other libraries in calligra are just referred to by their names. Just look at the uses below.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As said on irc IMHO kdchart is still an external lib (otherwise we would rename it to calligrachart, dropping the kd prefix), we just have a copy (with patches) due to upstream not providing a proper repo/releases. And if someday hopefully there will be another release then only the toplevel CMakeLists.txt has to be touched.
That is what we should target for and preparing. Let's not slipping into hardcoding the copy too much in our code, but instead perhaps pushing a little more for more interaction with upstream! :)</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On May 21st, 2013, 6:31 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated May 21, 2013, 6:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There might be some other people out there that use libkdchart... so to prevent any naming clashes we better prefix our copy.
Okay to backport to 2.7?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>3rdparty/kdchart/src/CMakeLists.txt <span style="color: grey">(0c62a5d)</span></li>
<li>CMakeLists.txt <span style="color: grey">(8b84dca)</span></li>
<li>kexi/plugins/reports/CMakeLists.txt <span style="color: grey">(14e0ff9)</span></li>
<li>plan/libs/models/CMakeLists.txt <span style="color: grey">(f168557)</span></li>
<li>plan/libs/ui/CMakeLists.txt <span style="color: grey">(f813a10)</span></li>
<li>plugins/chartshape/CMakeLists.txt <span style="color: grey">(c853ec0)</span></li>
<li>plugins/reporting/chart/CMakeLists.txt <span style="color: grey">(92bf3de)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110581/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>