<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110333/">http://git.reviewboard.kde.org/r/110333/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Dmitry Kazakov.</div>
<p style="color: grey;"><i>Updated May 18, 2013, 7:45 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It happens so, that when the cross-process Drag is dropped to the KoDocumentSectionView, some spurious MouseMove event come and start another Drag (effectively, cancelling the current one). I guess, that happens due to some weird order of setting up of event filters (in QWidget and in QDragManager), so that the QWidget's filter gets the MouseMove events before the QDragManager's one. Actually, QWidget should not get any MouseMove events during Dragiing. It should get DragMoveEvents instead.
This patch workarounds this problem (i guess, Qt is the cause) and drops all the MouseMove events when they come while the Dragging operation. I activate the workaround on X11 only, because, most probably, Qt's D&D works differently on Windows.
This patch fixed bug:
https://bugs.kde.org/show_bug.cgi?id=319334</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested vastly on the Layer Box in Krita.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp <span style="color: grey">(12689ed)</span></li>
<li>krita/ui/kis_mimedata.h <span style="color: grey">(7055043)</span></li>
<li>krita/ui/kis_mimedata.cpp <span style="color: grey">(64af6b3)</span></li>
<li>krita/ui/kis_node_model.h <span style="color: grey">(c1854a0)</span></li>
<li>krita/ui/kis_node_model.cpp <span style="color: grey">(3a21127)</span></li>
<li>krita/ui/kis_view2.cpp <span style="color: grey">(7d4c6da)</span></li>
<li>krita/ui/tests/kis_model_index_converter_test.cpp <span style="color: grey">(80a3117)</span></li>
<li>krita/ui/tests/kis_node_model_test.cpp <span style="color: grey">(1c9bb21)</span></li>
<li>libs/main/KoDocumentSectionView.h <span style="color: grey">(7a535cb)</span></li>
<li>libs/main/KoDocumentSectionView.cpp <span style="color: grey">(768c671)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110333/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>