<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110408/">http://git.reviewboard.kde.org/r/110408/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 12th, 2013, 5:02 p.m. UTC, <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As said before I think all this code should move to the docx filter as the way it is not I can't see how it will fit with the current style loading code at all. Please move to the filter and once there is a patch that will integrate it with the rest of the applications we should move it to libs. This way we will make sure we don't clutter the libs as long it is not needed there.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">+2</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On May 12th, 2013, 4:22 p.m. UTC, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Matus Uzak.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated May 12, 2013, 4:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the second step in the quest to improve styles handling in Calligra. This patch introduces text-properties, paragraph-properties and graphic-properties in the styles, which means that more specific information than only attributes. The style:text-properties element don't have any child elements but paragraph-properties do (background-image, drop-cap and tab-stops) and also graphic-properties.
Not everything is implemented yet but I wanted to support style:background-image in libs/odf for the styles that are already in use everywhere before implementing it here.
In the short term, this is important for the docx filter, and to save back named styles in Karbon and styles with family=graphic in all applications.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/odf/CMakeLists.txt <span style="color: grey">(b3940c1)</span></li>
<li>libs/odf/styles/KoOdfGraphicProperties.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/odf/styles/KoOdfGraphicProperties.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/odf/styles/KoOdfParagraphProperties.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/odf/styles/KoOdfParagraphProperties.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/odf/styles/KoOdfStyle.cpp <span style="color: grey">(aac9ea2)</span></li>
<li>libs/odf/styles/KoOdfStyleProperties.h <span style="color: grey">(9453989)</span></li>
<li>libs/odf/styles/KoOdfStyleProperties.cpp <span style="color: grey">(7a34bf9)</span></li>
<li>libs/odf/styles/KoOdfTextProperties.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/odf/styles/KoOdfTextProperties.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110408/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>